From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: rfoss@kernel.org, todor.too@gmail.com, agross@kernel.org,
andersson@kernel.org, konrad.dybcio@linaro.org,
mchehab@kernel.org, hverkuil-cisco@xs4all.nl,
sakari.ailus@linux.intel.com, andrey.konovalov@linaro.org,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2 5/9] media: qcom: camss: Fix VFE-480 vfe_disable_output()
Date: Tue, 29 Aug 2023 17:13:08 +0100 [thread overview]
Message-ID: <ebb87316-189b-3c54-d53e-3732e60cec75@linaro.org> (raw)
In-Reply-To: <20230828171725.GZ14596@pendragon.ideasonboard.com>
On 28/08/2023 18:17, Laurent Pinchart wrote:
>> vfe-480 is copied from vfe-17x and has the same racy idle timeout bug as in
>> 17x.
>>
>> Fix the vfe_disable_output() logic to no longer be racy and to conform
>> to the 17x way of quiescing and then resetting the VFE.
> How about dropping the duplicate function and share a single
> implementation for the two files ?
>
Hmm, so I looked at this.
In principle I like it. Right now vfe-170 only deals with a single
write-master = 0, whereas vfe-480 deals with multiple write-masters.
Collapsing down into one place is the right thing to do however, it
feels like a larger update to vfe-170 that merits its own series along
the lines of "Support multiple write-masters for vfe-17x" or better
still "Support virtual channels for vfe-17x" which is what is implied by
this.
Yet another thing to add to the TODO list here.
---
bod
next prev parent reply other threads:[~2023-08-29 16:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 20:06 [PATCH v2 0/9] media: qcom: camss: Bugfix series Bryan O'Donoghue
2023-08-22 20:06 ` [PATCH v2 1/9] media: qcom: camss: Fix pm_domain_on sequence in probe Bryan O'Donoghue
2023-08-28 17:00 ` Laurent Pinchart
2023-08-22 20:06 ` [PATCH v2 2/9] media: qcom: camss: Fix V4L2 async notifier error path Bryan O'Donoghue
2023-08-28 17:05 ` Laurent Pinchart
2023-08-29 10:17 ` Bryan O'Donoghue
2023-08-22 20:06 ` [PATCH v2 3/9] media: qcom: camss: Fix vfe_get() error jump Bryan O'Donoghue
2023-08-28 17:10 ` Laurent Pinchart
2023-08-22 20:06 ` [PATCH v2 4/9] media: qcom: camss: Fix VFE-17x vfe_disable_output() Bryan O'Donoghue
2023-08-28 17:15 ` Laurent Pinchart
2023-08-22 20:06 ` [PATCH v2 5/9] media: qcom: camss: Fix VFE-480 vfe_disable_output() Bryan O'Donoghue
2023-08-28 17:17 ` Laurent Pinchart
2023-08-29 16:13 ` Bryan O'Donoghue [this message]
2023-08-22 20:06 ` [PATCH v2 6/9] media: qcom: camss: Fix missing vfe_lite clocks check Bryan O'Donoghue
2023-08-28 17:18 ` Laurent Pinchart
2023-08-22 20:06 ` [PATCH v2 7/9] media: qcom: camss: Fix invalid clock enable bit disjunction Bryan O'Donoghue
2023-08-28 17:19 ` Laurent Pinchart
2023-08-22 20:06 ` [PATCH v2 8/9] media: qcom: camss: Fix set CSI2_RX_CFG1_VC_MODE when VC is greater than 3 Bryan O'Donoghue
2023-08-28 17:22 ` Laurent Pinchart
2023-08-22 20:06 ` [PATCH v2 9/9] media: qcom: camss: Fix csid-gen2 for test pattern generator Bryan O'Donoghue
2023-08-28 17:27 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebb87316-189b-3c54-d53e-3732e60cec75@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=andrey.konovalov@linaro.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=konrad.dybcio@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rfoss@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=stable@vger.kernel.org \
--cc=todor.too@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®