From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 582D222C9FA for ; Mon, 13 Jan 2025 15:09:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736780958; cv=none; b=RJnA6VE6Kk1UYjdcJy7X2pfkhTT788BmYJMuGhYwl2CQvTnMnAjlJ7mYE2kdQP+agm/uIAVdhoqP8fjapYlJFkuKXUCIGellUOztwrti81bT4FlrIqgnLOQhvngu0hvLPBFzjmkfoRLOPT00iNfdNd0QLMpkBbSnaZ3nZODaTQo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736780958; c=relaxed/simple; bh=kRhkE5n7v4Whpf8fVWtjsSx5QcAs1w8kpM+1riSUPMc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Kv63BPGTSI+Z64IhBlbXPg9TiFNPcHekO7ByApRDJCLCTjvPbVzj8BVsG/50yHDbOPeUz6z6o9DZuMIM8nO3ThMw1++Rgc17bHHFTAcJaNSqTkXeIWmfIIEvO7QcwPmqccDYZ5WvIBiuLVRxJPuLmJRPPCD7g3iHgskceTuIYYY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=V5rK6CR6; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="V5rK6CR6" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4361815b96cso31098395e9.1 for ; Mon, 13 Jan 2025 07:09:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1736780955; x=1737385755; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9ObLtarfixbuoeU4sYBvXiHlMBkt4zlHaerO6eMC7G8=; b=V5rK6CR6pUA6G1VVULeeGmJsdV3Huv7OKY4gkjSrV5dWtmM0MnuBrQPqyY5AtFJow4 gtFRYO20HPF5UTU3JPQYAJbJGwgW+ZszDc0XtJ4/wT0Qfbq8CY5sAsB2pLsmco2uVBVx EbDNzeik/MxVxudwprgblWKZjF1WNlQw3vLMHA56ejabtOq+EIJ0XghAXmEJyzLNQnwn TonEa3NN16mr/aYXXVLkxQ7okwtSDIPQxezoQkn2Gzfo3O+YbpMR60O4Y2nVaUYBImfy nDXaZP3vMiVk2sT0xzMEvXu61F7IUuKJT9yIo1kYp7jmIPP3oS9QH8e2hl3k+tR68C0L jx3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736780955; x=1737385755; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9ObLtarfixbuoeU4sYBvXiHlMBkt4zlHaerO6eMC7G8=; b=MSvG3JgZ4CZP9xCPzgc6QpFsZ1JAWjI7VshlBfUp3PTAqU2bgRUpvEArDHft/oeoyw xkg6luDKLW5JHoajQTbewux784U+cJaz1xAPxh/5aUL5mHDptUJ4dFjMy+TqXc/AqP96 CVdzCNNeEAmtrVCaW5uMU+p0EeDx7yXYcDs9FPwSLe4wXYvKEHiBQsgUURPAfzq2gPse 1HovDlHdhtIyk5GPuu5TBw7OkITscll8mmXgu8u+FDwls6oxQxlt6IWoH1oysvocUAKu di1vU0v6o6US9DjYbTqvr/cYA6FXhzrSi7yfARgbiOR4uXLbvTGSZFQOKx458MjPxREQ YeMQ== X-Forwarded-Encrypted: i=1; AJvYcCVb+5RHUDO2z1RMDKJLtSnwvPTKUxQwMlQ0RJGLAEcqk8S5FoMRbGwmGxXLO07RfZyf9hRzJeIl4ILrWGE=@vger.kernel.org X-Gm-Message-State: AOJu0YyFGFREIlNDQELb2Xb1KbIJT0IXruIk6mMV1sYcofL1qgge2hM4 ZygPo8e2nyX9TQ4v1RTz8/KMAn47BhyS97vp7w+UnyL4hGxTpqufjlU0aQpZNvY= X-Gm-Gg: ASbGncvm0z6mvRF+Ain2QhQnKdeqNq7qKtkzDlN3X5ZzqcqIzJpYm3GGWmDvCBW7IFS UrmAelE6YXKTeQzXhv63/8r2EPrwnbbwMrAPUYbTcIqVVREaMnlRlr6YPExP/OLeGdaPJk2i0+w WjdG5mpeSp/ONX904xJtq93Z2BvG74CNpf0ZHHa4+lpfs7beT9aEE6z/YZ90QRkMgbS7AmxzM/E zbYFFjf1Mrxl8kWuMkI1kXuhV4UOwWDqq1I/KDqs/XRnIxGoe9JDnGCckOd X-Google-Smtp-Source: AGHT+IEsbWMFnleSfxZtUy8qfCZDcHp6iHBDwND8NHE6D8XDA1Ya1X/7dUhnhfiTLdJ7vz3kEw7s+w== X-Received: by 2002:a05:600c:1c14:b0:436:1ac2:1ad2 with SMTP id 5b1f17b1804b1-436e26c0400mr171652465e9.19.1736780954585; Mon, 13 Jan 2025 07:09:14 -0800 (PST) Received: from [10.100.51.161] ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436e2dc0f69sm179356045e9.13.2025.01.13.07.09.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jan 2025 07:09:14 -0800 (PST) Message-ID: Date: Mon, 13 Jan 2025 16:09:13 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 2/2] module: Introduce hash-based integrity checking To: Luis Chamberlain , linux@weissschuh.net Cc: Arnout Engelen , arnd@arndb.de, da.gomez@samsung.com, linux-arch@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org, masahiroy@kernel.org, nathan@kernel.org, nicolas@fjasle.eu, samitolvanen@google.com References: <20241225-module-hashes-v1-2-d710ce7a3fd1@weissschuh.net> <20250109105227.1012778-1-arnout@bzzt.net> Content-Language: en-US From: Petr Pavlu In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/10/25 20:16, Luis Chamberlain wrote: > On Thu, Jan 09, 2025 at 11:52:27AM +0100, Arnout Engelen wrote: >> On Fri, 3 Jan 2025 17:37:52 -0800, Luis Chamberlain wrote: >>> What distro which is using module signatures would switch >>> to this as an alternative instead? >> >> In NixOS, we disable MODULE_SIG by default (because we value >> reproducibility over having module signatures). Enabling >> MODULE_HASHES on systems that do not need to load out-of-tree >> modules would be a good step forward. >> > > Mentioning this in the cover letter will also be good. So two > distros seemt to want this. I'm aware that folks from the reproducible build community have been interested in this functionality [1, 2]. Some people at SUSE have been eyeing this as well. I've let them know about this series. It would help with the mentioned build reproducibility and from what I understood, it should also avoid in SUSE case some bottlenecks with HSM needing to sign all modules. I agree that we should make sure that whatever ends up added is something that some distributions actually check it works for them and they intend to use it. >From the SUSE side, I can also support that the feature should work seamlessly with the current MODULE_SIG. [1] https://lists.reproducible-builds.org/pipermail/rb-general/2024-September/003530.html [2] https://gitlab.archlinux.org/archlinux/packaging/packages/linux/-/merge_requests/1 -- Thanks, Petr