From: Pavan Kondeti <quic_pkondeti@quicinc.com>
To: Saravana Kannan <saravanak@google.com>
Cc: Zhenhua Huang <quic_zhenhuah@quicinc.com>,
<gregkh@linuxfoundation.org>, <rafael@kernel.org>,
<linux-kernel@vger.kernel.org>, <quic_pkondeti@quicinc.com>,
<quic_tingweiz@quicinc.com>
Subject: Re: [RESEND PATCH] driver core: Clear FWNODE_FLAG_LINKS_ADDED in device_links_purge()
Date: Tue, 3 Oct 2023 09:04:20 +0530 [thread overview]
Message-ID: <ebc07a1b-dbf6-40d9-8f62-03d58e4b3038@quicinc.com> (raw)
In-Reply-To: <CAGETcx_+62Rt4fh0jM6stO2_eGPjtxaxVC=KxAei5XfBLq3_Zw@mail.gmail.com>
On Mon, Oct 02, 2023 at 02:40:52PM -0700, Saravana Kannan wrote:
>
> > It usuallly happens in the case of a glue driver. Of_platform_populate()
> > allows us to populate subnodes. We may do it in ancestor node probing
> > function, then check subnode's probing status because there may be chances
> > that suppliers of subnode are not ready. We may further need to do
> > of_platform_depopulate(which purges device links) and in some time
> > of_platform_populate() again. Such case we miss fwnode links(so that device
> > links) during second time of populating subnodes.
>
> Why is the device driver for the parent device adding the child
> devices before it knows it can finish probing? Adding the child
> devices should be the last thing you do as part of your probe.
>
Is there a way how a parent device driver can know if the dependencies
of its child are met before registering the device?
Does it make sense to treat the child dependencies as parent (if it
opts) dependencies in the firmware device links? Not every child may be needed
for the parent to operate but some devices which are glue devices (SoC
specific) for children (say 3rd party IP or generic devices) would
definitely want to know if their children are ready for probe.
Thanks,
Pavan
next prev parent reply other threads:[~2023-10-03 3:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 2:30 Zhenhua Huang
2023-09-27 5:57 ` Greg KH
2023-09-27 6:32 ` Zhenhua Huang
2023-09-27 8:08 ` Greg KH
2023-09-27 5:57 ` Greg KH
2023-09-27 6:34 ` Zhenhua Huang
2023-09-27 8:08 ` Greg KH
2023-09-27 9:53 ` Zhenhua Huang
2023-10-02 21:40 ` Saravana Kannan
2023-10-03 3:34 ` Pavan Kondeti [this message]
2023-10-05 9:32 ` Greg KH
2023-10-05 10:49 ` Pavan Kondeti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebc07a1b-dbf6-40d9-8f62-03d58e4b3038@quicinc.com \
--to=quic_pkondeti@quicinc.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_tingweiz@quicinc.com \
--cc=quic_zhenhuah@quicinc.com \
--cc=rafael@kernel.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®