From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f46.google.com (mail-oa1-f46.google.com [209.85.160.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE665388E49 for ; Mon, 10 Aug 2026 19:28:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786390114; cv=none; b=KbssnT/FYywDWDmSHN2gGffcfRQZzvkuhIVX9HBckXrK4xmMEnlqQq8jNwAVBcKpTtpxTligbo8uBkM5h/G2TukVlgyHQ/ljgJsH323AeqJbuPjldx/srL/ZbUxYMzk+sq2JzW5kLTlVKrhC0hBE/4tFSZCjQzZY6q1Qs2btp5c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786390114; c=relaxed/simple; bh=+sEsScIM2qAs6sSevujTtRTZbuA1fPGvSKnZmuUlN0M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=obkSq+v1/HEAIa5wLGjphcdVmukn7K/mYajKEGX5dvFJNw0QRnY3y04GJxccYsxZuYza+em9o2doZ2E6PvB07mvjkXcX+BoV2JD73cRBsAoGpgjS1fIN9UUFmCW5N4BUMWdnoTHnDZNOcaXQV7PNxTHrx3Ak65KGQeEy1SNv4Pc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=djnV1KVU; arc=none smtp.client-ip=209.85.160.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="djnV1KVU" Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-45133d2974fso1271355fac.1 for ; Mon, 10 Aug 2026 12:28:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1786390108; x=1786994908; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=NgO72jJ70tMCTC4c4xhvVwaNiqswCBephsns35OjoNk=; b=djnV1KVUha+eAWHZucV38daFaVj4Z5bKkQSASbLABgazKggzIYw+760wFnllNMr3rU nDGqJQXq/hAW+zFlv7DuvyBhqkHBHLin9zVKafWix5FcbDRzl3qGYsXmpfay++B8r+Ji cB8gdRWOiWhrrqUfxj2FgEVfsafwylj+cPP0BjQxc1bsE0S0uXbvnXG6aZEoL+td+GfR HDBDsMXB/ZObrVxigWElp5OeHvaMb2SuZWloAKjYxiN/Tuhnt3lf0JLsEgwREKK2mQP8 b5N6Z+PHXJxISnI1lc21iEXefNDgj10gVmLyXh2+j4OFjH9M4Wi0/NT/39ypJ7ynR6Gc UO/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786390108; x=1786994908; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=NgO72jJ70tMCTC4c4xhvVwaNiqswCBephsns35OjoNk=; b=nxryoNk17abePpFW/SsrZ9n0AMm5SArRWrmMSHvSc8e3KG30tE45D/mGV2oc97FzY6 /Whx4QoWZ6+IJghk6pNivGoAfiw0BkQe57GwR32U2Kr0Ecmi526PSE5PKBSoiSYFuK2k e2VmE+2w2M/YUxE4MHEmJNiTtJlAiKa8wcE158vKSHFLsywdfIFTcwVhVcSyYcfuWt56 /GNCs9wUp4+0x6WDf3XrHN69Vblip5xijvAdiN6EBLMtNSMcRebYs3ey+d3ERNwU7FmM sTeWbySzaceJgca6Mlurj5r7+UfaTv+Q+9MNUuPokA5U7AEe01ZKsoh3/49YdFvSjtZk fl5w== X-Forwarded-Encrypted: i=1; AHgh+RqJtWAlqzC3VCYkdfl7EcMm/VOwg+9puyM3wY81FFgw3cJDwcAeb7PeGNL2XNDyOLVOkuUc5UsN5PwOCnE=@vger.kernel.org X-Gm-Message-State: AOJu0YzZdA5CwKw2xIbvGBL0MhnWGF0HtwyMuwODkP0Udl1boRF/Yxzu Vfheb6WerDYbHHom7am/0J1JiMeFuoi0PBArnSwZc0r4pRRMzkqAXT8nqwMLJz30VFw= X-Gm-Gg: AR+sD12lG6gIz7nhr9YYTxtxo3ohr3GLXyIO4rsfIrWOf2h8oNBT2KD1ON59tgX9txY WLVulBgcd+hqY+L55XmFylm4rKwUXSdHCtJTSGPnDQcfBgzliaSFXj5XArC94MmRWzFt58n6JIu anPm3aiauoKrgMvw2EkWYD/ASPoMX24enpm022o5tejoA8aKiEGIyc2EMx8BzRiJkcGG6ERfU6b 0H/VxYzs6CRL638G8LDzIK4GOlO8ZBdaCfNb64AngcfKWWpCzkY80r1o+xhXh22ozyTR9jaynpB 7od0WbVOmEyo+kSjuCfXAmzMnc/UR46JyzsFMVuEnmetih6Wfb0bxlBIVFqUU7MqeCvdQhCEcTZ m3YkmtJwiTB71nqTVvAuIpil3EFEnxmnZ76d1j+jk+1UN36WEXs1mloTt9P/5H3EuKs5AhWfFtw T73F6fhC0HQ/PeazSBvMjQ2ul31gWRKGAuttRYe39grUDDF/33JjOg5rfxM4Vp1p5c3MwkvAqHq e/zBxr/wmYBx/FWAQGMryOihess98MpirLnmFQ= X-Received: by 2002:a05:6870:3d96:b0:441:f3f6:622b with SMTP id 586e51a60fabf-45e0552f4d0mr2384263fac.5.1786390108284; Mon, 10 Aug 2026 12:28:28 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:e05b:7923:cf50:e4cf? ([2600:8803:e7e4:500:e05b:7923:cf50:e4cf]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-459f1a76701sm8915038fac.5.2026.08.10.12.28.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Aug 2026 12:28:27 -0700 (PDT) Message-ID: Date: Mon, 10 Aug 2026 14:28:26 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] iio: humidity: am2315: add am2320 to i2c_device_id table To: =?UTF-8?Q?Nicol=C3=A1s_Antinori?= , Jonathan Cameron Cc: Andy Shevchenko , Brigham Campbell , Jori Koolstra , Marcelo Schmitt , =?UTF-8?Q?Nuno_S=C3=A1?= , Shuah Khan , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linux.dev References: <20260810183337.451812-1-nico.antinori.7@gmail.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260810183337.451812-1-nico.antinori.7@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 8/10/26 1:32 PM, Nicolás Antinori wrote: > The AM2320 is fully compatible with the AM2315 sensor in terms of I2C > communication protocol and measurement conversions. > > Add the "am2320" entry to the i2c_device_id table. Interesting. No devicetree bindings for this one? What kind of system is it on? > > Signed-off-by: Nicolás Antinori > --- > v2: > - Adapted KConfig text using the suggestions from v1 by Nuno Sá and Andy > Shevchenko > > v1: https://lore.kernel.org/all/20260805183733.1000550-1-nico.antinori.7@gmail.com/T/#u > > drivers/iio/humidity/Kconfig | 8 +++++--- > drivers/iio/humidity/am2315.c | 3 ++- > 2 files changed, 7 insertions(+), 4 deletions(-) > > diff --git a/drivers/iio/humidity/Kconfig b/drivers/iio/humidity/Kconfig > index 54f11f000b6f..10598a0b15bc 100644 > --- a/drivers/iio/humidity/Kconfig > +++ b/drivers/iio/humidity/Kconfig > @@ -5,13 +5,15 @@ > menu "Humidity sensors" > > config AM2315 > - tristate "Aosong AM2315 relative humidity and temperature sensor" > + tristate "Aosong AM2315 and similar relative humidity and temperature sensor" > depends on I2C > select IIO_BUFFER > select IIO_TRIGGERED_BUFFER > help > - If you say yes here you get support for the Aosong AM2315 > - relative humidity and ambient temperature sensor. > + If you say yes here you get support for the Aosong relative > + humidity and ambient temperature sensors: > + - AM2315 > + - AM2320 > > This driver can also be built as a module. If so, the module will > be called am2315. > diff --git a/drivers/iio/humidity/am2315.c b/drivers/iio/humidity/am2315.c > index f29baa251f9f..5bce5eec45cc 100644 > --- a/drivers/iio/humidity/am2315.c > +++ b/drivers/iio/humidity/am2315.c > @@ -1,6 +1,6 @@ > // SPDX-License-Identifier: GPL-2.0-only > /* > - * Aosong AM2315 relative humidity and temperature > + * Aosong AM2315 and similar relative humidity and temperature > * > * Copyright (c) 2016, Intel Corporation. > * > @@ -251,6 +251,7 @@ static int am2315_probe(struct i2c_client *client) > > static const struct i2c_device_id am2315_i2c_id[] = { > { .name = "am2315" }, > + { .name = "am2320" }, > { } > }; > MODULE_DEVICE_TABLE(i2c, am2315_i2c_id); > -- > 2.47.3 > Currently, the driver sets `indio_dev->name = AM2315_DRIVER_NAME;` Usually, when there is more than one chip supported in a driver, we want this to be the the name of the actual chip. (And we usually try to avoid DRIVER_NAME macros so removing that would be a welcome change.)