From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E44FC6FA82 for ; Mon, 19 Sep 2022 08:43:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230030AbiISInh (ORCPT ); Mon, 19 Sep 2022 04:43:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229632AbiISInd (ORCPT ); Mon, 19 Sep 2022 04:43:33 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 640E921E13 for ; Mon, 19 Sep 2022 01:43:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663577011; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c68X5zyTPcgo56gf8lFXosz3ez64Ms9Dsywzzb9DBq4=; b=X+OU8pcKEozN126RgpG1ZS07kzJXJDTxK20EBqH02V4+wi71v9AOpgQm6M2bFL/RAOaTeV ROH7FikQrtnk/lFS5Q02NLpyEJAtUujzZ8giXOwZ9JXvbOUy2PDASn2NSARYyU+G2ckyVc 0tG/8Rg9jVz2aEndebJ79SknI1cu1vQ= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-141-I1yK1JXENtu9QaqY-S8Eig-1; Mon, 19 Sep 2022 04:43:27 -0400 X-MC-Unique: I1yK1JXENtu9QaqY-S8Eig-1 Received: by mail-wm1-f70.google.com with SMTP id y15-20020a1c4b0f000000b003b47578405aso2362368wma.5 for ; Mon, 19 Sep 2022 01:43:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date; bh=c68X5zyTPcgo56gf8lFXosz3ez64Ms9Dsywzzb9DBq4=; b=hirjjEAoH411sQqkpW3Q4/lH0AN5etyHiOKlR0fq9a419SASQwqIPJKnU9okLIlI0L ZFLCwZtUjXHPTGnT56RBAv9L9XKrRnABSnSG3Z+LqVQWaXEoNf398YWHW5Z5rCoKGZmN sZeKzshFK9JQ0bmsVtAufwwpc4OBuYvq5aQR2HvIVy65+aBL13wWPbZWLUIABbQu0HSt 61FCGHEWzxtGmZ4gbC+vz/4o1GDVembMr9uSA/f7PfmpzhGKS41sewhSUVfDrg4xsY3D vactr8bzQNgJwfxC8VKIz5eX/xXebJgTTc1wzT7JTJ7lVhO2lypG2jNEXZe5jP4MQQcN rfJw== X-Gm-Message-State: ACrzQf1+tctpJR8XGYjpJDiFKInAKnr9j+Fj1RfFQ3jH9xriC3Mq0+Ze D4Fqx+nqy1UTMHbRRWmEAqr+E536n0PkQI/CBqfzqrx8Nn9FuS/vlccKafPWKvNJlMYvO7L+a0N S+RZdaR+DeaJ811HUZgddVhvU X-Received: by 2002:a05:600c:4e11:b0:3b4:91fd:d0c with SMTP id b17-20020a05600c4e1100b003b491fd0d0cmr11562108wmq.71.1663577006568; Mon, 19 Sep 2022 01:43:26 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6N7jj2hCArDkIS0hqCNfKGStr12fevzZwsYldSD36MylkUB8fFQzxSwsr4/3VsP5ZV8nEMQw== X-Received: by 2002:a05:600c:4e11:b0:3b4:91fd:d0c with SMTP id b17-20020a05600c4e1100b003b491fd0d0cmr11562098wmq.71.1663577006284; Mon, 19 Sep 2022 01:43:26 -0700 (PDT) Received: from ?IPV6:2003:cb:c703:c100:c136:f914:345f:f5f3? (p200300cbc703c100c136f914345ff5f3.dip0.t-ipconnect.de. [2003:cb:c703:c100:c136:f914:345f:f5f3]) by smtp.gmail.com with ESMTPSA id h22-20020a05600c2cb600b003b4868eb71bsm14009883wmc.25.2022.09.19.01.43.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Sep 2022 01:43:25 -0700 (PDT) Message-ID: Date: Mon, 19 Sep 2022 10:43:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH -next v2 1/5] docs: notifier-error-inject: fix non-working usage of negative values Content-Language: en-US To: Akinobu Mita , Zhao Gongyi Cc: linux-doc@vger.kernel.org, LKML , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Jonathan Corbet , osalvador@suse.de, shuah@kernel.org References: <20220915085757.258608-1-zhaogongyi@huawei.com> <20220915085757.258608-2-zhaogongyi@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17.09.22 07:39, Akinobu Mita wrote: > 2022年9月15日(木) 18:01 Zhao Gongyi : >> >> Fault injection uses debugfs in a way that the provided values via >> sysfs are interpreted as u64. Providing negative numbers results in >> an error: >> >> # cd sys/kernel/debug/notifier-error-inject/memory >> # echo -12 > actions/MEM_GOING_ONLINE/error >> -bash: echo: write error: Invalid argument >> >> Update the docs and examples to use "printf %#x " in these cases. > > I'd rather fix the notifier-error-inject module than change the user interface. > I'll send a patch, so could you check if that solves the problem. > That will also make patch #2 unnecessary, correct? -- Thanks, David / dhildenb