From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gz.d.sender-sib.com (gz.d.sender-sib.com [77.32.148.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C48D038BF75 for ; Mon, 9 Mar 2026 10:13:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=77.32.148.26 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773051217; cv=none; b=aIFlkXmidapMjBYDZp658U/d/C8psK16bR1CDpjYBk3NE8y0jfQPNqUBZ6fGafCddU+c/aizAJdQtAb1VKod9Hyt/Y+xEsAKZpAi0rE4MCn0+PIDCg/zjJ5VpBk2LtswIvxhCO9V6GWyyuxRNDa8wA4H8+dI3+0Gi0KqIwhRzZU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773051217; c=relaxed/simple; bh=leV9CnIFeoOPZI1o/0bHtXTdNX8/o6qWmLDRA8ywHug=; h=From:Date:Subject:To:Message-Id:Mime-Version:Cc; b=eoDGUJ3QSB7a5XpVtsVzhLQ1MQirKd6FFKRLoVlxHdJYwgVp8PKQWo3JZCt+sU6HfxHl8TibxTOprNFLDsaKsIwJqqTVydyuHj3EBluMRxWUHDZh9ZkQF3x3L5d0EzmrEwfS2H7Er6cY9zW0rX6gwGNwIy9yyt+mIdU7SKfns3o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=dipeshchaudhary.in; spf=pass smtp.mailfrom=gz.d.sender-sib.com; dkim=pass (2048-bit key) header.d=dipeshchaudhary.in header.i=@dipeshchaudhary.in header.b=eDRw8RHY; arc=none smtp.client-ip=77.32.148.26 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=dipeshchaudhary.in Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gz.d.sender-sib.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dipeshchaudhary.in header.i=@dipeshchaudhary.in header.b="eDRw8RHY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dipeshchaudhary.in; q=dns/txt; s=brevo1; bh=leV9CnIFeoOPZI1o/0bHtXTdNX8/o6qWmLDRA8ywHug=; h=from:subject:date:to:cc:mime-version:content-transfer-encoding:list-unsubscribe:x-csa-complaints:list-unsubscribe-post:message-id:x-sib-id:feedback-id; b=eDRw8RHYSnatB0tWpOEZd19dS+hR8mmCVtk7qhFUiK2wbdVeVOhRkZ+XBSiJ9tB36na/eSYuvnEp VYdvICYim5fDfBXbelcf+W6JNhUok/Ujc/wsSQxgA3b0x2aMfhjO+YQ1MJ0jO0WqdsNewj4a/vBq BF13YfoTmwdQaRvjKLrHzVviU3U2XIGh/PUgGqK8k9oX2tfgt1VayhBQYq8PpzKEk9afP2gpZTSk 2TFYLDLl0vdk3UhUThyMI1ODGzZNPnpGyGElh5zBNV0hbOWzXZ7SnoOQi5+4jYFTxNUnSBlsFyXx XklS5odT91jZJcNV4bSrOnGV6XSufWO46319KQ== From: "dipesh chaudhary" Date: Mon, 9 Mar 2026 10:13:11 +0000 Subject: Re: [PATCH] staging: sm750fb: constify g_fbmode array Feedback-ID: 77.32.148.26:10551297_-1:10551297:Sendinblue X-CSA-Complaints: csa-complaints@eco.de X-Mailin-EID: NDQ2MTgxMzU4fmxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmd%2BPDIwMjYwMzA5MTAxMzExLjI4MTM2Ni0xLW1lQGRpcGVzaGNoYXVkaGFyeS5pbj5%2BZ3ouZC5zZW5kZXItc2liLmNvbQ%3D%3D To: X-sib-id: BxmFQ3DruOx4wWHL_ENJ_SF6joXO8lXjfxAQG5108BbSl3zaoIHVR9ezLZFJZ2HEC6rz73iVmzJs_3AcoKFEtexP4C6VZnlF2dOlhUdqDZ712FXqsm3NbDdW4vK08rHCEz1L4qhwciQCXkRoKIwhepO2P1mJOSlSPV2BRxTM_IiG1-TgDz6Ck5QIrA Message-Id: Origin-messageId: <20260309101311.281366-1-me@dipeshchaudhary.in> List-Unsubscribe-Post: List-Unsubscribe=One-Click Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.47.3 Content-Transfer-Encoding: quoted-printable Cc: , , , , Hi Greg, You were absolutely right. I just set up my local build environment and ran= `make drivers/staging/sm750fb/sm750.o`, and it immediately threw `error: a= ssignment of read-only location`. I fell into the classic checkpatch trap. I blindly applied the `const` sugg= estion without checking the surrounding code, failing to realize the driver= dynamically writes to `g_fbmode` during runtime in `sm750fb_setup` and `ly= nxfb_set_fbinfo`.=20 Thank you for pushing me to test-build. I will drop this patch entirely, as= the checkpatch warning is a false positive here. I have learned a valuable= lesson about not trusting static analysis scripts over actually reading th= e C code and compiling it. Best regards, Dipesh Chaudhary