From: Hans Verkuil <hverkuil@xs4all.nl>
To: "Wu, Songjun" <Songjun.Wu@microchip.com>,
nicolas.ferre@atmel.com, robh@kernel.org
Cc: laurent.pinchart@ideasonboard.com,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, "Arnd Bergmann" <arnd@arndb.de>,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
"Benoit Parrot" <bparrot@ti.com>,
linux-kernel@vger.kernel.org,
"Andrew-CT Chen" <andrew-ct.chen@mediatek.com>,
"Sudip Mukherjee" <sudipm.mukherjee@gmail.com>,
"Kamil Debski" <kamil@wypas.org>,
"Tiffany Lin" <tiffany.lin@mediatek.com>,
"Peter Griffin" <peter.griffin@linaro.org>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Mikhail Ulyanov" <mikhail.ulyanov@cogentembedded.com>,
"Richard Röjfors" <richard@puffinpack.se>,
"Hans Verkuil" <hans.verkuil@cisco.com>,
"Laurent Pinchart" <laurent.pinchart+renesas@ideasonboard.com>,
"Simon Horman" <horms+renesas@verge.net.au>
Subject: Re: [PATCH v6 1/2] [media] atmel-isc: add the Image Sensor Controller code
Date: Fri, 22 Jul 2016 09:21:07 +0200 [thread overview]
Message-ID: <ebd3617c-ad3c-d0e0-e024-b72924b5f864@xs4all.nl> (raw)
In-Reply-To: <bc8fc3da-9fe0-71ee-e55a-4d8c50b10cd3@microchip.com>
On 07/22/2016 07:18 AM, Wu, Songjun wrote:
<snip>
>>> +/*
>>> + * index(0~11): raw formats.
>>> + * index(12~12): the formats which can be converted from raw format by ISC.
>>> + * index(): the formats which can only be provided by subdev.
>>> + */
>>> +static struct isc_format isc_formats[] = {
>>
>> static const
>>
> Some members in structure isc_format need be modified, so it can not be
> const.
OK. Please add a comment about that.
Regards,
Hans
next prev parent reply other threads:[~2016-07-22 7:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-21 8:14 [PATCH v6 0/2] [media] atmel-isc: add driver for Atmel ISC Songjun Wu
2016-07-21 8:14 ` [PATCH v6 1/2] [media] atmel-isc: add the Image Sensor Controller code Songjun Wu
2016-07-21 9:13 ` Hans Verkuil
2016-07-22 5:18 ` Wu, Songjun
2016-07-22 7:21 ` Hans Verkuil [this message]
2016-07-21 8:14 ` [PATCH v6 2/2] [media] atmel-isc: DT binding for Image Sensor Controller driver Songjun Wu
2016-07-21 22:03 ` Rob Herring
2016-07-21 8:41 ` [PATCH v6 0/2] [media] atmel-isc: add driver for Atmel ISC Hans Verkuil
2016-07-22 5:21 ` Wu, Songjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebd3617c-ad3c-d0e0-e024-b72924b5f864@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=Songjun.Wu@microchip.com \
--cc=andrew-ct.chen@mediatek.com \
--cc=arnd@arndb.de \
--cc=bparrot@ti.com \
--cc=geert@linux-m68k.org \
--cc=hans.verkuil@cisco.com \
--cc=horms+renesas@verge.net.au \
--cc=kamil@wypas.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mikhail.ulyanov@cogentembedded.com \
--cc=nicolas.ferre@atmel.com \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=peter.griffin@linaro.org \
--cc=richard@puffinpack.se \
--cc=robh@kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=tiffany.lin@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®