From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751316AbdAaKH5 (ORCPT ); Tue, 31 Jan 2017 05:07:57 -0500 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:47082 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751679AbdAaKHr (ORCPT ); Tue, 31 Jan 2017 05:07:47 -0500 Subject: Re: [PATCH 11/17] net: stmmac: Rewrite two test against NULL value To: Corentin Labbe , , References: <20170131091152.13842-1-clabbe.montjoie@gmail.com> <20170131091152.13842-12-clabbe.montjoie@gmail.com> CC: , From: Giuseppe CAVALLARO Message-ID: Date: Tue, 31 Jan 2017 11:07:41 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <20170131091152.13842-12-clabbe.montjoie@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.51] X-ClientProxiedBy: SFHDAG4NODE1.st.com (10.75.127.10) To SFHDAG4NODE1.st.com (10.75.127.10) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-01-31_04:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/31/2017 10:11 AM, Corentin Labbe wrote: > This patch rewrite two test against NULL value with correct style. > > Signed-off-by: Corentin Labbe Acked-by: Giuseppe Cavallaro > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > index b0154d5..2df36bd 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > @@ -700,7 +700,7 @@ static void stmmac_adjust_link(struct net_device *dev) > int new_state = 0; > unsigned int fc = priv->flow_ctrl, pause_time = priv->pause; > > - if (phydev == NULL) > + if (!phydev) > return; > > spin_lock_irqsave(&priv->lock, flags); > @@ -1143,7 +1143,7 @@ static void dma_free_tx_skbufs(struct stmmac_priv *priv) > DMA_TO_DEVICE); > } > > - if (priv->tx_skbuff[i] != NULL) { > + if (priv->tx_skbuff[i]) { > dev_kfree_skb_any(priv->tx_skbuff[i]); > priv->tx_skbuff[i] = NULL; > priv->tx_skbuff_dma[i].buf = 0; >