From: Ping-Ke Shih <pkshih@realtek.com>
To: Rosen Penev <rosenp@gmail.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: Zong-Zhe Yang <kevin_yang@realtek.com>,
Kalle Valo <kvalo@kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH rtw-next] wifi: rtw89: acpi: check for _DSM function support before evaluating it
Date: Mon, 2 Nov 2026 03:28:26 +0000 [thread overview]
Message-ID: <ebd3c83183464c3e9c218337a568b59a@realtek.com> (raw)
In-Reply-To: <20261101222535.34573-1-rosenp@gmail.com>
Rosen Penev <rosenp@gmail.com> wrote:
> When the WiFi device has no ACPI companion, or the firmware does not
> implement a given rtw89 _DSM function, rtw89_acpi_evaluate_dsm() calls
> acpi_evaluate_dsm() anyway. ACPI core then warns on every probe:
>
> ACPI: \: failed to evaluate _DSM e8c3a8d2-694b-004f-82bd-fe8607803aa7 rev:0 func:10 (0x1001)
> ACPI: \: failed to evaluate _DSM e8c3a8d2-694b-004f-82bd-fe8607803aa7 rev:0 func:6 (0x1001)
>
> Here the handle is NULL, and acpi_evaluate_object() returns
> AE_BAD_PARAMETER. All callers already treat failure as "no policy
> provided by the platform", so this is only noise.
>
> Use acpi_check_dsm() first. It returns false for a NULL handle and for
> functions that are not advertised, so absent functions fail quietly at
> debug level, as rtw89_acpi_evaluate_method() already does.
The acpi_check_dsm() is to evaluate func 0 before actually accessing func.
I'm not sure if all platforms will implement func 0. Do you know that?
>
> Seen on an RTL8852BE in a desktop PCIe slot.
>
> Fixes: e897b0bef38a ("wifi: rtw89: introduce realtek ACPI DSM method")
Does it need a Fixes? As I see, this is not a bug.
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
next prev parent reply other threads:[~2026-11-02 3:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-01 22:25 Rosen Penev
2026-11-02 3:28 ` Ping-Ke Shih [this message]
2026-11-02 4:09 ` Rosen Penev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebd3c83183464c3e9c218337a568b59a@realtek.com \
--to=pkshih@realtek.com \
--cc=kevin_yang@realtek.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®