From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4674C77B6C for ; Thu, 6 Apr 2023 18:34:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240210AbjDFSe1 (ORCPT ); Thu, 6 Apr 2023 14:34:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240179AbjDFSeZ (ORCPT ); Thu, 6 Apr 2023 14:34:25 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CD9B170E for ; Thu, 6 Apr 2023 11:34:24 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id qb20so3599213ejc.6 for ; Thu, 06 Apr 2023 11:34:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680806062; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=I6maTLOz1QZeOD8kPuR409/ooOQkEc/E5FwVXHO67l0=; b=l0Pbm83fXbEeLt3Hv8z6jPi+3/3lgepiEz69Mdk8tEwL1d5P/Y7l9XzorVvTfDtGoN zVkllXsGeXQgZurXgUnmsDHiw/X3RYAx1aA5r4fn2dPePn64dyA+1/yRMu32Ap06R9rM HmOAyMouPBsZwMPzPuE6LuG0nGJaS6ppe2WBgth9p3yVoHxLPYnQ5dIXaKZI+A7Zl5z5 ndMYes4iP3GP0CmNS2zc31iwzWRT5B9dbfGKQSFkuDG37HkMzs1DwAAl0ur/PcTHxf4z rjUZX99bL+OlAl7JDAN3izSykxyn0mZ+PQKFl474dHJjzYhpEwFPFe6co0CuGew2HZpG D3DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680806062; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=I6maTLOz1QZeOD8kPuR409/ooOQkEc/E5FwVXHO67l0=; b=Gw8LNWopZUpoJfbg2m3XaqIaIC7ViLNnzHJjWrjoG0HuejTvgtjlWiRlBo2SiIaTuJ aO3H6Iozh1upkaWeRGhIwC8vVImbq7gcSxHBrGk8oNUuzeL8pCHg+4/rXPC/1g0/efbs GS3MUNdPgte4TLZ38FD04wXplmjGxJ7UFOZXBJ8Wl/sN3l5W331fensmqoau5BDUuahg Tv5hWttSwER66oYg0gCGYAvIwaTIkjG+xSKm6CBTpAIzbcGsYCxAnO5KiLGKL3wrJDQ6 0akq9bUNSV3zxRV+T+5quotRJi6uzTUwIb2NaZ4iM/bXePJgRIOIUyfX9zheoieWw+gL UReQ== X-Gm-Message-State: AAQBX9fSVrXN+zCozDF+lnSyuNaered6GfTQ+r7JT5A1p4DlX8LdDF2Q R4YeCnpyQkUI69sTrBaUS2i89A== X-Google-Smtp-Source: AKy350ZATMlvQLNv3pv0+sJEod1kxGFxxxykAYiMouoefxH0TIUxCu3Ht7TM837ADnjoXY8e2r42nw== X-Received: by 2002:a17:906:f296:b0:933:6ae6:374d with SMTP id gu22-20020a170906f29600b009336ae6374dmr6331734ejb.73.1680806062616; Thu, 06 Apr 2023 11:34:22 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:49e6:bb8c:a05b:c4ed? ([2a02:810d:15c0:828:49e6:bb8c:a05b:c4ed]) by smtp.gmail.com with ESMTPSA id rk8-20020a170907214800b0091ec885e016sm1127339ejb.54.2023.04.06.11.34.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Apr 2023 11:34:22 -0700 (PDT) Message-ID: Date: Thu, 6 Apr 2023 20:34:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v1 1/3] dt-bindings: PCI: brcmstb: Add two optional props Content-Language: en-US To: Jim Quinlan , linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Phil Elwell , bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com Cc: Florian Fainelli , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Rob Herring , Krzysztof Kozlowski , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list References: <20230406124625.41325-1-jim2101024@gmail.com> <20230406124625.41325-2-jim2101024@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20230406124625.41325-2-jim2101024@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/04/2023 14:46, Jim Quinlan wrote: > Regarding "brcm,enable-l1ss": > > The Broadcom STB/CM PCIe HW -- which is also used by RPi SOCs -- requires > the driver probe to configure one of three clkreq# modes: > > (a) clkreq# driven by the RC > (b) clkreq# driven by the EP for ASPM L0s, L1 > (c) bidirectional clkreq#, as used for L1 Substates (L1SS). > > The HW can tell the difference between (a) and (b), but does not know > when to configure (c). Further, the HW will cause a CPU abort on boot if > guesses wrong regarding the need for (c). So we introduce the boolean > "brcm,enable-l1ss" property to indicate that (c) is desired. This > property is already present in the Raspian version of Linux, but the > driver implementaion that will follow adds more details and discerns > between (a) and (b). > > Regarding "brcm,completion-timeout-msecs" > > Our HW will cause a CPU abort if the L1SS exit time is longer than the > completion abort timeout. We've been asked to make this configurable, so > we are introducing "brcm,completion-abort-msecs". > > Signed-off-by: Jim Quinlan > --- > .../devicetree/bindings/pci/brcm,stb-pcie.yaml | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > index 7e15aae7d69e..ef4ccc05b258 100644 > --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > @@ -64,6 +64,18 @@ properties: > > aspm-no-l0s: true > > + brcm,enable-l1ss: > + description: Indicates that the downstream device is L1SS > + capable and L1SS is desired, e.g. by setting > + CONFIG_PCIEASPM_POWER_SUPERSAVE=y. Note that CLKREQ# How does CONFIG_PCIEASPM_POWER_SUPERSAVE apply to *BSD? > + assertion to clock active must be within 400ns. > + type: boolean > + > + brcm,completion-timeout-msecs: Use standard unit suffixes. > + description: Number of msecs before completion timeout > + abort occurs. > + $ref: /schemas/types.yaml#/definitions/uint32 > + > brcm,scb-sizes: > description: u64 giving the 64bit PCIe memory > viewport size of a memory controller. There may be up to Best regards, Krzysztof