From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754041AbdBGLjR (ORCPT ); Tue, 7 Feb 2017 06:39:17 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:46399 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753836AbdBGLjQ (ORCPT ); Tue, 7 Feb 2017 06:39:16 -0500 Subject: Re: [PATCH] scsi: aacraid: rcode is unsigned, so can never be less than zero To: Dan Carpenter References: <20170207112738.18486-1-colin.king@canonical.com> <20170207113717.GB11154@mwanda> Cc: Adaptec OEM Raid Solutions , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org From: Colin Ian King Message-ID: Date: Tue, 7 Feb 2017 11:37:43 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170207113717.GB11154@mwanda> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/02/17 11:37, Dan Carpenter wrote: > On Tue, Feb 07, 2017 at 11:27:38AM +0000, Colin King wrote: >> From: Colin Ian King >> >> The check on rcode >= 0 is always true because rcode is unsigned >> and can never be less than zero. Remove the redundant check. >> >> Signed-off-by: Colin Ian King >> --- >> drivers/scsi/aacraid/aachba.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c >> index 3b5ddf4..ddfd726 100644 >> --- a/drivers/scsi/aacraid/aachba.c >> +++ b/drivers/scsi/aacraid/aachba.c >> @@ -1848,7 +1848,7 @@ int aac_report_phys_luns(struct aac_dev *dev, struct fib *fibptr, int rescan) >> FsaNormal, 1, 1, NULL, NULL); >> >> /* analyse data */ >> - if (rcode >= 0 && phys_luns->resp_flag == 2) { > > The original code is buggy. rcode should be an int. Thanks for spotting that. Oops. > > regards, > dan carpenter >