From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83CF6312835; Wed, 24 Dec 2025 10:49:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766573349; cv=none; b=XgZSZU4SQTrvELkrF3I+fciVTnj69udPxJ9FALvwniGFuKFtUcpRgKCfsc9rdFvPvTVItx/O0OUTLSgkS6rnfg6GTjcqzJC8bgeNMn9zdyWUJ96AUH98rMncDRwaXVKX7eoSeEFhUUufy/DAdB5ZWlo6ZTnKO76LRTwH7inCAws= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766573349; c=relaxed/simple; bh=30rWyhR3g+njjauitHECF76nXOA5mVZ7Ldm2bsJV4jc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MDZ5hQ1eZzJZy6v7qqr3/CIiv5NPGwnFrLJyIoXC4TjANaVhCAmkFC3+5pxMDdySOqqcXYbZwd+0+u4Q88FX/fsB2vkZIQyF9wGwhfVa+y/46cDvb5ZI1CO0PuxrvG+cYG5Pyqo0zeM5s8CswJfooKUaVbPVaB2yCOPExZknMGA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=DoPmfkjb; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="DoPmfkjb" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=NDds5hTl/d+XsDS9Go+jMEl/YXTjhWmZPRyIAvZT4Bo=; b=DoPmfkjb2+IifA/+gKJ2aACZyw nXHlxoD7y3RF3+xYNU4CHn5nP2NNuq7gUlQzkTh7cWL+SmcYH7rVJH2nxrwFzf00n4VR6xbCnIl0L EJbpATXtDgScDG3+39Bhyq29JTtiqecv9jVGGeKKpP6d/DQX80LJjxUZlHLvYpaVbnDc=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1vYMQP-000P9G-Fg; Wed, 24 Dec 2025 11:49:01 +0100 Date: Wed, 24 Dec 2025 11:49:01 +0100 From: Andrew Lunn To: "illusion.wang" Cc: dimon.zhao@nebula-matrix.com, alvin.wang@nebula-matrix.com, sam.chen@nebula-matrix.com, netdev@vger.kernel.org, open list Subject: Re: [PATCH v1 net-next 07/15] net/nebula-matrix: add vsi, queue, adminq resource definitions and implementation Message-ID: References: <20251223035113.31122-1-illusion.wang@nebula-matrix.com> <20251223035113.31122-8-illusion.wang@nebula-matrix.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251223035113.31122-8-illusion.wang@nebula-matrix.com> > +++ b/drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_hw_leonis/base/nbl_datapath.h > @@ -0,0 +1,14 @@ > +/* SPDX-License-Identifier: GPL-2.0*/ > +/* > + * Copyright (c) 2025 Nebula Matrix Limited. > + * Author: > + */ > +// Code generated by interstellar. DO NOT EDIT. > +// Compatible with leonis RTL tag 0710 That patch is way too big, it is unlikely anybody will review it for you. One thing which will help is put all the machine generated headers in a separate patch. Make sure the commit message makes it clear this is machine generated. Human reviewers will then only take a quick look, but mostly ignore it. That helps make the real code which needs human review stand out. Andrew