From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51F612942A for ; Tue, 26 Nov 2024 06:48:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732603700; cv=none; b=fThlxcxRvyUJCDkI9Uu/7gxIQdeNg/HAtX0jCveg3OHV8aFLEu3XioRTVhAWm7xCIfs/nKFR0WCzEmXBhjYtbvV1BVPl8V3o6hHu2XPsx+QMg8xlE1S5JSjfY6wNCXGJdoEWQO+N4VZ6mizFlmadSmOoT1plq6TTaPI8h1XOTbw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732603700; c=relaxed/simple; bh=Ctk1dgnhm49NbtYzSV3G1D1fKfFhlTi7fC9eDW2ePhU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gN29ib+Lkk4hZPV4XH/QxUIDZGrsUtKMUW0NHzCzoizeVkNUUVVUKduvWXEz9r7SoBW9rdLKPi9imLxGctoRq0K9Wh/ejodPNJiD27Nxm2NGafEwHIcZlDRAf4H0rIB5i6uk1R93SiBdk+lt3AUlCAdyfJ3vHYRF11rh85IV7mc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1tFpMn-0000X8-Hw; Tue, 26 Nov 2024 07:48:09 +0100 Message-ID: Date: Tue, 26 Nov 2024 07:48:06 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] crypto: caam - use JobR's space to access page 0 regs To: Gaurav Jain , Horia Geanta , Pankaj Gupta , Herbert Xu , "David S . Miller" , Silvano Di Ninno , Varun Sethi , Meenakshi Aggarwal , Sahil Malhotra , Nikolaus Voss Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Pengutronix Kernel Team References: <20241126064607.456633-1-gaurav.jain@nxp.com> Content-Language: en-US From: Ahmad Fatoum In-Reply-To: <20241126064607.456633-1-gaurav.jain@nxp.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:900:1d::77 X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org On 26.11.24 07:46, Gaurav Jain wrote: > On iMX8DXL/QM/QXP(SECO) & iMX8ULP(ELE) SoCs, access to controller > region(CAAM page 0) is not permitted from non secure world. > use JobR's register space to access page 0 registers. > > Fixes: 6a83830f649a ("crypto: caam - warn if blob_gen key is insecure") > Signed-off-by: Gaurav Jain Reviewed-by: Ahmad Fatoum > --- > > changes in v2 > Updated commit message with SoCs details on which CAAM page 0 is not > accessible from non secure world. > > drivers/crypto/caam/blob_gen.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/crypto/caam/blob_gen.c b/drivers/crypto/caam/blob_gen.c > index 87781c1534ee..079a22cc9f02 100644 > --- a/drivers/crypto/caam/blob_gen.c > +++ b/drivers/crypto/caam/blob_gen.c > @@ -2,6 +2,7 @@ > /* > * Copyright (C) 2015 Pengutronix, Steffen Trumtrar > * Copyright (C) 2021 Pengutronix, Ahmad Fatoum > + * Copyright 2024 NXP > */ > > #define pr_fmt(fmt) "caam blob_gen: " fmt > @@ -104,7 +105,7 @@ int caam_process_blob(struct caam_blob_priv *priv, > } > > ctrlpriv = dev_get_drvdata(jrdev->parent); > - moo = FIELD_GET(CSTA_MOO, rd_reg32(&ctrlpriv->ctrl->perfmon.status)); > + moo = FIELD_GET(CSTA_MOO, rd_reg32(&ctrlpriv->jr[0]->perfmon.status)); > if (moo != CSTA_MOO_SECURE && moo != CSTA_MOO_TRUSTED) > dev_warn(jrdev, > "using insecure test key, enable HAB to use unique device key!\n"); -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |