From: Giulio Benetti <giulio.benetti@micronovasrl.com>
To: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: David Airlie <airlied@linux.ie>, Chen-Yu Tsai <wens@csie.org>,
linux-arm-kernel@lists.infradead.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] drm/sun4i: add lvds mode_valid function
Date: Fri, 2 Mar 2018 12:42:14 +0100 [thread overview]
Message-ID: <ebe7cfe5-e731-10cf-17cd-fe79bee0fdc4@micronovasrl.com> (raw)
In-Reply-To: <20180301095721.4iga7dcgg566j44m@flea>
Hi,
Il 01/03/2018 10:57, Maxime Ripard ha scritto:
> On Wed, Feb 28, 2018 at 06:53:52PM +0100, Giulio Benetti wrote:
>> static struct drm_connector_helper_funcs sun4i_lvds_con_helper_funcs = {
>> .get_modes = sun4i_lvds_get_modes,
>> + .mode_valid = sun4i_lvds_mode_valid,
>> };
>
> This should be on the encoder, not the connector.
I've seen it is bound to connector in rgb and to encoder in hdmi.
Is it correct rgb mode_valid under connector funcs?
Otherwise I send a patch also for that one.
>
> Maxime
>
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
--
Giulio Benetti
CTO
MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale € 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642
next prev parent reply other threads:[~2018-03-02 11:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 17:53 [PATCH 1/2] drm/sun4i: increase lvds dclk max divisor Giulio Benetti
2018-02-28 17:53 ` [PATCH 2/2] drm/sun4i: add lvds mode_valid function Giulio Benetti
2018-03-01 9:57 ` Maxime Ripard
2018-03-02 11:42 ` Giulio Benetti [this message]
2018-03-02 14:37 ` Maxime Ripard
2018-03-02 16:50 ` Giulio Benetti
2018-03-01 9:56 ` [PATCH 1/2] drm/sun4i: increase lvds dclk max divisor Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebe7cfe5-e731-10cf-17cd-fe79bee0fdc4@micronovasrl.com \
--to=giulio.benetti@micronovasrl.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@bootlin.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®