From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7D2B39A046 for ; Wed, 4 Mar 2026 09:34:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772616885; cv=none; b=SyULxJ3TBj3EN/2pX4Z8nJyMe6NomiHBBm5PC7t27xZWcDE80tBxonNhAO8nqw2OmnzYCXcwlxhc8wZs64x+PboSHGDmqPrVmjcikLdWigVRw5xSX/BgGvpaIH57ai6YTmxR0radiBFGJ7oeVyyONE/4AiD0Cp8j5C51C+feNKA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772616885; c=relaxed/simple; bh=XWtG4w+RB2jIlE8XCXYlCTclLv1DMkaQyVrjOrWsDSM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HO8K5giy2UuJqr6sorbrKxWnEArOOH3Gv8LzzXPkzlCl7QSXiglL+CvUeIJZSMocFq4Y6U6NNukppgW6l3ZZ0BYhJWyhJBNs6Qa1Ac5nLfi8V5poGSl/YHL65ShiZrv3hpjVHNByulru5H/BVIT9oxR88EWizJBP4SAmQfJCMcA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=eKEnwxk0; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=aarkVNpC; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="eKEnwxk0"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="aarkVNpC" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6245SRB92861146 for ; Wed, 4 Mar 2026 09:34:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= eL/MxpDDt/5/2ALudUSxO1nN1iy4vdaNTzKBdYqEsSk=; b=eKEnwxk08ZSuuIb5 kLnhOzDXKxPW3zLqbJ5i4X54fIBV8ekw6WA+QDZnIeum2m6HgZKdTzX4cPzMLchr 5neNVC9YrL0B3EGsnHNgfXT05VeYt225ETdM/AVXVP7//SkXB+1NzN8TeDk5RuFC 27wO/Anxs1VGEBZa4acXnCLLVSO0dORMonWjSO3FqxuXk8a43Wx2H73d1BKdA4cE cxQQpibSkWaWAkJiWBDKtr7fW54WyW1SeY84/O6qB+m+jZ3tI0VcQa8JbqlDPGP8 LB1IrM9dcfY+1udtjPx+AYfb3o7TgoA/Gyl6T/sV5VyaqTfN5LbziEYbwNJlrEhZ gV/dBg== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cp2c9kcu7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 04 Mar 2026 09:34:42 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-35842aa350fso30123359a91.0 for ; Wed, 04 Mar 2026 01:34:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772616882; x=1773221682; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=eL/MxpDDt/5/2ALudUSxO1nN1iy4vdaNTzKBdYqEsSk=; b=aarkVNpC7wmODEKE9NZ7FhWY6VkMI3EC2Oj2f2ApWw7rcwQAr9z47F+lX2Zu/h/1Xk KrB9SzdwsjNUyLZuW+X9r4oLsTYFo1fIXorkjtcLnRd2KfYEM9RLucn6Bd17mldHOwWr 47dCAwN5uh7h1T7rm7Y2hhIoxG8+jxa9NgrkxPeezRHEcjeC2J0Vo7bBg7gQXRPjZrm+ Il9XjVgGrBn5kD/03pujANKp0JKXdCmpAXUsbkpkOjeW6tq6KKJ3jn+z3Va/nvyHFS1m Y9N/65G7CiJLzDhJ4ym9oB9TicoIBe2kDwYgS99+9qBjPvTUDtQzVyOpn0wHPDHbqNG4 ixPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772616882; x=1773221682; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eL/MxpDDt/5/2ALudUSxO1nN1iy4vdaNTzKBdYqEsSk=; b=NAhdw6aBIy6Ioksadyp5qfBmK6HGtjzU8dD3r3Z0gp1BBmlQGrWv8DEkIQySHfiLCG YaBlBXi1b6g+6W4Dq18UKD9m9oeEW3yLyL6NPDq5gKDUjZUg7ARtk63ZMca+Lpfq6A43 +It2NADrhHjQ8J56ig79W8XVUgIugdpn+UbRPqRpGw15S/QmDdG4g03/+5ciGrS+gy5l N38F+9b3jzaT5E07BePZ+qaLcABqntddyo+fJHfjx/2EzLIaPuXBGae7aHoGvvblCio6 iGDx1kQdV6CXWs3f0uwpZUmlAovQAngYWGWrOal8Ui7qegEioIQZ1K6CgO5XPc1AN9uw m6pA== X-Forwarded-Encrypted: i=1; AJvYcCWC4J5vgyRB4+oiWAmHoWd9EQHWF6lB2CQjnlLEUFajwmMSklLhzm4DaAgSZxHze8wSE9u05my5sm3HXUU=@vger.kernel.org X-Gm-Message-State: AOJu0Ywj9o7BaYlz0Cw9Q/v90TJ+q2GzsdtbI6LefmrRMGD7Y7x2FslV 8k0LTijRFOIpACh8SaxlgG/rBjrHvCI1uMjaTsyGwAvCFDOt3t3SoiwxUW0pU8Horl7kDfQQ6Pw d/cIalHFovJAXq5815U0XYo35IcAyAJdIPPGFnxONU3bjouVPazXwgjYxBUBiulBVNJQ= X-Gm-Gg: ATEYQzwHelYNRvaGJw/6eACSUpLovVTwC4Ly5YhUx0rbgJQSzPy+I8b3MfZixTTr74V 7PhtluuL38G6eXp+4DWckD+/dAh+/wSuNI2ieN3f2Iz1rA/TYdseEB/fH5vBg3Ca+SJPuX2Wibn rlw4kkIg+B9MJi/B95wwIFXuVFtU50q1jEmHaHGGlrULBh12/yNQtfkExaEVDif6cVCfwhYZKSi d/rKyIqjg7OrxJkGhb3rj5Ywp/6AtPzU+MlWbIm0k+plv/HfmN79HLukrrOPAFvtxL754BK557Z 3G/HVYWVcnAhd7vncZ1dqRduQsJiUs2iEKNmMje6H9Nq5z8nChzHDCilO/8hw63Fnkx8c90H199 QXNd1+5zABUs7xGK4STXeynY5LcwU7gmvK+A3AItH6n5LlYPBvp6N7oLu X-Received: by 2002:a17:90b:5784:b0:359:8cad:bcdc with SMTP id 98e67ed59e1d1-359a69d6372mr1471640a91.10.1772616881621; Wed, 04 Mar 2026 01:34:41 -0800 (PST) X-Received: by 2002:a17:90b:5784:b0:359:8cad:bcdc with SMTP id 98e67ed59e1d1-359a69d6372mr1471607a91.10.1772616881094; Wed, 04 Mar 2026 01:34:41 -0800 (PST) Received: from [10.219.57.109] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-359a8d65b31sm500720a91.0.2026.03.04.01.34.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Mar 2026 01:34:40 -0800 (PST) Message-ID: Date: Wed, 4 Mar 2026 15:04:30 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 2/3] of: factor arguments passed to of_map_id() into a struct To: Dmitry Baryshkov Cc: Nipun Gupta , Nikhil Agarwal , Joerg Roedel , Will Deacon , Robin Murphy , Marc Zyngier , Lorenzo Pieralisi , Thomas Gleixner , Rob Herring , Saravana Kannan , Richard Zhu , Lucas Stach , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Bjorn Helgaas , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Konrad Dybcio , Bjorn Andersson , Conor Dooley , Krzysztof Kozlowski , Prakash Gupta , Vikash Garodia , linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, imx@lists.linux.dev, xen-devel@lists.xenproject.org, linux-arm-msm@vger.kernel.org, Charan Teja Kalla References: <20260301-parse_iommu_cells-v9-0-4d1bceecc5e1@oss.qualcomm.com> <20260301-parse_iommu_cells-v9-2-4d1bceecc5e1@oss.qualcomm.com> Content-Language: en-US From: Vijayanand Jitta In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA0MDA3MiBTYWx0ZWRfX8kY7U9PG94Tq ME4KW78alyVKRqLF7ZRrN4TKMu96cIGdG4Kstc72odZcXL+rJQVmGUtFg7S6bOcwMgJYpPIOuVn Hu72kWknnnoTc0qYwhQVGQD9tEiOqg0BUvWlcl6jxqgC46m+Ev9O7fhLmowby1a+jYvwzIZcSmW ykbAYaM5jRnZfVkZojpFazZDoXPioOwiaL/3bxTJlO8UJswzuN54oGO5aqNvMRyPJCsMLLYXQb+ aMcSP7oFDJgd+tYH/2qxC6J8eX3OBPxu1rXy91ockKv0O+N7E8IwOdDGiVHK2f78yQUgN5NF/lZ tAuzjJJLW85yBzPWdNYajlQ81v07+PzCBZKjVJ1DgbpIEvJuukNq7/eqoT9CqEkeiAP1lWri89k 9B/JK72aZD9ySGRm6+Rg3nzXVTry68m7wIvdIq8bhYYiBrftAqZiIPnq1dgSCRzDp4ljliZuAYI 4z/VkGVQ0dT+mw3SBbw== X-Proofpoint-ORIG-GUID: U5LK-_d9K4xFS3jIUKKZFf0ZZ1Zbbwzg X-Proofpoint-GUID: U5LK-_d9K4xFS3jIUKKZFf0ZZ1Zbbwzg X-Authority-Analysis: v=2.4 cv=EefFgfmC c=1 sm=1 tr=0 ts=69a7fcb2 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=VwQbUJbxAAAA:8 a=kVzFkbBwBCoyR44kgfkA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-04_05,2026-03-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 bulkscore=0 adultscore=0 impostorscore=0 phishscore=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603040072 On 3/1/2026 4:29 PM, Dmitry Baryshkov wrote: > On Sun, Mar 01, 2026 at 02:04:20PM +0530, Vijayanand Jitta wrote: >> From: Charan Teja Kalla >> >> Change of_map_id() to take a pointer to struct of_phandle_args >> instead of passing target device node and translated IDs separately. >> Update all callers accordingly. >> >> Subsequent patch will make use of the args_count field in >> struct of_phandle_args. >> >> Suggested-by: Rob Herring (Arm) >> Signed-off-by: Charan Teja Kalla >> Signed-off-by: Vijayanand Jitta >> --- >> drivers/iommu/of_iommu.c | 2 +- >> drivers/of/base.c | 37 +++++++++++++++++------------------ >> drivers/pci/controller/dwc/pci-imx6.c | 8 +++++++- >> drivers/pci/controller/pcie-apple.c | 4 +++- >> drivers/xen/grant-dma-ops.c | 2 +- >> include/linux/of.h | 21 +++++++++++++------- >> 6 files changed, 44 insertions(+), 30 deletions(-) >> >> diff --git a/drivers/pci/controller/pcie-apple.c b/drivers/pci/controller/pcie-apple.c >> index a0937b7b3c4d..e1d4b37d200d 100644 >> --- a/drivers/pci/controller/pcie-apple.c >> +++ b/drivers/pci/controller/pcie-apple.c >> @@ -755,6 +755,7 @@ static int apple_pcie_enable_device(struct pci_host_bridge *bridge, struct pci_d >> { >> u32 sid, rid = pci_dev_id(pdev); >> struct apple_pcie_port *port; >> + struct of_phandle_args iommu_spec = { .args_count = 1 }; > > Hmm, I didn't notice this. Parsing functions are expected to ignore > of_phandle_args before the parsing. So passing .args_count = 1 is > strange. > You're right, This is not required. I'll remove these initializations in next series. Thanks, Vijay >> int idx, err; >> >> port = apple_pcie_get_port(pdev); >