From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757567AbdAJXer (ORCPT ); Tue, 10 Jan 2017 18:34:47 -0500 Received: from ale.deltatee.com ([207.54.116.67]:48514 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751164AbdAJXeq (ORCPT ); Tue, 10 Jan 2017 18:34:46 -0500 To: Joe Perches , Jon Mason References: <1483407036-20697-1-git-send-email-logang@deltatee.com> <20170110215527.GD13381@kudzu.us> <1484089612.12006.11.camel@perches.com> Cc: Xiangliang Yu , Dave Jiang , Allen Hubbe , Greg Kroah-Hartman , linux-ntb@googlegroups.com, linux-kernel From: Logan Gunthorpe Message-ID: Date: Tue, 10 Jan 2017 16:34:41 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.5.1 MIME-Version: 1.0 In-Reply-To: <1484089612.12006.11.camel@perches.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.111 X-SA-Exim-Rcpt-To: linux-kernel@vger.kernel.org, linux-ntb@googlegroups.com, gregkh@linuxfoundation.org, Allen.Hubbe@emc.com, dave.jiang@intel.com, Xiangliang.Yu@amd.com, jdmason@kudzu.us, joe@perches.com X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH 0/2] Style fixes: open code obfuscating macros X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/01/17 04:06 PM, Joe Perches wrote: > It might also be better to add and use YA > logging macro like ndev_dbg > > #define ndev_dvg(ndev, fmt, ...) \ > dev_dbg(&(ndev)->ntb.pdev->dev, fmt, ##__VA_ARGS__) > > so that the new temporaries that are used just > for debugging are not required. > I feel like that's going in the exact opposite direction from what Greg was looking for... I think the point is to hide less of where the device is coming from, not to create a new and different macro that hides things in a different way. Or, more likely, I _think_ Greg would suggest that this is showing that the driver model isn't really being used properly. Perhaps, we should be printing against the ntb struct device instead of the pci device so there is no dereferencing. Logan