From: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Rob Clark <robin.clark@oss.qualcomm.com>,
Dmitry Baryshkov <lumag@kernel.org>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Jessica Zhang <jesszhan0024@gmail.com>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Abhinav Kumar <quic_abhinavk@quicinc.com>
Subject: Re: [PATCH v5 10/15] drm/msm/dp: allow dp_ctrl stream APIs to use any panel passed to it
Date: Tue, 2 Jun 2026 16:03:55 +0800 [thread overview]
Message-ID: <ebf6693a-46ed-4a8b-b190-da8663d668a1@oss.qualcomm.com> (raw)
In-Reply-To: <mar2smjimo3uoucxctofmjd25vsfun66m3l6i4prnyvo3z7dzg@7e565usiluvq>
On 5/28/2026 11:25 PM, Dmitry Baryshkov wrote:
> On Thu, May 28, 2026 at 06:40:31PM +0800, Yongxing Mou wrote:
>> From: Abhinav Kumar <quic_abhinavk@quicinc.com>
>>
>> With MST, multiple sinks share a single DP controller, so a cached
>> panel in msm_dp_ctrl_private can no longer represent the per-stream
>> sink. Drop the cache and pass panel explicitly to all stream-related
>> dp_ctrl APIs.
>>
>> Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
>> Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
>> ---
>> drivers/gpu/drm/msm/dp/dp_ctrl.c | 208 ++++++++++++++++++++----------------
>> drivers/gpu/drm/msm/dp/dp_ctrl.h | 28 +++--
>> drivers/gpu/drm/msm/dp/dp_display.c | 24 ++---
>> 3 files changed, 146 insertions(+), 114 deletions(-)
>>
>> @@ -389,7 +389,7 @@ void msm_dp_ctrl_push_idle(struct msm_dp_ctrl *msm_dp_ctrl)
>> }
>>
>> static void msm_dp_ctrl_config_ctrl_streams(struct msm_dp_ctrl_private *ctrl,
>> - struct msm_dp_panel *msm_dp_panel)
>> + struct msm_dp_panel *panel)
>
> Please don't mix sensible changes with the renames / cleanups.
>
Got it, thanks, will fix it next patch.
>> {
>> u32 config = 0, tbd;
>>
>
next prev parent reply other threads:[~2026-06-02 8:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-28 10:40 [PATCH v5 00/15] drm/msm/dp: Prerequisite cleanup for upcoming MST support Yongxing Mou
2026-05-28 10:40 ` [PATCH v5 01/15] drm/msm/dp: remove cached drm_edid from panel Yongxing Mou
2026-05-28 15:19 ` Dmitry Baryshkov
2026-05-28 10:40 ` [PATCH v5 02/15] drm/msm/dp: drop deprecated .mode_set() and use .atomic_enable Yongxing Mou
2026-05-28 10:40 ` [PATCH v5 03/15] drm/msm/dp: move mode setup into msm_dp_panel_init_panel_info() Yongxing Mou
2026-05-29 12:11 ` Dmitry Baryshkov
2026-05-28 10:40 ` [PATCH v5 04/15] drm/msm/dp: split msm_dp_ctrl_config_ctrl() into link parts and stream parts Yongxing Mou
2026-05-28 15:22 ` Dmitry Baryshkov
2026-06-02 8:03 ` Yongxing Mou
2026-05-28 10:40 ` [PATCH v5 05/15] drm/msm/dp: extract MISC1_MISC0 configuration into a separate function Yongxing Mou
2026-05-28 10:40 ` [PATCH v5 06/15] drm/msm/dp: split link setup from source params Yongxing Mou
2026-05-28 10:40 ` [PATCH v5 07/15] drm/msm/dp: move the pixel clock control to its own API Yongxing Mou
2026-05-28 10:40 ` [PATCH v5 08/15] drm/msm/dp: break up dp_display_enable into two parts Yongxing Mou
2026-05-28 10:40 ` [PATCH v5 09/15] drm/msm/dp: re-arrange dp_display_disable() into functional parts Yongxing Mou
2026-05-28 10:40 ` [PATCH v5 10/15] drm/msm/dp: allow dp_ctrl stream APIs to use any panel passed to it Yongxing Mou
2026-05-28 15:25 ` Dmitry Baryshkov
2026-06-02 8:03 ` Yongxing Mou [this message]
2026-05-28 10:40 ` [PATCH v5 11/15] drm/msm/dp: split dp_ctrl_off() into stream and link parts Yongxing Mou
2026-05-28 10:40 ` [PATCH v5 12/15] drm/msm/dp: simplify link and clock disable sequence Yongxing Mou
2026-05-28 10:40 ` [PATCH v5 13/15] drm/msm/dp: make bridge helpers use dp_display to allow re-use Yongxing Mou
2026-05-28 10:40 ` [PATCH v5 14/15] drm/msm/dp: separate dp_display_prepare() into its own API Yongxing Mou
2026-05-28 10:40 ` [PATCH v5 15/15] drm/msm/dp: pass panel to display enable/disable helpers Yongxing Mou
2026-05-28 15:28 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebf6693a-46ed-4a8b-b190-da8663d668a1@oss.qualcomm.com \
--to=yongxing.mou@oss.qualcomm.com \
--cc=abhinav.kumar@linux.dev \
--cc=airlied@gmail.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jesszhan0024@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=quic_abhinavk@quicinc.com \
--cc=robin.clark@oss.qualcomm.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®