From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8291C433F5 for ; Mon, 10 Oct 2022 13:26:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229595AbiJJN0Y (ORCPT ); Mon, 10 Oct 2022 09:26:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229475AbiJJN0V (ORCPT ); Mon, 10 Oct 2022 09:26:21 -0400 Received: from mail-qt1-x829.google.com (mail-qt1-x829.google.com [IPv6:2607:f8b0:4864:20::829]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2EE95C9C9 for ; Mon, 10 Oct 2022 06:26:19 -0700 (PDT) Received: by mail-qt1-x829.google.com with SMTP id g11so1796067qts.1 for ; Mon, 10 Oct 2022 06:26:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bECZwqwp/UMUC2akq1A/CRAdUXQ8y+lySs9e81GJPvo=; b=wFLua3qNoxv1oK422WS3Z0arUW43Mk/9YaiEu598KyMxUreaiHVlStJNCYindCI14l 0uih9J2kqd84xdRN2futlUGJ509Lgr0RHsCZxptFQ/CEi0EbJ4DYxtTtJ7nfsRAi5FH5 yQa+s18iY7BYG1txW5XasmdW/pnqnle4EKdUHckr68cK+WWlCNEbifbF/BwNLoXjjpWy 7hdOXNAEa9cf6nqCAQWPPR6TkkyB4J+L2ZAsE9uEpGVN8tSImHMblrh+LJR1vsQv/Nys XHaWRC/3q0osdP33TtZGwBWlxyY8/rXeMolzTBml+Msj6rDrgR15IvztiGkkSOaivGWy Le5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bECZwqwp/UMUC2akq1A/CRAdUXQ8y+lySs9e81GJPvo=; b=EMWfOmLTUz4cz/pzxk98xdM20VVOCJZ0mc/7fNSTb7mD3zbTTc8QVpDyuhko1qCeCL W9N7r2bq/hVCBxcehWj2fpZpGe0VYKwSLyNDo8HvL8wE5lZwBdFc/j56tjUKRqnrJz2V LoyjiJflUyPYM9ybU+LWGpP11yvO80vF+r+BYuRHirvWgkjSKY/pO3BXTUCiUjDB8+hS chVbTGMbMGnQplUQS9+mtqIGZEJtm/QBJg0Xk7jIMYAojxabJGTj9DX42yDNeodHtvLc 1jUWMQh0IB9+0A4FMqUCEsdobAcdVS1jkgl7YI84mXyMKKu7Jr1wj52ZOpEjUepSsRkl SMDA== X-Gm-Message-State: ACrzQf3R8kuO1AjItuTlx8cUki3K2QWgPyN0D5Mo7ObnxfhQ4tg5y2jg LP+5NKI8EWgOEYi8xEm5dkrQTw== X-Google-Smtp-Source: AMsMyM5Y+JwiozPaIKFDE8rg9TBm8NsqgNP92weuetrqvm8DbETgSFdxRpjy0dqfKP9ATq6rHESYnw== X-Received: by 2002:ac8:7f4b:0:b0:35c:bfa2:8bd2 with SMTP id g11-20020ac87f4b000000b0035cbfa28bd2mr14587635qtk.644.1665408378940; Mon, 10 Oct 2022 06:26:18 -0700 (PDT) Received: from [192.168.1.57] (cpe-72-225-192-120.nyc.res.rr.com. [72.225.192.120]) by smtp.gmail.com with ESMTPSA id i14-20020a05620a248e00b006bba46e5eeasm10660953qkn.37.2022.10.10.06.26.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Oct 2022 06:26:17 -0700 (PDT) Message-ID: Date: Mon, 10 Oct 2022 09:24:05 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH] arm64: dts: fix drive strength macros as per FSD HW UM To: Padmanabhan Rajanbabu , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, alim.akhtar@samsung.com, chanho61.park@samsung.com, linus.walleij@linaro.org, pankaj.dubey@samsung.com Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org References: <20221010120438.80680-1-p.rajanbabu@samsung.com> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <20221010120438.80680-1-p.rajanbabu@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/10/2022 08:04, Padmanabhan Rajanbabu wrote: > In FSD pinctrl implementation, the pinctrl driver is using drive strength > MACROs, which are deviating from the actual values specified in FSD HW UM But you are changing DTS, not pinctrl driver. The message is a bit confusing. Add full stop to the sentence. > > This patch adds the right pinctrl drive strength values for FSD SoC. This Do not use "This commit/patch". https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > patch also ensures that the peripherals are using right drive strength > MACROs in-order to function as expected Full stop Which commit introduced it? Add a Fixes tag. > > Signed-off-by: Padmanabhan Rajanbabu > --- > arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi | 34 +++++++++++----------- > arch/arm64/boot/dts/tesla/fsd-pinctrl.h | 6 ++-- > 2 files changed, 20 insertions(+), 20 deletions(-) > > diff --git a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi > index d0abb9aa0e9e..e3852c946352 100644 > --- a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi > +++ b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi > @@ -55,14 +55,14 @@ > samsung,pins = "gpf5-0"; > samsung,pin-function = ; > samsung,pin-pud = ; > - samsung,pin-drv = ; > + samsung,pin-drv = ; Are you sure? The original commit used here value of "2", your change also set value of "2", so what deviates from actual values? You need to describe better the problem. Best regards, Krzysztof