From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 58198183CB0 for ; Fri, 7 Mar 2025 19:35:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741376142; cv=none; b=lh6GLVsiRdf1aqSPAbQBj2McmNga9CvAdMRISoSptRaeCBWwTjl6Ard9h8FIWuO9fJZAxvVrGBAIsG0JZTAFw0hrWCFssejX1K8SvjFqO5XOd4HZBMQfw3WkRSQdvYxiUnN1ry5qEp5tIpoO9xQ1Jnm8vxGPGRk44ktXquD2iik= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741376142; c=relaxed/simple; bh=g7/oFp2KwrBtLUDUYgjRZXPWEC4FqpgEtuOvuaF45Ho=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Hn+fAvELdYld5fVAwJuU5s1uOw2aWpfLHVcSALDp2nlVy4sItsvK3sAL/i4SFHeMGXnazpRSUrtfO1u9THj5TfWo3ZGQVqVfDayMBIhnqbUs7XZMhQe8cImXMpqfdpnhAJG2rJUZaHFKY+mJi0bgQdjkkErc4uGfJzQR7VTbi7w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 901E81477; Fri, 7 Mar 2025 11:35:51 -0800 (PST) Received: from [10.1.197.49] (eglon.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 085E43F66E; Fri, 7 Mar 2025 11:35:35 -0800 (PST) Message-ID: Date: Fri, 7 Mar 2025 19:35:34 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 12/49] x86/resctrl: Move rdt_find_domain() to be visible to arch and fs code To: Reinette Chatre , x86@kernel.org, linux-kernel@vger.kernel.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , H Peter Anvin , Babu Moger , shameerali.kolothum.thodi@huawei.com, D Scott Phillips OS , carl@os.amperecomputing.com, lcherian@marvell.com, bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com, baolin.wang@linux.alibaba.com, Jamie Iles , Xin Hao , peternewman@google.com, dfustini@baylibre.com, amitsinght@marvell.com, David Hildenbrand , Rex Nie , Dave Martin , Koba Ko , Shanker Donthineni , fenghuay@nvidia.com References: <20250228195913.24895-1-james.morse@arm.com> <20250228195913.24895-13-james.morse@arm.com> <2c7ead86-138b-4d26-8524-8109176d791f@intel.com> Content-Language: en-GB From: James Morse In-Reply-To: <2c7ead86-138b-4d26-8524-8109176d791f@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Reinette, On 07/03/2025 04:34, Reinette Chatre wrote: > On 2/28/25 11:58 AM, James Morse wrote: >> rdt_find_domain() finds a domain given a resource and a cache-id. >> This is used by both the architecture code and the filesystem code. >> >> After the filesystem code moves to live in /fs/, this helper is either >> duplicated by all architectures, or needs exposing by the filesystem code. >> >> Add the definition to the global header file. As its now globally visible, > > "definition" -> "declaration"? Ugh, I always get those the wrong way round. >> and has only a handful of callers, swap the 'rdt' for 'resctrl'. Move >> the function to live with its caller in ctrlmondata.c as the filesystem >> code will not have anything corresponding to core.c. > | Reviewed-by: Reinette Chatre Thanks! James