From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162040AbdKQXvz (ORCPT ); Fri, 17 Nov 2017 18:51:55 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:44053 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1162025AbdKQXvr (ORCPT ); Fri, 17 Nov 2017 18:51:47 -0500 X-Google-Smtp-Source: AGs4zMYlsvjQHLQjOZTlT+PESg17HyuRyaQaFIyVCy/Tt+iNYhuq9tUgJwIxboCBI0NKfmU3KaBs1w== Subject: Re: [PATCH] rtc: brcmstb-waketimer: fix error handling in brcmstb_waketmr_probe() To: Alexey Khoroshilov , Brian Norris , Alessandro Zummo , Alexandre Belloni Cc: bcm-kernel-feedback-list@broadcom.com, linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org References: <1510953358-7043-1-git-send-email-khoroshilov@ispras.ru> From: Florian Fainelli Message-ID: Date: Fri, 17 Nov 2017 15:51:40 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1510953358-7043-1-git-send-email-khoroshilov@ispras.ru> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/17/2017 01:15 PM, Alexey Khoroshilov wrote: > brcmstb_waketmr_probe() does not disable timer->clk on error paths. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov Fixes: c4f07ecee22e ("rtc: brcmstb-waketimer: Add Broadcom STB wake-timer") Reviewed-by: Florian Fainelli -- Florian