From: Adrian Hunter <adrian.hunter@intel.com>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Yinbo Zhu <yinbo.zhu@nxp.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: fsl,p2020-esdhc sdhci quirks
Date: Tue, 3 Dec 2019 13:15:59 +0200 [thread overview]
Message-ID: <ec06a3c3-93dd-3d3f-e436-5d7cc3714531@intel.com> (raw)
In-Reply-To: <53c77b5b-627e-424c-234b-05f73b44863e@rasmusvillemoes.dk>
On 3/12/19 12:49 pm, Rasmus Villemoes wrote:
> On 03/12/2019 11.15, Rasmus Villemoes wrote:
>> Hi
>>
>> Commits
>>
>> 05cb6b2a66fa - mmc: sdhci-of-esdhc: add erratum eSDHC-A001 and A-008358
>> support
>> a46e42712596 - mmc: sdhci-of-esdhc: add erratum eSDHC5 support
>>
>> seem a bit odd, in that they set bits from the SDHCI_* namespace in the
>> ->quirks2 member:
>>
>> host->quirks2 |= SDHCI_QUIRK_RESET_AFTER_REQUEST;
>> host->quirks2 |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL;
>
> FWIW, with something like the patch below, sparse (make C=1) would complain
>
> drivers/mmc/host/sdhci-of-esdhc.c:1306:31: warning: invalid assignment: |=
> drivers/mmc/host/sdhci-of-esdhc.c:1306:31: left side has type
> restricted sdhci_quirk2_t
> drivers/mmc/host/sdhci-of-esdhc.c:1306:31: right side has type
> restricted sdhci_quirk_t
> drivers/mmc/host/sdhci-of-esdhc.c:1307:31: warning: invalid assignment: |=
> drivers/mmc/host/sdhci-of-esdhc.c:1307:31: left side has type
> restricted sdhci_quirk2_t
> drivers/mmc/host/sdhci-of-esdhc.c:1307:31: right side has type
> restricted sdhci_quirk_t
>
> But maybe that's too much churn, dunno.
Presumably testing would have caught this, so I think it would be better if
people tested their patches.
prev parent reply other threads:[~2019-12-03 11:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 10:15 Rasmus Villemoes
2019-12-03 10:49 ` Rasmus Villemoes
2019-12-03 11:15 ` Adrian Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec06a3c3-93dd-3d3f-e436-5d7cc3714531@intel.com \
--to=adrian.hunter@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=ulf.hansson@linaro.org \
--cc=yinbo.zhu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®