From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 874BE365A02 for ; Tue, 1 Sep 2026 06:36:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788244583; cv=none; b=du2p9s78orpyFjDkhVrAx2LLV3jm14xIuPZFuaEhq5cgdW/DlAVpWlGxE4yhNisskEpMZn+4NHn0LLxi6g6C1GsteexZOfJnFgT5SIJhYVo+tMuP1XpQHJqrr9uKj8Ix9ORJfVq6c6oDQPd2x+rBAImXnnDp74EjtNB9wXBfmcM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788244583; c=relaxed/simple; bh=aEjxZJwZLa+q7K9xSjUy2o9VFRy7tyW3hxCACheKEzQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VMPIU6Pl54d/RIb7njfygZ89P9mqknfTEQxWu9MoOmMv4gu2SX0RPIHE6R1yn7qm2mclyEuw0QsYIxOLGng8BP52oP/PCMTiPXCRfATPCz4i5jc2cHZgW4bxTJs10ctUiktCIIZhfLQL6eDnDDHGJux+it8hbO4qfo8UxzbL0zU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LW0/eV0G; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LW0/eV0G" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-38a0c7e841fso924318a91.2 for ; Mon, 31 Aug 2026 23:36:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788244582; x=1788849382; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=xWOAHh0q81CutOvcz4kXnkwApjt4e2WZQIvquKf0gdA=; b=LW0/eV0GCjU5Q7Eegs7cRAqdww3dwYBE4QHdHXYHGB/jHl46hpsLwRe24TXaikARaK 7CokcoxkzO0uFk1arXsaLSiIK9wrWANM7+gNNkGjNihkUG0ORthzofRyGnLLiZm4k7eT Opj4ooTqYc6h0mNR0rrKLmA0EqsdgJC/Lv7tz8iR4tD3LJx1YxYhjSMKg0WE6NmRrD5T ify/7M91krvUx/TAGIAw47SnAeWQ5YmGv6805gsYxFbuWGDr5Dro4GGuKwCO0TmCAXeK 2PauxsYQMIQVOv02/6Yym03Qid8gLhYFWTFZ3BYWwfAkDqUAvfxTBmKIyQXvDL//H2ud FD0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788244582; x=1788849382; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=xWOAHh0q81CutOvcz4kXnkwApjt4e2WZQIvquKf0gdA=; b=VIphiRp3kMnv/CJuXoswN/ixYxUGyjozc5drW1DXxBqPVfAPDk0D/a8jTap8UECBjk TyCBZqukrX1Ey/edXj/RRupBwCGbEucWJKbrqNont22sfMZ2PWaCM8jIf034F42lWF3i ajXbCSjiRUmX2xjssN/klb5au829GaW/wwqaORllPLg+wcSzgPceyQo2rE9bu68qSoUQ HbtAzyuYFDqUZQ+S2JFCh+orwFD1DVFO0D0DmYi1PFX5GXvWsjGL+P4oLNGJQfTvo+8F 6Bnv5D/KkAMKA7nduYpXZUnbT5e57B0X1gGfUY1KId422HZJeDbHDiFrmjzbMnrE98OO lIFw== X-Forwarded-Encrypted: i=1; AKwUvBwvsM/4iA52biv2ug51U2K8s7UkrPvDhPPrn8RRLKoS8TDE7xcB54LRWd4NSuaKqnxoz31djAwu/C600iU=@vger.kernel.org X-Gm-Message-State: AFuF++mYXNFozVoG+lqPW2btcgLlA+KwDWS+wBlpzuGdc6gEBEGmYg89 wa4TdHSwbCtaWuCQ07GspHSZUwWiPLa8KnDQTKVG9sQBVQvjIEi1eI31 X-Gm-Gg: AYBFou3QQsVFSGGrLU7FzzL+BmEv3RCtO3UFpaf9keDzEIt/WhnyT+DmOprdidpHcRd AwOPrvUrg2qrAd5Rlc0gzxI87EecYkdQC8UXdCFSkz+KuHXtoYOju/nAU3HQ8Ouvaq4B8GEV2ka BgV9VNvkLLXOjCowiRzbo+ZsdLujwX//GqUfkyVKXVQZ//CIbShTNN5UO6vgMtKxidt1gop+VdD NlfzCIACQhwDk/swsw37mLrK75yxw55LRPOVdT2s4YKEl8O8aTZl9B0r7i6Y0P9/XCTVNpM5hfU zaV3CZqtyalnYKJNxUZLXdqYQbvPlNx37K+2+tOTTo/wlsWHHamRxFDXEi8Kma0sQW2ZjBWGEuv qATunN+yRMXkK+97tsStaB9JoqfYQ0g+5HfORzxYQ0EtGNue91DC9QCWytnHnwJ3j/o8ZXKQiYW cpRyal/+zDRUtNC9902HiQ5k5QdBE/eyP6Wuaa/49F8xMtgcv3S904woQjYixhAm4T5CKgBFgpY bi0nnpaxzsgUIWT3wNhgTCb X-Received: by 2002:a17:90b:164b:b0:38e:4f41:83df with SMTP id 98e67ed59e1d1-396d1007e54mr46589908a91.15.1788244581535; Mon, 31 Aug 2026 23:36:21 -0700 (PDT) Received: from localhost.localdomain ([103.16.69.192]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-142e0dc854dsm32694425c88.10.2026.08.31.23.36.18 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 31 Aug 2026 23:36:20 -0700 (PDT) From: Aditya Dash To: Benjamin Tissoires , "Derek J. Clark" , Jiri Kosina , Mark Pearson Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 2/7] HID: hid-lenovo-go: use the right controller selectors Date: Tue, 1 Sep 2026 12:06:03 +0530 Message-ID: X-Mailer: git-send-email 2.55.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The right imu_enabled attribute selects FEATURE_IMU_BYPASS, and the right reset attribute targets the left controller. Select FEATURE_IMU_ENABLE for the right imu_enabled attribute. Target the right controller for a right reset. Fixes: 82cd9bc866e1 ("HID: hid-lenovo-go: Add Feature Status Attributes") Assisted-by: Pi:gpt-5.6-sol Signed-off-by: Aditya Dash Reviewed-by: Derek J. Clark Tested-by: Derek J. Clark --- drivers/hid/hid-lenovo-go.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hid/hid-lenovo-go.c b/drivers/hid/hid-lenovo-go.c index b8248bf8965c..b937d11dd6f6 100644 --- a/drivers/hid/hid-lenovo-go.c +++ b/drivers/hid/hid-lenovo-go.c @@ -1999,13 +1999,13 @@ LEGO_DEVICE_ATTR_RW(imu_bypass_right, "imu_bypass_enabled", RIGHT_CONTROLLER, index, feature_status); static DEVICE_ATTR_RO_NAMED(imu_bypass_right_index, "imu_bypass_enabled_index"); -static struct go_cfg_attr imu_enabled_right = { FEATURE_IMU_BYPASS }; +static struct go_cfg_attr imu_enabled_right = { FEATURE_IMU_ENABLE }; LEGO_DEVICE_ATTR_RW(imu_enabled_right, "imu_enabled", RIGHT_CONTROLLER, index, feature_status); static DEVICE_ATTR_RO_NAMED(imu_enabled_right_index, "imu_enabled_index"); static struct go_cfg_attr reset_right = { FEATURE_RESET_GAMEPAD }; -LEGO_DEVICE_ATTR_WO(reset_right, "reset", LEFT_CONTROLLER, feature_status); +LEGO_DEVICE_ATTR_WO(reset_right, "reset", RIGHT_CONTROLLER, feature_status); static struct go_cfg_attr rumble_mode_right = { RUMBLE_MODE }; LEGO_DEVICE_ATTR_RW(rumble_mode_right, "rumble_mode", RIGHT_CONTROLLER, index, -- 2.55.0