From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8359625A645 for ; Fri, 31 Jul 2026 21:19:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785532779; cv=none; b=Am6sOXqQSH8uqtlbqpoAOUk1DQEs/igsMXKKzAKYlmOr8AR073lKlCMEbXp9LklY70DXNBKyJdaSdm0jiKUff6GGaVVONSgAQRG74pbG7XdAqy7N7BIeLA9trzlze75/oXlqLIKfjjpATBPUzIiJakP8XFbn8lGNfyAKbc8fJ18= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785532779; c=relaxed/simple; bh=Xpj4ETP7gJ6QCZ+BXwFtkWiXwC3dGDBpb8ww3Ra7HdU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uTM2bFY07toU4TfwceYC4AfGQ58bdGEQqyhwngVSblLWRCrA5eq9OHP/5RY8JiDJ1odH1v7m/vQpJhvDEXltG13YSfQHo0Pq+3bz6WziyS7Fffjkd1b/p6gB/mgBVhMZd/Ittr0ebFlUPpcf0vc7Q4apf7AFxWvdzE7DnfFE/XM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=g+cV0WqZ; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="g+cV0WqZ" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-382ef647e20so1646267a91.1 for ; Fri, 31 Jul 2026 14:19:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785532777; x=1786137577; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to :content-type; bh=lmYgCoGHKlqVWmNpoNo+jeEf38ARJZoemI0nl3SFw+w=; b=g+cV0WqZ/XbzlBx+EXzMnzas65L4JQafMsGzqj6fX8h6mpKbYYI6ePPpDMCrp/tsV9 cb00DFcaP1xJIdwjYoWr9hX2yL4MWx/dyZ8lAQ6RQJAhSqbjtvetH039+Ysr/6qhh5xn CqHnWC3LWPqvIqvsC6PvGQ10gZi+93872SUuAHmOB1w9uvfd493eVtAcc+0nhEUQM0BW +aVoOJvs5bROYHuMKtr9gQkedQQT+6WRyH+gl4yATe++pSPGp/uW6uyrXugTy8IYuZ+b IWELsugKyfayFdWEFeXxkVgWJqHoaxi94OlAotsyoqIJwFCVAykurSbYN2pYyvS5tvR3 mQjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785532777; x=1786137577; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=lmYgCoGHKlqVWmNpoNo+jeEf38ARJZoemI0nl3SFw+w=; b=TnLmXe6YAseUYveweGxDWDoMF9Gw2wSL2yVnL3olXgEgx7rBOjFhJuDkqrv2g/ivge /VLTxOMM1lAcCDMx1AWPOA3aTXS6W5ETOifAgmNdZWrKl7n2jqyeMFfa8cfrRXLaHx6F ukXii6aiiOZGeStdwVKEnmH8C7xp5pWngIXLB/Ovn8ZcZ3pUb+9Azs/1PRnwCxh9obuk ii8K+tBADLCh+m6fzgwo2opAowweCoNCQnyWq50CorM3mgxdjNAXyimNbUO80UhymyAl C81FY3cewCPZtNRS0h7lRc3NrQw3HLFzQPTyRADyBLKaJKEzENONwcjiZURJGEiFhmhW pnhQ== X-Forwarded-Encrypted: i=1; AHgh+RojUNdc+VybC/+/FLWmry36AS9aKzANeUORO2IKQ//I1JycCPnHjeYvvPqWTiccWdGivoi/ho9i3DpAOC4=@vger.kernel.org X-Gm-Message-State: AOJu0Yx3IRR0+g5t/Ea8FljJNpyUPRo9qTatme8OO7E9+F/tKsX4b5QF BjiF+Eu9gJQ+NmgWUsZymYp2ghwEJiRAJv+yZfjKvirgqU+rd4p/0RqB X-Gm-Gg: AR+sD13pLV7qRa2Ynx81G8tzZkJjwSNTmtFvhXjsGVidQiNVdatj36Ai4qv9WmHwozp 1D9oeld4NpJoR9Fnw6184uAH8+MvIFxGYU4ARyMaTmHL4MM+uuAYQ5x2Eh6k8lX+YSgVvrwdl6J LkRr/V96G4oNH1RnGa754pYXheOF+iUueDzaKAxvplCP5skz9dnKROOfu29/Ma/umGm5CFKFHT7 aPg6hd0kg8UVH44LfRLpdP5V73zcw1r603TtWwGb31lZyn2L69kW38987Rd+2FYIHzE93/eKY5z 7EoeX+Czdn3UW7IgJzX3viPlby5HRwP0YG/Ug5mWp2W/T/v3tF6IEjZQwquE4+2UwHKGXBMfw3Y FYYYA+V2hOhy9T7IfbQ7Qd6ornwFOJic02RuN151PNnubZI8g+N4jw7i4NHKpkIT7mMBkXpe47C hRiv56dXoIhyJ1pnAaPH1hLwrlFWxJX48eVvZ5nyheevA5EmEsJ/ct+VF/1SijUbEnizcyRB4YF LWChUbJy+hPh3XDq5y6YX8jdgyqKfKasHLZYQ== X-Received: by 2002:a17:90b:5143:b0:37f:9ce2:348f with SMTP id 98e67ed59e1d1-38fbc506b07mr1121119a91.32.1785532776759; Fri, 31 Jul 2026 14:19:36 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153e045016sm14346356eec.19.2026.07.31.14.19.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Jul 2026 14:19:35 -0700 (PDT) Sender: Guenter Roeck Message-ID: Date: Fri, 31 Jul 2026 14:19:33 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2] watchdog: pretimeout: Allow building dump governor as module To: Andrew Morton , Mayank Rungta Cc: Mayank Rungta via B4 Relay , Wim Van Sebroeck , Tzung-Bi Shih , Douglas Anderson , linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org References: <20260730-export-cpu-backtrace-apis-v1-0-bace8e1cb817@google.com> <20260730155021.8252ad9d155b472702e66755@linux-foundation.org> <20260731140142.7d77cfd7e9f99f25880efd32@linux-foundation.org> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAmgrMyQFCSbODQkACgkQyx8mb86fmYGcWRAA oRwrk7V8fULqnGGpBIjp7pvR187Yzx+lhMGUHuM5H56TFEqeVwCMLWB2x1YRolYbY4MEFlQg VUFcfeW0OknSr1s6wtrtQm0gdkolM8OcCL9ptTHOg1mmXa4YpW8QJiL0AVtbpE9BroeWGl9v 2TGILPm9mVp+GmMQgkNeCS7Jonq5f5pDUGumAMguWzMFEg+Imt9wr2YA7aGen7KPSqJeQPpj onPKhu7O/KJKkuC50ylxizHzmGx+IUSmOZxN950pZUFvVZH9CwhAAl+NYUtcF5ry/uSYG2U7 DCvpzqOryJRemKN63qt1bjF6cltsXwxjKOw6CvdjJYA3n6xCWLuJ6yk6CAy1Ukh545NhgBAs rGGVkl6TUBi0ixL3EF3RWLa9IMDcHN32r7OBhw6vbul8HqyTFZWY2ksTvlTl+qG3zV6AJuzT WdXmbcKN+TdhO5XlxVlbZoCm7ViBj1+PvIFQZCnLAhqSd/DJlhaq8fFXx1dCUPgQDcD+wo65 qulV/NijfU8bzFfEPgYP/3LP+BSAyFs33y/mdP8kbMxSCjnLEhimQMrSSo/To1Gxp5C97fw5 3m1CaMILGKCmfI1B8iA8zd8ib7t1Rg0qCwcAnvsM36SkrID32GfFbv873bNskJCHAISK3Xkz qo7IYZmjk/IJGbsiGzxUhvicwkgKE9r7a1rOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAmgrMyQFCSbODQkACgkQyx8mb86fmYHlgg/9 H5JeDmB4jsreE9Bn621wZk7NMzxy9STxiVKSh8Mq4pb+IDu1RU2iLyetCY1TiJlcxnE362kj njrfAdqyPteHM+LU59NtEbGwrfcXdQoh4XdMuPA5ADetPLma3YiRa3VsVkLwpnR7ilgwQw6u dycEaOxQ7LUXCs0JaGVVP25Z2hMkHBwx6BlW6EZLNgzGI2rswSZ7SKcsBd1IRHVf0miwIFYy j/UEfAFNW+tbtKPNn3xZTLs3quQN7GdYLh+J0XxITpBZaFOpwEKV+VS36pSLnNl0T5wm0E/y scPJ0OVY7ly5Vm1nnoH4licaU5Y1nSkFR/j2douI5P7Cj687WuNMC6CcFd6j72kRfxklOqXw zvy+2NEcXyziiLXp84130yxAKXfluax9sZhhrhKT6VrD45S6N3HxJpXQ/RY/EX35neH2/F7B RgSloce2+zWfpELyS1qRkCUTt1tlGV2p+y2BPfXzrHn2vxvbhEn1QpQ6t+85FKN8YEhJEygJ F0WaMvQMNrk9UAUziVcUkLU52NS9SXqpVg8vgrO0JKx97IXFPcNh0DWsSj/0Y8HO/RDkGXYn FDMj7fZSPKyPQPmEHg+W/KzxSSfdgWIHF2QaQ0b2q1wOSec4Rti52ohmNSY+KNIW/zODhugJ np3900V20aS7eD9K8GTU0TGC1pyz6IVJwIE= In-Reply-To: <20260731140142.7d77cfd7e9f99f25880efd32@linux-foundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 7/31/26 14:01, Andrew Morton wrote: > On Thu, 30 Jul 2026 16:39:14 -0700 Mayank Rungta wrote: > >> On Thu, Jul 30, 2026 at 3:50 PM Andrew Morton wrote: >>> >>> On Thu, 30 Jul 2026 15:00:20 -0700 Mayank Rungta via B4 Relay wrote: >>> >>>> All other watchdog pretimeout governors (noop, panic) can be built as >>>> loadable modules. However the "dump" pretimeout governor is restricted >>>> to built-in code because it calls trigger_all_cpu_backtrace(), which >>>> relies on arch_trigger_cpumask_backtrace(), an arch specific helper that >>>> is not exported to loadable modules. >>>> >>>> This 2-patch series allows building the dump governor as a module (=m): >>>> 1) Export cpumask_backtrace() in lib/nmi_backtrace.c. >>>> 2) Convert CONFIG_WATCHDOG_PRETIMEOUT_GOV_DUMP from bool to tristate. >>> >>> LGTM. Can you please redo against current mainline? The Kconfig has >>> changed. >>> >> >> Thanks for the LGTM! >> >> Regarding rebasing onto mainline (origin/master): The "dump" >> pretimeout governor was added recently by Tzung-Bi Shih ("watchdog: >> pretimeout: Add "dump" pretimeout governor") and is currently in >> linux-next, so it hasn't landed in mainline tree yet. >> >> Because of this dependency, I based this series on linux-next so that >> patch 2/2 ("Convert dump pretimeout governor to tristate") could apply >> cleanly on top of the new governor. >> >> Please let me know what is preferred, or if you'd like me to post >> against a different tree! >> > > Oh, OK. > > Guenter, can you please process this patchset? > Sure. Assuming you'd like me to handle it through the watchdog branch, it would be great if you can send a formal Acked-by: to the first patch of the series. Thanks, Guenter