mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Alejandro Colomar (man-pages)" <alx.manpages@gmail.com>
To: Erik Flodin <erik@flodin.me>, mtk.manpages@gmail.com
Cc: linux-man@vger.kernel.org, Stefan Rompf <stefan@loplof.de>,
	"David S. Miller" <davem@davemloft.net>,
	John Dykstra <john.dykstra1@gmail.com>,
	netdev@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: netdevice.7 SIOCGIFFLAGS/SIOCSIFFLAGS
Date: Fri, 30 Apr 2021 21:32:52 +0200	[thread overview]
Message-ID: <ec0d0a2d-235c-a71f-92bc-45e1156bff9e@gmail.com> (raw)
In-Reply-To: <CAAMKmoe8rUuoxFK2gKZL4um79gmtn-__-1ZDWuBgGTqfqPjZdw@mail.gmail.com>

[PING mtk, netdev@]
[CC += linux-kernel]

Hi Erik,

On 4/29/21 9:45 PM, Erik Flodin wrote:
> On Wed, 14 Apr 2021 at 21:56, Alejandro Colomar (man-pages)
> <alx.manpages@gmail.com> wrote:
>>
>> [CC += netdev]
>>
>> Hi Erik,
>>
>> On 4/14/21 8:52 PM, Erik Flodin wrote:
>>> Hi,
>>>
>>> On Fri, 19 Mar 2021 at 20:53, Alejandro Colomar (man-pages)
>>> <alx.manpages@gmail.com> wrote:
>>>> On 3/17/21 3:12 PM, Erik Flodin wrote:
>>>>> The documentation for SIOCGIFFLAGS/SIOCSIFFLAGS in netdevice.7 lists
>>>>> IFF_LOWER_UP, IFF_DORMANT and IFF_ECHO, but those can't be set in
>>>>> ifr_flags as it is only a short and the flags start at 1<<16.
>>>>>
>>>>> See also https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=746e6ad23cd6fec2edce056e014a0eabeffa838c
>>>>>
>>>>
>>>> I don't know what's the history of that.
>>>
>>> Judging from commit message in the commit linked above it was added by
>>> mistake. As noted the flags are accessible via netlink, just not via
>>> SIOCGIFFLAGS.
>>>
>>> // Erik
>>>
>>
>> I should have CCd netdev@ before.  Thanks for the update.  Let's see if
>> anyone there can comment.
>>
>> Thanks,
>>
>> Alex
>>

> Hi again,
> 
> Have there been any updates on this one?

No, Noone from the kernel answered.  And I'm sorry, but I'm not sure
what is going on in the code, so I don't want to close this here by just
removing those flags from the manual page, because I worry that the
actual code may be wrong or something.  So I prefer that when Michael
has some time he can maybe review this and say something.  Ideally,
someone from the kernel would also respond, but they haven't.  I've CCd
the LKML; let's see if someone reads this and can help.

Thanks,

Alex

P.S.:  Please, if we haven't responded in a month from now, ping us
again.  Thanks again.

> 
> // Erik
> 
>>
>> --
>> Alejandro Colomar
>> Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
>> http://www.alejandro-colomar.es/

-- 
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/

       reply	other threads:[~2021-04-30 19:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAAMKmof+Y+qrro7Ohd9FSw1bf+-tLMPzaTba-tVniAMY0zwTOQ@mail.gmail.com>
     [not found] ` <b0a534b3-9bdf-868e-1f28-8e32d31013a2@gmail.com>
     [not found]   ` <CAAMKmodhSsckMxH9jLKKwXN_B76RoLmDttbq5X9apE-eCo0hag@mail.gmail.com>
     [not found]     ` <1cde5a72-033e-05e7-be58-b1b2ef95c80f@gmail.com>
     [not found]       ` <CAAMKmoe8rUuoxFK2gKZL4um79gmtn-__-1ZDWuBgGTqfqPjZdw@mail.gmail.com>
2021-04-30 19:32         ` Alejandro Colomar (man-pages) [this message]
     [not found]           ` <CAAMKmocBEr05EfidF9CfqJQw4uj1YcYwmkJPR=c0eCCYgsAHwg@mail.gmail.com>
2021-11-12 21:01             ` Alejandro Colomar (man-pages)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ec0d0a2d-235c-a71f-92bc-45e1156bff9e@gmail.com \
    --to=alx.manpages@gmail.com \
    --cc=davem@davemloft.net \
    --cc=erik@flodin.me \
    --cc=john.dykstra1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-man@vger.kernel.org \
    --cc=mtk.manpages@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=stefan@loplof.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome