From: Wilfred Mallawa <wilfred.mallawa@wdc.com>
To: "rjethwani@purestorage.com" <rjethwani@purestorage.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"john.fastabend@gmail.com" <john.fastabend@gmail.com>,
"sd@queasysnail.net" <sd@queasysnail.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"horms@kernel.org" <horms@kernel.org>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH net] tls: check the right open record in TLS_TX_MAX_PAYLOAD_LEN
Date: Mon, 19 Oct 2026 23:35:22 +0000 [thread overview]
Message-ID: <ec0ff3dfe347fcac3350c945c432946f869d8b43.camel@wdc.com> (raw)
In-Reply-To: <20261019222626.745408-1-rjethwani@purestorage.com>
On Mon, 2026-10-19 at 16:26 -0600, Rishikesh Jethwani wrote:
>
> net/tls/tls_main.c | 17 ++++++++++++++---
> 1 file changed, 14 insertions(+), 3 deletions(-)
>
> diff --git a/net/tls/tls_main.c b/net/tls/tls_main.c
> index fbb274287aa5..8f11b8629492 100644
> --- a/net/tls/tls_main.c
> +++ b/net/tls/tls_main.c
> @@ -837,12 +837,23 @@ static int
> do_tls_setsockopt_tx_payload_len(struct sock *sk, sockptr_t optval,
> unsigned int optlen)
> {
> struct tls_context *ctx = tls_get_ctx(sk);
> - struct tls_sw_context_tx *sw_ctx = tls_sw_ctx_tx(ctx);
> u16 value;
> bool tls_13 = ctx->prot_info.version == TLS_1_3_VERSION;
>
> - if (sw_ctx && sw_ctx->open_rec)
> - return -EBUSY;
> + /* Both TX paths size the record they are filling against
> + * tx_max_payload_len, so refuse to change it under an open
> record.
> + * priv_ctx_tx is a different struct for each TX
> configuration.
> + */
> + switch (ctx->tx_conf) {
> + case TLS_SW:
> + if (tls_sw_ctx_tx(ctx)->open_rec)
> + return -EBUSY;
> + break;
> + case TLS_HW:
> + if (tls_offload_ctx_tx(ctx)->open_record)
> + return -EBUSY;
> + break;
> + }
>
Ah good catch!
Reviewed-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
next prev parent reply other threads:[~2026-10-19 23:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 22:26 Rishikesh Jethwani
2026-10-19 23:35 ` Wilfred Mallawa [this message]
2026-10-20 10:58 ` Sabrina Dubroca
2026-10-20 11:18 ` Jiayuan Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec0ff3dfe347fcac3350c945c432946f869d8b43.camel@wdc.com \
--to=wilfred.mallawa@wdc.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rjethwani@purestorage.com \
--cc=sd@queasysnail.net \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®