From: Mark Brown <broonie@kernel.org>
To: Jisheng Zhang <jszhang@kernel.org>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] spi: dw: use threaded interrupt and optimize the threaded ISR
Date: Fri, 7 Aug 2026 18:32:44 +0100 [thread overview]
Message-ID: <ec1559ba-92d8-44d7-93da-e217b02f9399@sirena.org.uk> (raw)
In-Reply-To: <20260803140649.12718-4-jszhang@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 785 bytes --]
On Mon, Aug 03, 2026 at 10:06:49PM +0800, Jisheng Zhang wrote:
> To avoid blocking for an excessive amount of time, eventually impacting
> on system responsiveness, hard interrupt handlers should finish
> executing in as little time as possible.
>
> Use threaded interrupt and move the SPI transfer handling to an
> interrupt thread.
It might be safer to make this happen only in host mode, not in target
mode - while the performance improvement will apply for both target mode
has no control over the clocking of data by the host so is much more
vulnerable to dropping data in a threaded interrupt if the system is
loaded. In host mode this isn't an issue since we'll simply stop
clocking data while waiting for the scheduler to get round to the
interrupt thread.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-08-07 17:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-03 14:06 [PATCH v2 0/3] spi: dw: use threaded interrupt Jisheng Zhang
2026-08-03 14:06 ` [PATCH v2 1/3] spi: dw: use DW_SPI_ISR directly Jisheng Zhang
2026-08-03 14:06 ` [PATCH v2 2/3] spi: dw: use DW_SPI_INT_MASK instead of hardcoded 0xff Jisheng Zhang
2026-08-03 14:06 ` [PATCH v2 3/3] spi: dw: use threaded interrupt and optimize the threaded ISR Jisheng Zhang
2026-08-07 17:32 ` Mark Brown [this message]
2026-08-07 17:24 ` [PATCH v2 0/3] spi: dw: use threaded interrupt Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec1559ba-92d8-44d7-93da-e217b02f9399@sirena.org.uk \
--to=broonie@kernel.org \
--cc=jszhang@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®