From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752055AbdFZWWT (ORCPT ); Mon, 26 Jun 2017 18:22:19 -0400 Received: from mail-cys01nam02on0049.outbound.protection.outlook.com ([104.47.37.49]:45246 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751492AbdFZWWQ (ORCPT ); Mon, 26 Jun 2017 18:22:16 -0400 Authentication-Results: davemloft.net; dkim=none (message not signed) header.d=none;davemloft.net; dmarc=none action=none header.from=amd.com; Cc: brijesh.singh@amd.com, gary.hook@amd.com, herbert@gondor.apana.org.au, davem@davemloft.net Subject: Re: [PATCH v2 1/3] crypto: ccp - Use devres interface to allocate PCI/iomap and cleanup To: Tom Lendacky , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170623160630.63292-1-brijesh.singh@amd.com> <20170623160630.63292-2-brijesh.singh@amd.com> <262828f7-b433-b271-3caf-dbb4a8a7c5dd@amd.com> From: Brijesh Singh Message-ID: Date: Mon, 26 Jun 2017 17:22:10 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <262828f7-b433-b271-3caf-dbb4a8a7c5dd@amd.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: DM5PR1101CA0018.namprd11.prod.outlook.com (10.174.246.28) To SN1PR12MB0158.namprd12.prod.outlook.com (10.162.3.145) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 712497ee-5250-4249-433f-08d4bce1cc02 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(48565401081)(300000503095)(300135400095)(201703131423075)(201703031133081)(300000504095)(300135200095)(300000505095)(300135600095);SRVR:SN1PR12MB0158; X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0158;3:L72BnUao7ZmExLGZS0wpEpxqS/u4mM5Bo5jqaGdRx6ud4XhT8NFet9ODQ/zgm+s8TrP3qJMYXnDhREwaTOG3w4wwlHJeSeSUpH+uVzGdfTG0yrNyz/Zf0M83VduATMaJNd6vlpOB5+RFmvbLwUtH6lZQ3HQrg0VcQ4GfXhKG2xBr4e/OpJkLdORhJXH++49/CTLOg2JZArAJP9ncrFKPsnTvTTuTZC0vV6v02r4+rj4moJJZxBv1ko9qxO7gRpLG2Os3a7ud0KzVBy1cgYbqBNqGMbevkh2swUX58Ml5TM8xd/ZB1BeDX9Cos/o3aQ0dSeId8G5Sf23SV9vPI+GabqssMWMUvVI5+/lkT6T3BTVvkJ0tfZV7V+R41obtv6z+OxevENEKn29d2AdnRrdHbpFYwmloIKv3BOv8U96zhSHJeDF0SnsYqe8SAlM7+VY2PTtYIvz4U+uwLVkHgUKNXowR5V7aArBJN0yVqHburTt7ZjfNb8eGMPcLHNhvOFIih0ijVHsJRiewcPtp5vIGJ4pjNpoVyRO0RP/8kSvWSfjn6/slv7hF/KR2Ty7Y1zK405qExv/ekRzKUIBD9XhEoYwlz7ODjEseM9jAx00gIiDWBuuyapJ8fH+fjCdO/8/bMhbWND9aWE+BrT0s7+Kzah0y/mBDEJfmZxpUF6dixnqQG5D61P4UUTcgEtAP4k/W8RFYQIISi3i18xVxNZdaTg== X-MS-TrafficTypeDiagnostic: SN1PR12MB0158: X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0158;25:Tpx2x6j6kTvMc+KfTPtZxlfimU0l77pbQXkhajgRB7PXHnkvEKsalUc14Wr/rjgh34fg+V8lU987SBOzi1CQloDdSz7Vv5jUghbRitmOegHYjKUgC2ONBJeZPgJCG2UCn8YZSW072E3B2od1l53jT4eGI/ZmydpM83DwqiJyfM7wwjcmvGNmldYNMFzJh/WLX87xc29bQ8zfYAhVVFEPvIgkRa+Yxnuxr8TCVEyK6xP8FSFmFHn/pEB5I1zOOdQUCvzRXxsoDeETgSLuYxETE7khlc9k/jNTD2zxVN4lX49bC7kMNCALL7zjsb9AJHm2zkJjydSkknBD1urJdY6PRdoVKGl6qv1lRH9AsE/lc+koW4AYu4wPabvddoiIAEKf76PQopO1/lqrOVHIZJqSml9r3LhUviMjDPcrxuTER94sLgYRIpOOR/mN+Q22JwrO6yC4YTCF5a7sjrKyBKxQgm26NJF3UdgvnZMpJLEYlcGi/i1TXO665CQfxwEdCZKBtz2zgbrLRFzUxxx8f0xkpDlvCt0XvS2shk5NPazM9fVKRlf5sJsGRWOaxL8WjUFjlHLNKB2IA7z8lF3Olbm5c/Dxz9xhcz/rDo8dLoMqZBxXoh7WmliXj7oc3I6R4/vGojNF6IBVGqsCuPNKcskFK0z0QrsL3koSAMJ5uiNk5WyPaiFTiiWxHqOmaG0qqOSiKmxPvppVDbtw7IpJKyLOTPEuGNxM2x7teOvW2X2KyVsD1KsspGK2NrM1ohYPJ2KZYmR/tUtrePC7P2rpUT4LveVdEY06lCTNRVUJma5HzU+6uIVuXv3ppARTg+A719v8A65hgkstEc72GmpuMNFPAIahA7qHgdZIFvXrwWN5YkHhyP5G43h3LchoLetXbDj+qt+0AV+sX06inFPuUPZie/wSsXTgb3fjxhE3UpEO9j4= X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0158;31:u/4MndD9i+f6/Tni6hKCJdOOVR7o5rqY7UxLyrsaRQ3FZTPDRo90tXkTA3OfwKxLOCbwt2KlccQvrMf1qzTfdVGy8/GrM1qdvYen+DlgOAEKftaN6BDTG+IvACgro9uVhPo23o4JJJEfj+DXVhE0YrahK99JK8GKX8xcfeWCNoI9GOXtFpvRcmzEfyJJ3rCAMZyMXofW/9xIpetK6WCVVD8vMIV0fh0rnjsF73rNwtXsZ59QAgn4shCZH9z5zN39kBdwOY/px/vnGFyBE1r1u2ZBpkFSA9mMhcUw/SwcGXmOqnGygznIaKkr+whwLBo3ouya3DZ38FDoLBvNRQ3eBbXPRa+7k5hxXW9JBuoG7pE6JYEW+iYtqx0vXjf2V8nUf6NyHPw97cSXb6CSkiHgNNQtfpyv/4wJjFqtAJnvMprV15Qt2tESMJ2B1Z7zAVzAoI+qv6qXLv2xeGcPdwdC0XB+rl7PKQZ6+3VgWzt+ot74pDdEaLawC0QI1iQmKqI2m6jGINgq5J4EOiy0HCjDkUTB9JqZzfbsptz3VE/QKEkbLXfrtbe+AWxs1kjmn9QxNCl0rqboc9oQxGq1OT27HVjeScPTUKUVfY0pt1ZOHOrPQ3LMqG0uRpFzf8OIt5KTwRrhVJI/rg00kESD3VjIgAL58fNQMOcEk254vMQ2TWw= X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0158;20:o4QReBxnqFAUzb4iIn2hoQqnc/ugd4k4/38XmxGzfx322nIAt+unG9ROofFzBsO8WoJA11pOsmayuS702pw8KJ0IAASuo9VSg6IWtFrqF1rZkdpMVZYk8bE21HCHgVWs1DmD22wjSSPQaI2g/CG8rMIXcOVIbOCmuSJ7pE7kpGlrh8h190r40hWOT+XXCtScGdqQTGZIO6cBj7bQf5bUqLzF9cGEr3OQGg+MOjeTjgx8Suivw4RBloSPv1D+tgOc6QslrlCdhSGHb0xwOATOtqDH9dY/rEEiEqmz3geB53uMiUBOlATlYU5404IIsFb8Ji9CIZrPZp4fkxz/Hgt9FcwsbmdqMyGnPxB3qH/EP/cR6evECnC/GIax2Dye4HVgQ3qkqjAr4pcJp+fGRD2Li9oCfkEXbtVdaO/WjZvWY+TQV4W3MnzNDD8ugDOhR5gpwY5z/JIboecazs3Eveq5nfVP5T208wOGvEyxavqDk40zmrH++Ov2xSwpR4YHpi9L X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(236129657087228)(48057245064654); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041248)(20161123564025)(20161123558100)(20161123560025)(20161123562025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:SN1PR12MB0158;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:SN1PR12MB0158; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjFQUjEyTUIwMTU4OzQ6cXkxZ1JGOE51Z1dkVzhGM0tYdXNFaXczcVRr?= =?utf-8?B?bzRTVnY3SlFnRllLWlgyK3c3YW51WTZXSEhZNVZvbTB6TlI3UjF5ckFNbkNR?= =?utf-8?B?YW9LdkFOaWZPZmtyeE84NXJvS2xmTjZvdTF5ZTVycUNXY0E4ZE9uSTRqZ3BT?= =?utf-8?B?eCtBTVBjaUFGSnhDNUpGaVBEOUExMTE4WWNZRTd6ZnhvQUlvV0g5eS94UDFS?= =?utf-8?B?c2ltTklHYmlmWjNnc0FrNkpZQlVjcXluNHVnS2ZjZUhZY1BBMkZlbitPSHNJ?= =?utf-8?B?UkVNVkorbFZSODV6dUZWRFdKelpQYmtpZ2FKL2lyWEtrN0dUd3c1SkYzbkIw?= =?utf-8?B?a0lBMGlUME5qV3ZvS05XT0RHRFA4K21lTVVJRi84eVVlQXE3ZGVxMmpPWFpl?= =?utf-8?B?WVBEdC9EN3hqb2NvNWhqd1BrRGpTQTRiQ0RyZnd4QzhoNzg1V1lRWHJ2RHpo?= =?utf-8?B?TEVRbW9MSzAyU1NqSVU1eHJrdUkzcFR1YTFia0pyZVlkY1lER1lTUTFZYzJm?= =?utf-8?B?YWxvYWo2YVh4bGxRY2ltM001YWtiNTBRYTNWcnFFeGViNi9ZNzFxN3ZSWnRk?= =?utf-8?B?VjZ0bE1oeU5Idll1bThCRFNWU0dRN2IzdlhpcVc3OGJGNWE0SklyR0d2R0RS?= =?utf-8?B?cVZnY3ZGU1FFWHBiaFNoVXh2ZEdnS1lGaWt3NEs1WDlVN0g2S21Za2NCTHo3?= =?utf-8?B?NFhMVjg4MnJtZDdlTUFRbVpyMXdQUk5lTHJaT2pXVGx6b09WTWNQVkxpcXIy?= =?utf-8?B?MTc0b1YwcU9MbXFTUytRRGVpc2U3S2VORjJKTG1ua1QxYVJ2TE9UOHJHNDF3?= =?utf-8?B?aHZmNFY3Y2wwbXFpbkJXaW9uVmZGWlo4dUQzZjdlNGJWdEo4dHlxdEs2clVq?= =?utf-8?B?ZTUrVXkvSGxRUTFUR0lKQmF3OVk0SzZ2djBTTThDcW1SNWRpWU1JTGY0WXRv?= =?utf-8?B?QVNadmlsTG1KWXRMUlRUMndwWU16dE16L0hNWHlrVEF6YUxZVjNRaDVCVDZv?= =?utf-8?B?bXNmSTVYTVE3QjlROFVCMmZ6M29iSUd0MkZQc2hheHBacHR3QmdnK2x5WEto?= =?utf-8?B?QjIxc2hEenFiZE53TlJMVWtvRGw5aHB0NUFBeGQwNmRja0E5TTRUQ09kYnV6?= =?utf-8?B?cHlHTzAxbkpDNHVWbTdRcGtIRUtYaFZiS200MzhjVnpMWCswTGhDTSs5NjM1?= =?utf-8?B?TjRWMG9hUzdUalJNT1Y3bHh3WWd4alJsbDQwTi9iTGRqNktjMno4K0l0RzVX?= =?utf-8?B?bkp4dm9KYS95K0ttbjc1MEsxSGdqUUpMZGVqcVBJUzVab0dEMkFVaitJRXEx?= =?utf-8?B?amxFTnByVjFuaWF6b0NpT0RnYlRScXh2ZVdxbUQxb3BMUUg1aFVGcFVPc05U?= =?utf-8?B?VjEvMkhrMDlIZG9ibnY3NEZqZ0VYRi8wVGZnQjZ5a0F1eFRJV01SN2FXSm45?= =?utf-8?B?c0VGNGtZL3JqR0ExaHllM0hmRWQxQ2hmY0NSZUJVT1Y2T0VjbXhtYWp6enVE?= =?utf-8?B?WkZiaVRkdUNTWUZ6d1puRzJhVzlmdlcrSnQ0SkdXQ2JhT0p5U0NrbmRaalNV?= =?utf-8?B?Tit5QktYYTM5dXkvUmdRQzhoczNJc3hGYm9TaGgxbEFIU1NiL25EblcvT05Y?= =?utf-8?B?WGlNcXU0QzVpdm5wQTJ2SDRpYU55clFBSjAwN1NLSXp5SXNyOHV2bDI0Q24v?= =?utf-8?Q?Oxq6HJbV813powmp8=3D?= X-Forefront-PRVS: 0350D7A55D X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6049001)(39410400002)(39400400002)(39850400002)(39860400002)(39450400003)(377454003)(24454002)(5660300001)(86362001)(65826007)(6246003)(6116002)(230700001)(31696002)(4001350100001)(81166006)(36756003)(31686004)(66066001)(50466002)(65806001)(2906002)(189998001)(8676002)(65956001)(3846002)(38730400002)(110136004)(83506001)(42186005)(50986999)(54356999)(76176999)(77096006)(229853002)(53936002)(478600001)(53546010)(6486002)(305945005)(33646002)(4326008)(2950100002)(23676002)(7736002)(25786009);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR12MB0158;H:[10.236.136.62];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjFQUjEyTUIwMTU4OzIzOnRxNGNUUmRYajB3MWQ3cElGNVAzR3Iwd3NY?= =?utf-8?B?WmZBUFhTdjNHcU1zUjZBWE1IYnZUOC91QlhSemNBeXhybHZiZnVtRFBsQW9W?= =?utf-8?B?UWF5cmVpbzRnOHhhT0RnYmlubDhsZUVnTTJRRUIweUJUYkkrTkFod1kxT1oz?= =?utf-8?B?K1ZWRXlERk9tQ0tCUTBIckU5MC9VWXdlU2R6TGZyTGtOSzhFWDlNbmIrNklX?= =?utf-8?B?aEJmMFE0ZnVGeXM0eldhazh2R0gwaG5yMlQ3YjAwL043cHdyYU5IU25Fd0VW?= =?utf-8?B?bjQzZWswQ2E4emtnMEF2WmYwSkJzQU01RHpTNnhmbGhPaTBzcmVsYWFSREpx?= =?utf-8?B?dThhZnplQnRtUlNiOE14WTBHWTFsRkdLMGMxa1ljWHhPc2ZnVGI2ejdyanB3?= =?utf-8?B?UjkvN0N4SC9tOTc1NDd3WE44YXlkS1d6RDcyUWtya0dZYTA5NU5YdnlsWFU0?= =?utf-8?B?ZWNYU01oQktMWnJhZDdUUHMwUjBadFJweUVhVlV1b0JSSWpaTUpaay9rRXN4?= =?utf-8?B?Tk9sa1ZndXl4MEhsU1N2TjFmdmpidWhRNUEwNzVpbmJmRTNDNzJsVFFqTHZU?= =?utf-8?B?bktXQW5JbERYZVJHcmthQUNkR2FZNFZ3eHliajFUcGdwa2JMNHpmNkRMbGVX?= =?utf-8?B?djQ4UDE4T1RCYmhJL05sZkhwY3B2YWIwYWh2bGl0VDRYMS9mOUtMT1JjWWNK?= =?utf-8?B?SzgyelZwK3plUnRvOGRwenpyYkNQWUwyNmwwY1FtSVdiZDc3M0FPYk44SldP?= =?utf-8?B?aVVnOG1OQVdUbVhYeHRnRURmQnpUMDBHQ2VMbTlycWRCc1FpU2dUYXBITmRa?= =?utf-8?B?eE9qcG12K1hxSWh5bWtGQVBHczE5MEl1RmxoNm1Nbi9FaWxYTXp4M0l0czAx?= =?utf-8?B?VHcxcStGK01EdzZObG93YjlkTG1pUVZNbnJOZkpMamZxcFY5TnZvajNQbTFh?= =?utf-8?B?bm5FZlF1V21QWnhRN1AzYzdMZXhSdC9YYVN3bGRHY3ZoUlJMTllGVjBJb2NV?= =?utf-8?B?Mk0wN0VmN1BoT1l0R1VzU2NzdGd3VDU1bjZXU000VUYxK3h4enpmanFLWWM4?= =?utf-8?B?SjZnRUdVamN1T2VXVTFNVndlVkJwZmxNaXNrcUlBdERsR1lPLy8yNlFvOW51?= =?utf-8?B?YkFvSzVCUXZXS1pKZmYxMFN0SzI3WjJhSHhFVVp3cHJhc1MyT3ZLS2thVXU3?= =?utf-8?B?aXZ1d3hxajRQK3kxRUs4Ym9HSXBScUJ3djZPWUJqeFB4TmNoZm9Jdm92UUFR?= =?utf-8?B?c0pGTjM3NlZ5c3BRckI3NE4rNlB2N1Q5K0phYk93ajU3UUNUVWNYOTVieFBo?= =?utf-8?B?TGYrdktPMUFRdUc0dEZoTmdEQW00dWRDMmhOU3gyeFBZZExMSmdTT3NWTVMr?= =?utf-8?B?bjdObDJtOElWT1REbjhnYndLdVhINlVJY1hKdWFWaFptdVdqemFKN01CZzNq?= =?utf-8?B?WWJoV2p3UFhpLzZyT2NHOERLSE40Smhta3lRTWFTOVFLN1NkU3grVjZxd1g0?= =?utf-8?B?ejN4ZzNUOEdBZXhsQXdOdnlxMWNpeFVkNGdrUm1mbHRDL29sSWY5dTdpUklY?= =?utf-8?B?U2QxSXNYVk9CemF1QWVNbG1vNC9ZY09vY2dNdnBSbStRUTd0UnBUaHo2OGdr?= =?utf-8?B?RW1nMFh1N0MzNjdzcjlpekhxUlN0My9PNlNmR3dJRTVSRU9YOUlnczdBPT0=?= X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjFQUjEyTUIwMTU4OzY6bWpkNEo3M2VDeGt3VnVoN3FXMGFDZjVYTElw?= =?utf-8?B?K0xDOWNCbHR1eFZ0UWRlZVZIL3g2V0syZnpnSThoTUo0NTkxZW5meDhqUGcr?= =?utf-8?B?djI5am9TQmRrNXEyVGFwZHFUVTR1NFJrU3hnMFR2SEZWUmFVNzlkckxZa0x3?= =?utf-8?B?WWROZnNybThTOTlHWnZMaG9VRGovaTJoaXRlRlYxTjVkSTdhTUNuYUNUOWx5?= =?utf-8?B?RFJXdXpycnRmU0NTNHFjZkpteWZJR3g5enEvSmFHZVJnNnkzRVI0eVVPR3Ey?= =?utf-8?B?a1daTkJJYVg0Ui9tRUxtRXdFMzRUMVV2MHFKS1B6c2VoTWpVQ2VoK1F1T1la?= =?utf-8?B?TnJDeS80YU5NUVZJbVhQdUc3MXF1TTNFTlFWS28wOHBJKzZwSHdRdzhNTVpj?= =?utf-8?B?Rlk1cXdid1NYaG5SazVQbW5ZVmw1RE51MWlZQy9ZVC9ibzUwdUZTTXVqU2dH?= =?utf-8?B?WG1sQVNZQnIrazhWQXpJVnNPMkg3b0xlZStTZ1lpSVhYYVJTQUpGVXVoUTdl?= =?utf-8?B?alVmYkFHWENkTW9Eb1ZzbXlhbEF0TjNlNmZaTHNkYWF0bHd6K3RhNUpOUUtI?= =?utf-8?B?T0xvRVl4NXF6VlB0dW9CQnJvMktnWFB6SXBKRkp0QmV5Y1BPVDlzV3E2V1kx?= =?utf-8?B?a2JPOVlKMlVzSmpHOFhJODFiaVVDeFB2bmpFMlFveXdCTWJ5bFoxMVBrMkZN?= =?utf-8?B?UTAzMGtBcUF3b0phVCs3bzMrajB4cTB5bWtySnQ1RVdsbERPTXhFd0pDZkZo?= =?utf-8?B?cnhobkZrSHR6Vm9FTDJBL3hpenpZTUhQTTI3UlhGc1hTOXNKZGpwekZzUmxS?= =?utf-8?B?enVCZXVYWlFic2s1QW8wSHpQQ2pWR0lEakJib3FrTTdXejl1ZHh4TFhNT01i?= =?utf-8?B?WERTUEE5UWVJb3Jod0F0OFl0TnZsbURmY0lzbnYzMjZYV29teWRHTkJKSkhr?= =?utf-8?B?YnBtbkxScUlYaC9tTkdEK0VFTnI5dnhCWWYyYkJQbU01bVZ6R2hQT0QyZ21i?= =?utf-8?B?U0ZaamptS3BIVkxnZmNOU2gxNzhZUUIzemkvZ0p3MER1Y0FOWmxSd1M3VmE2?= =?utf-8?B?NjBDNVF0RG82RXkxQm1PazJMQWx1NEJEbjJaQnM1NHNHZVE5MWtQZmNYdzls?= =?utf-8?B?NGdndmdkMGhUN1NEQnNoK1l5MDk4dVhuREkwRlFwK3F6VkRtOWtpWHZrbDhv?= =?utf-8?B?dXlPMzlRS2F2aEx3SWdadGxYTU9CdUlwaWF4VEZoMEREbVlPblE2VW9TSEhW?= =?utf-8?B?dVZDWE9vY1RkaE0yV2pxVVFvNTJXbjR5NUFsZzBtWXIvbkh0R3Vvc2crdVAw?= =?utf-8?B?eXpjT1dzYThmeVNJTUZ1anRrR09vN3FtS0hrRUl1ekhtZDd0eCtNdUJPeGtE?= =?utf-8?Q?AiCew+P?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0158;5:e1fqIrtCcuO7ipW4zcyNHocoJIsH0lgVsb78ZOmPolxkPrIBySohzdybLbsQVswnKuLwNR2NwY30ziXvqmNDKI0rDRPE93R8b/piFLjtPvKeeZneOWc1H4X7cIgJPNNUXAIRB3Zq+n51CQQ36bVZpjgbPyEORz3p7CCjp7udCIin8WB7t8FanGfMNB8JnuqsJTLeEO2Mr8gSTAGtGtIE6u7J6Q3laHgDDfncgFg7pMaPaJD8IgdRPjgYH4aZiHGwRc+5VYWYF3T2Wg3Ll65EiydELLQr7PY1FKXw/NEPe261KSArOwdqvQwUg6cTSOPWpJxkbV3vihv3kgM70ar7VuS5yYiUi24gwdQPM/ZfxQf+LN154w93K5r5f5GJkQHVDNA0Bl+TvysCZxr424wuXY6l1Z6Fh9j9e/PnPsrjrwtSi4SnZoNtvsxwp5mKikBwrmo1yyQohqVQWYECULyD1M6OV+oiPKskF9XShQyiIGG4k/LVvKTZMH01umN4wDxZ;24:8uyTh6h+P29P6Sh0QZw46qkeqxyF7jkUbfo7ml5Or7YRNHTqtfR/CB1VOjDvA2HC0zcgLt5cE4AiS0WfLHdYFRm558xWEaQAyw+tp4cGAb4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0158;7:6Z37E0WBiNx57UBGhCTqQvrGGnhg8q4X25Ph2vIxS4nOvBcUa/CX1gTWFKFtSKf+cYxloG0F8jEoEIW6bDUvGBcUxdo3A2SDC2F1/GNdlVOcmTc0uONAHLgAxYcXGVgd2iO4uIovMN+msPVSiPcDY0trr2AIM/2JtZhMxS/BR17MG7dXXUOHI950wRMKdjAsd4Dant2CH+Y/Etgf8b4Abg4HEIzkLSoYdRXZE6AJ933Xgh38iyYXVsF/k3Y13J7JTOFHLDDYnECsUYEBowUJfFlVDolM3oj5DjvL7jAwLvifTuH4SxyhNJ1CZXUAw6smKBRRB1fthqdzqx9jNNe5tWZrf9DWhC6M3kX7XgQJwV8HqomKZxCDb0yri1AvBKFpDCO1rB9lVTF2r/o0qs1/HRvG4QLzUyezgFm3NrTsdeIRopeaWxRJ5i0silidKC3rXwOItddm8rFyru78sbA8zL0k0QjhJYe8NP9X4Jcd36/sxb1nonLf4HWZezAABawWu7B++qKh1V61zrCKkSjfPGn4uihC3SvfcWOGLeCFqWf9c/UZo7z5lGOtFCkF3vK28rD6m7zBYPI1dEdz9TmfMKtL0ZTpJr1W6NK7TSW4+of88HaDTiZ4lyc7lAet1QOKrQ1kR+jFbN6GBzntHoRGjyMHWL/Ns4e6uerhaDYicVvkWRWX0kTaB9z8DI8CxylcTm2P3J/Th46EcRBCKq2/XVhcznKqMV1gZDjPlDB1Te/IZVVeAq6qY/JejRJ0oN1DG3JGa819+/Jowd7l4sn0ePZjiZskBZXzasmYKWouDAo= X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0158;20:rZC4L9TpvneBGxfn/H5lyZiOFJNtv/15xoFpddwMNpCJUK0n1CTlN4e/oTLpZpy3HRVIlprbLbhvia+fwCenQ2H+rVEOHLUDgCkS2uxDc175r8YTxrTTtTe4u6EwgrB7oQXqccg2SuAEKjhrHgEEl2f6TqsCJZ77pCQlGGNhIIjls/tOz/n3/1GnUlzM81D+LbS8+Jb1JF20XE2a+DA1pUqwKJoE5jaqQT1HCZ0o9xS02qAJRwWpZvnKMLwaxajV X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2017 22:22:13.8383 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB0158 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/26/2017 04:17 PM, Tom Lendacky wrote: >> +const struct ccp_vdata ccpv3_platform = { >> + .version = CCP_VERSION(3, 0), >> + .setup = NULL, >> + .perform = &ccp3_actions, >> + .bar = 2, > > Platform devices don't use BARs so should probably delete this (unless > you want to make it more generic and then use this value for the > IORESOURCE_MEM entry). > Yep, we don't need bar for platform device, it was copy paste from existing ccpv3 structure. I will fix it in v3. thanks >> +} >> #endif >> +int ccp_dev_init(struct ccp_device *ccp) >> +{ >> + if (ccp->vdata->setup) >> + ccp->vdata->setup(ccp); >> + >> + ccp->io_regs = ccp->io_map + ccp->vdata->offset; > > This should be before the above call to setup(). > Good catch, actually the second patch takes care of it. But I agree with your feedback, I will make sure that io_regs is set before invoking the setup() in the first patch itself. Thanks Brijesh