From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8FF0C433EF for ; Sat, 16 Apr 2022 02:29:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229951AbiDPCcT (ORCPT ); Fri, 15 Apr 2022 22:32:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229935AbiDPCcP (ORCPT ); Fri, 15 Apr 2022 22:32:15 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F87556742 for ; Fri, 15 Apr 2022 19:29:44 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8FC12B831D5 for ; Sat, 16 Apr 2022 02:29:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 232A0C385A7; Sat, 16 Apr 2022 02:29:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650076182; bh=uUd/Mmr+LuhyFMq1LsPUx9KBDlPY2jN3/XYmm96PzHc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=kKdejRF7VlO3kQkyjktX96UX47hHrzVNgIL/LXmp3ngoBfXC3HxgotFjJNnHqgmlZ k3nLSsdniN2ACPKyFWFUKOwE24IU3fKN8aM/W06LHPWiMY1lmCIECJgskTqB9RwUOU j//fH5jUbQGTnfJpGJUw7mmdKJdgcFHKIOAkojp0ZupHywV23GEAOqbtG5bgxy7TQk AKgTXrcmaVPaTnXflmZnPtOjisMy4eYqdTfAgpE3TZKrqN7A+LK2QE6U/K9MXGAjUP j0chy/yNhQAMH/evjg4zu2KapVcm/MeNXTMPyexv4vOsAq3z8xRKIhAlXp6aooZlFB D5L5L9pmdOyLQ== Message-ID: Date: Sat, 16 Apr 2022 10:29:39 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v2] fs: f2fs: remove WARN_ON in f2fs_is_valid_blkaddr Content-Language: en-US To: Dongliang Mu , Jaegeuk Kim Cc: Dongliang Mu , syzbot+763ae12a2ede1d99d4dc@syzkaller.appspotmail.com, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org References: <20220415131902.55028-1-dzm91@hust.edu.cn> From: Chao Yu In-Reply-To: <20220415131902.55028-1-dzm91@hust.edu.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/4/15 21:19, Dongliang Mu wrote: > From: Dongliang Mu > > Syzbot triggers two WARNs in f2fs_is_valid_blkaddr and > __is_bitmap_valid. For example, in f2fs_is_valid_blkaddr, > if type is DATA_GENERIC_ENHANCE or DATA_GENERIC_ENHANCE_READ, > it invokes WARN_ON if blkaddr is not in the right range. > The call trace is as follows: > > f2fs_get_node_info+0x45f/0x1070 > read_node_page+0x577/0x1190 > __get_node_page.part.0+0x9e/0x10e0 > __get_node_page > f2fs_get_node_page+0x109/0x180 > do_read_inode > f2fs_iget+0x2a5/0x58b0 > f2fs_fill_super+0x3b39/0x7ca0 > > Fix these two WARNs by replacing WARN_ON with dump_stack. > > Reported-by: syzbot+763ae12a2ede1d99d4dc@syzkaller.appspotmail.com > Signed-off-by: Dongliang Mu Reviewed-by: Chao Yu Thanks,