From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99BFE384CF6 for ; Fri, 12 Jun 2026 14:14:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781273651; cv=none; b=tGwnHdAgJaT35/9H2xG19C+f76+3k443O4hIe1am4XqGtvDzlJRFsikPd4mSnp5AsvvwSjQi/wlh5g7nqKVLpEBEE6Vfm4mHJcUGZjUegbHUNUy7Udc4MiWBfeT+JGRUFTw7HECc6r8Op3oKMP0gk3BDtmixHpXu+fOeNCXoqjU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781273651; c=relaxed/simple; bh=vx8DmG5UbqBiDuSam9D1jCMImr/IEBCJFdfijvNQdKk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aBeGTAsxluSuP6sbqWLo9OMKhcJ/wDbU2WSmcd4DQ+MO7FemPvhByUWQmFVo/VUkhZotg++LJKH3UYjQ/coq8n3eWXNmBgSUnFhQl+CMJt+Uv/V8qa4O+gfyGIx/C2Cgbya+RHwY74z5WaRkiYZO/mE59pt39daM6IGl+HOO68I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=En8tTTKU; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="En8tTTKU" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-4602e2a0372so786709f8f.3 for ; Fri, 12 Jun 2026 07:14:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781273648; x=1781878448; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vx8DmG5UbqBiDuSam9D1jCMImr/IEBCJFdfijvNQdKk=; b=En8tTTKUgsgEKsbp4c067InHO3bs7OhMsj9WkHHY2W3zznqnGrfv2c+V/2I5rm5RMi Lx49edctNFLWTUZ4kae5iRxq+APAIJk2h98QfTkeXXcE0Tn6pjJK9zpmCWCZgLuqnQYs 4NC1uloUq4X0+zeHqfUQWANvpAOwfpCJdR5KYywYnY7tZOEAIlz/7htodYb5rQ/riiY9 rUe1WK235zsSxCZVI0l2Oi8LLkXgJKhcwoApeNe/r3O3YZeLtb9Oo+lk9EXIGsZnrvax j4jKazjqvdApeK6D95VRZj72KTo5YQ94KQ8IYxA9T53gEdFkkFzhvcJdsDmUQmpFAIBv h7Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781273648; x=1781878448; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vx8DmG5UbqBiDuSam9D1jCMImr/IEBCJFdfijvNQdKk=; b=s9NNfYE2Ud7O/u3wVkqiLMsJbsurDWLoyEN4UkcMDhSrkqF1B1Dd800qthz8OkYx0r 2JTrEdLhqtf63QArZ+933EkVcVeW/edV2GvCDmG3pb+d9zidpoV5O1kZPs9Dx167hv0i 4eTOdCF8UoEpco16iBqB7vwTWav4/oI1w4xFyGMCdm95azn88UX83ZLNnmZ60Dn3nNc6 KduLKEbPU7ZxhhYkQ0ZhWYztkTGpr2yPW1B5h4Drc9HIN+rHVxCw5Nrj8daiqZKXPJYO LO2JIjhIM43X6WKUfWQMcrsx7u1I/VP6C88F3Fc3f04Yxcs9ZprnAurO3fuz4yKUgz46 AZCA== X-Forwarded-Encrypted: i=1; AFNElJ8cPTqZC79fwuBPQIWXdvfgCPm53l+lAGTZE6Gunfp6ofJthqTqOqwVieZfAoAsApifYWHQKf1jSfvAewk=@vger.kernel.org X-Gm-Message-State: AOJu0Yz4wnqSs4UI8vnq0u2A+HxzchGlrB5PAMEoH7ho3vTGV0loy89f GGfw0wNfdW6azjh+mlH040cnUNX/x9elb6nHkd+WFdkwctTsm7ZjfkWx X-Gm-Gg: Acq92OFD/oFSBwpOUsEShLo1TKll6J+Wcml0GFK+v90Dk/JpVWH9BRkKXeG2vNxfs2S 6VZYbVQfS0mGr/zl3n3dU2eIxidEIOMMpPKAwiZyFanyJfIQP//u6a9So87hKrn4tPNepYOK2MR 84SGUHYmYx6lJRhbIipF9T9CPRsmwMEOgxiwp/7l6j257mJQH/6/kK1mSzh2WmWF7Zyu/DDNG2I nmB2Lyl0TN36ViVV7dRnGgKu5DlSlpawoDPsCm41VOIyFG29uxAnJ19PFnzPEPvzXvFrL+Jl8uD ampn7hI9ivWx1QU0G6pG6MAaba+QNbjITypcvflqLBMaZGxm/Cua/ZO8r/saBWPcpXuTCtvHIKN j9b0/UbL8gTPIKb/JylhfPmUYzi8bm12PRrOkGCLllnd5gQH2qT4q/KYaT3zHYtSumzSUEUAzrG +1rDZdPdzLAFBEXR//0WityyIw0oLMg1OfaBQ1tMQ6K1MCkdOnrKWWx3OBdV+tLlGK8zE//cK6j TuAj5egEZGQL5yqYLoHSv0= X-Received: by 2002:a05:6000:228a:b0:460:1957:1b33 with SMTP id ffacd0b85a97d-4606db96685mr4520852f8f.3.1781273647702; Fri, 12 Jun 2026 07:14:07 -0700 (PDT) Received: from ?IPV6:2001:9e8:f11c:fd01:da7:7547:99a1:b76a? ([2001:9e8:f11c:fd01:da7:7547:99a1:b76a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4606f26392esm6485031f8f.3.2026.06.12.07.14.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Jun 2026 07:14:07 -0700 (PDT) Message-ID: Date: Fri, 12 Jun 2026 16:14:06 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v9 1/3] net: sfp: initialize i2c_block_size at adapter configure time Content-Language: en-US To: Jakub Kicinski Cc: Russell King , Andrew Lunn , Heiner Kallweit , "David S . Miller" , Eric Dumazet , Paolo Abeni , Maxime Chevallier , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?Q?Bj=C3=B8rn_Mork?= , Simon Horman , stable@vger.kernel.org References: <20260528205242.971410-1-jelonek.jonas@gmail.com> <20260528205242.971410-2-jelonek.jonas@gmail.com> <20260603180607.353551af@kernel.org> From: Jonas Jelonek In-Reply-To: <20260603180607.353551af@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Jakub, sorry for the noise. On 04.06.26 03:06, Jakub Kicinski wrote: > In the meantime - AI seems to also be saying something the cap being > potentially off by 1 in patch 2? We add 1 to the len? Maybe I'm > misunderstanding.. > > https://sashiko.dev/#/patchset/20260528205242.971410-2-jelonek.jonas@gmail.com I had another look at that. The concern is theoretically valid, the I2C write path prepends the length byte to the data buffer. This could exceed the limit and would be rejected by I2C core/driver. But this is not a result of my patch, it can also happen without. My patch probably just brought that more into awareness. However, this isn't triggerable right now IMO, thus has no practical impact. In v8 I had a look at in-tree drivers with a potentially problematic constellation of max_read_len and max_write_len [1]. And looking at the SFP code, the biggest write being issued might end up with 3+1 bytes. This doesn't reach any existing driver limit. Given that, I'll send a v10. Best, Jonas [1] https://lore.kernel.org/netdev/4a1b13f4-9c68-4f4c-a676-fd61e2aeeab0@gmail.com/