Re: [PATCH 3/3] arm64: dts: qcom: qcm6490: Introduce the Particle Tachyon

[Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>]

On 9/11/25 1:05 AM, Bjorn Andersson wrote:
> The Particle Tachyon is a single board computer with 5G connectivity
> with AI accelerator, based on the Qualcomm QCM6490 platform.
> 
> Introduce the board, with support for UFS, USB, USB Type-C PD and
> altmode (DisplayPort), GPU, charger/battery status, PCIe shield,
> SD-card, and remoteprocs.
> 
> Signed-off-by: Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>
> ---

[...]

> +	leds {
> +		compatible = "gpio-leds";
> +
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&activity_led_state>;

property-n
property-names

is preferred, file-wide (you currently have a mixture)

[...]

> +
> +&i2c1 {
> +	status = "okay";

This likely results in a "falling back to 100 KHz" warning/notice,
please specify the bus speed explicitly

[...]

> +&mdss_dp_out {
> +	data-lanes = <0 1>;

Is 2 lanes a hw limitation?

[...]

> +&pmk8350_rtc {

I see no reason for RTC not to be enabled by default

[...]

> +&pon_pwrkey {

Same here> +	status = "okay";
> +};


> +&uart7 {
> +	/delete-property/interrupts;

/delete-property/(space)interrupts, please

(yes we desperately need a formatter)

[...]

> +&usb_1_qmpphy {
> +	vdda-phy-supply = <&vreg_l6b_1p2>;
> +	vdda-pll-supply = <&vreg_l1b_0p912>;
> +
> +	orientation-switch;

This is specified in the SoC DTSI

[...]

> +&usb_dp_qmpphy_dp_in {
> +	remote-endpoint = <&mdss_dp_out>;
> +};

And so is this link

> +
> +&usb_dp_qmpphy_out {
> +	remote-endpoint = <&pmic_glink_ss_in>;
> +};
> +
> +&usb_dp_qmpphy_usb_ss_in {
> +	remote-endpoint = <&usb_1_dwc3_ss>;
> +};

And this one

Konrad