From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B7C92C15A5 for ; Fri, 9 Oct 2026 01:07:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791508033; cv=none; b=XuqVG/UwvZH2SpkbDgRDoMMfcenze/ggvKRtWMCmAIqGEj3WD9nuKCQpgpb5nyzyQYtO9Kn5TDpeAhuJ3yHFrIwJ74YjYxuaVSIUY+kR04gMjpTOPVZffeCso7UXyyGG9wCLZEmzjhuMQg1e76+IdOg42ZtFS5167qcL9z3gDw8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791508033; c=relaxed/simple; bh=+zxnZvtNeGJCI7pCdIuW6g2eA8/O+svbTTvlPCXqKk8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=p5krh43UHZMGsPC4Wy7hrVE5Gn4xANO6VaTZ8ZCw+oi5Cvop1OBMw2xzqBPQt4eeK+koJZYL0AD32zjPesMHMkjI1XCdJLoaGHJXH34rmIcPoSfqLiV6KJtWfR1HRKToy8ejsVNobox8QD5OCcE4PPVaPHPu8ShwiRThuxod7d4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PMGxK/nK; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=T9zbul6p; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PMGxK/nK"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="T9zbul6p" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6990PrOr3579054 for ; Fri, 9 Oct 2026 01:07:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= wv5XRzDrzOa11d81nPhympfz8h9JIRXzef2dzjWca7E=; b=PMGxK/nKr79j6k8B Nr9SyWFaowRNIeabOmWzTuVixody79Vtvmi0+ZgmaLygg2K9sEqr3cHep9ZXWbL0 w2XYoL9N4cZIKUn4de5TMIh1W5KLf03/m0OgcBUKMXQg0sKbqvZPEmuXbMzO0LO+ nVfxxUXkBYdX6QqqFr3qjl7Haa6q9H+jIxibJMwaaDy9/LyXo85HaMGS62ySJDUn gtWdUXxU9rVh64gSC9mLRu8yrVH2fXyTBwPaBXpN9WkRrTu11SiDu8DNOUehek/k OFcIvVK+zLP1pxU675bp3+mktldb+y3OiOEJ3v33VtClC65T35BpZ5j64Sa4EapH cyjToQ== Received: from mail-dy1-f197.google.com (mail-dy1-f197.google.com [74.125.82.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4h6fxk19e1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 09 Oct 2026 01:07:11 +0000 (GMT) Received: by mail-dy1-f197.google.com with SMTP id 5a478bee46e88-34e676375d9so5890842eec.0 for ; Thu, 08 Oct 2026 18:07:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1791508031; x=1792112831; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=wv5XRzDrzOa11d81nPhympfz8h9JIRXzef2dzjWca7E=; b=T9zbul6pTaE2pvbiGT7BrNWNkzayD+1/ZVNTxHQoPaL/bBQKNdB8JG4DJvp5RKEAVG hk5uR8HMW3yHZychZvrpuILZF+aNFI2YykqplLEvptI/0KRTEMsz5M83TO9mqiK6owb5 /TI0koH5oRZokcqlHPPLMMBL1i5Xj50/xqMLegyx24BXiTpg3IaiNLRiwtYhGp9nQK3e ITGH4eiVP+j/7q8NyV9c/FcBF3TfXFSycbT7g6rhr3VmEgpaEevm4Ny0zyLqx2PyttfX GyO7k5sxHFbT3/+dLI0C3H0PfJW3nm4rgtz6/rcoxSzg8mBj8rFR2w2Hb1It1a4aT+SG MnOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791508031; x=1792112831; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=wv5XRzDrzOa11d81nPhympfz8h9JIRXzef2dzjWca7E=; b=rwoKMxHz1/idZ8Lu9exi53HAy8PwBe/bwe3R1cWxDP3Lvq4q8OzsfRg1Ov+Gjv/L+A rjtnj1uRNNlpixSvbMA5+RyfAfVyIHAD2ljR8YIBVTAy8j4sGAxRFk9IYqYOiPq3nV+D UNLfO74RM4yfpFbu+fAUyNvDtMBeJhmXxBikFY8xvg+F/v57YdPY/5NX7b/C+cWlwfwW iZrjzb3gGEQdNYFwD9UAZenFHZGL9jLJ8t3By+gyiZ97lwFFSO1OKz7rNGzsdfVQYd4x Y8ZcYY/oYeD+ZypC562AS/CdvSBdQ+DHrQ9NA+/Tr/dlpqvOz7CToPNdwM+J4racnPTF G+kw== X-Forwarded-Encrypted: i=1; AKwUvBza2jdHNIKcFpZeJhgZyw8c1UmRRrwPuP+aSR7bmZcKZD+ivxR5pxxEletqmyBzvBxJU99aQjL4AIRwWPk=@vger.kernel.org X-Gm-Message-State: AFq9FYIDT3mAaHQPNq8cig1aZsOVjGv+XGOu8QGL0z4FLLj9Z7yCmb0D sHCQUelJTODMWxH9A5VTqA9y5KF84mXgl9ub3ZMFLyqzdfGgVjSOHfPJLdhmKB/mn4SmO88u1BA Jsh8uPVTY8sFO0CKyjK9Wox91QlpPQ33QyhOJMou8lyJuFUj6Zje8B9GyfKo7DVwdxO0= X-Gm-Gg: AYBFou2WFHo13XhCS5pxgFWsluoXpwULv2dl0HcG2DO8hgGVwNgxJLI4iZMofvC8hko ckr4eqJW0sL4fi8ObHR8G1BPKBF9bzbGEKryDlylE5vKoUxs5p7nLEIoQsuatvpK3CRAa6nTsrH eStnj7jdEoseZvf2J1FwK/bBFhBjK5a/oayzugmBzk86H/sAMM+dGZEB23IkB34TU6/Q8XCFAPu 5j+XirkRO3NKBcuVEkKiv3nsN79fJcRePgPMkvhsqj/wlmTi4c+yeSFd+uQgwQPRnGB07hqRX6e mYAxQrXhCCUvRnuW4A2NoXumxS7JXC4tgpEdFkSkwcjJM+u0hyaOnsYGwHSaaIFC7IYOCLGlQCc sjBgRnt2yQebw6Vhd0inzYuP+xxqk1fqfCJS6pCHjryBZOIz6SzmY X-Received: by 2002:a05:7300:c8c5:b0:34c:6edc:f4d with SMTP id 5a478bee46e88-3537de061f1mr790417eec.1.1791508030278; Thu, 08 Oct 2026 18:07:10 -0700 (PDT) X-Received: by 2002:a05:7300:c8c5:b0:34c:6edc:f4d with SMTP id 5a478bee46e88-3537de061f1mr790363eec.1.1791508029119; Thu, 08 Oct 2026 18:07:09 -0700 (PDT) Received: from [10.73.232.100] (pat_11.qualcomm.com. [192.35.156.11]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3537cb1e05esm1795163eec.25.2026.10.08.18.07.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Oct 2026 18:07:08 -0700 (PDT) Message-ID: Date: Thu, 8 Oct 2026 18:07:07 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] watchdog: gunyah: report system sleep operation failures To: Zhang Jiaxi , Wim Van Sebroeck , Guenter Roeck Cc: Bjorn Andersson , Konrad Dybcio , "linux-arm-msm@vger.kernel.org" , "linux-watchdog@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: Content-Language: en-US From: Trilok Soni In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=fKesTpae c=1 sm=1 tr=0 ts=6ac83e3f cx=c_pps a=Uww141gWH0fZj/3QKPojxA==:117 a=ZdW6uxA9NKXbfdqeeS2OGA==:17 a=cNoKYFeJyS4W4/1HdvzxLidmn8o=:19 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=UqCG9HQmAAAA:8 a=wiQ79f7mt1jt9let52sA:9 a=QEXdDO2ut3YA:10 a=PxkB5W3o20Ba91AHUih5:22 X-Proofpoint-GUID: eeprSumIDTU9wQZPLcHRVRp6rCYmAoLx X-Proofpoint-Spam-Info: AW1haW4tMjYxMDA5MDAwNCBTYWx0ZWRfXyyAtidp4DzlE /K2Nj0Qm9qTJVfEZGqQZOZaOKYsZ8Ne/UvIkx85tbTMfm9iJj1/rE1gZR+j5YsI4ZqmpWjdFeXk 8pwCNGTUETtdBJZRiEObcPchaNEmhyw= X-Proofpoint-ORIG-GUID: eeprSumIDTU9wQZPLcHRVRp6rCYmAoLx X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDA5MDAwNCBTYWx0ZWRfX+FqsKJa5cbUw K7hhxHI8EDEJjmLPALHyWPpzRM9AIKlabKKzSeXrPi/Ty9lLHtldr0m1Z1mhAurPanU6TWjLRmD H5kTgBnELlHHIVOjt+iL+SdIhKH4OCjgxsXkAWH4kQmwF2l9t2LIRNjU69A0FqFlLYKsH/V8Reo N3BW/jCpV2K0S91g+Y0MmRLHzHN/ILSh/xekYQHNm1nf6IDJRScFSkRBT9kROBaKWaymEpmNlbB WkDDMM0eLoEjkCliom63D9Wg2r1WBYPWZ0dOnn4OUarPrF0l6uo5quhaa0KwNvLmvrB+XzztbB/ iAJRAnOb4nwLjhtUo6dZkWMkyMIOHyNtkYVOJ7mzoxc8p0hXFajDeqQtk2qPtW+msh2SGCSMZcS UGV2F15JklsQd2OQxAvc1dWmpC/HRMsozkkM3fmgbe2WOQcP9AcqWc2HWumHSUuW4NxE81uhpec q1kPgiZo9eGedo76dPA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-09_01,2026-10-08_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 clxscore=1011 suspectscore=0 adultscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 lowpriorityscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610020000 definitions=main-2610090004 On 10/8/2026 3:34 PM, Zhang Jiaxi wrote: > From: Jiaxi Zhang > > The system-sleep callbacks discard the errors returned by the watchdog > start and stop operations and always report success. If stopping an > active watchdog fails, the PM core can proceed to suspend while the > watchdog is still counting. Failed restart on resume is also hidden from > the PM core's callback error reporting. > > Return the existing operation result when the watchdog is active. Keep > inactive callbacks as no-ops. The start/stop command sequence, initial > activation exception, probe registration and last-resort restart behavior > are unchanged. Reporting a resume error does not implement recovery or > guarantee that watchdog protection has been restored. > > Signed-off-by: Jiaxi Zhang I see flurry of emails from you. What exactly are you testing here? Is this driven through LLM? Please also fix your SOB line. > --- > Clang 22.1.8 compiled the changed object on torvalds/linux > 6c377d19d4a5116d9bec5203aa3c6c11523e7898 without diagnostics. > Actual callback tests with modeled start/stop returns cover error propagation > and inactive no-ops, including old-code negatives. No device PM or real > hypervisor-error injection is claimed. > > drivers/watchdog/gunyah_wdt.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/watchdog/gunyah_wdt.c b/drivers/watchdog/gunyah_wdt.c > --- a/drivers/watchdog/gunyah_wdt.c > +++ b/drivers/watchdog/gunyah_wdt.c > @@ -214,7 +214,7 @@ > struct watchdog_device *wdd = dev_get_drvdata(dev); > > if (watchdog_active(wdd)) > - gunyah_wdt_stop(wdd); > + return gunyah_wdt_stop(wdd); > > return 0; > } > @@ -224,7 +224,7 @@ > struct watchdog_device *wdd = dev_get_drvdata(dev); > > if (watchdog_active(wdd)) > - gunyah_wdt_start(wdd); > + return gunyah_wdt_start(wdd); > > return 0; > } >