From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 137F0EB64DD for ; Thu, 20 Jul 2023 12:43:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231334AbjGTMnl (ORCPT ); Thu, 20 Jul 2023 08:43:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231190AbjGTMnj (ORCPT ); Thu, 20 Jul 2023 08:43:39 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4A802135 for ; Thu, 20 Jul 2023 05:43:37 -0700 (PDT) Received: from kwepemm600004.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4R6C2Q2gHMzNmWD; Thu, 20 Jul 2023 20:40:14 +0800 (CST) Received: from [10.67.103.231] (10.67.103.231) by kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 20 Jul 2023 20:43:34 +0800 Message-ID: Date: Thu, 20 Jul 2023 20:43:33 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v3 0/2] soc: hisilicon: Support HCCS driver on Kunpeng SoC To: , , CC: , , , , , References: <20230424073020.4039-1-lihuisong@huawei.com> <20230530112746.2767-1-lihuisong@huawei.com> From: "lihuisong (C)" In-Reply-To: <20230530112746.2767-1-lihuisong@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.231] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemm600004.china.huawei.com (7.193.23.242) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi All, Now I add HiSilicon SOC maintainer Wei Xu attributing to Krzysztof's reminder. Thanks for your review. All comments have been closed. Could you please kindly confirm my modifications for your comments? If it is ok for you. In order to go on smoothly, can you reply?😁 Best regards, Huisong 在 2023/5/30 19:27, Huisong Li 写道: > This series add HCCS driver to query the health status and port information > of HCCS on Kunpeng SoC as well as document all sysfs entries provided by > this driver. > > --- > v3: > - replace "using_status" with "enable" attribute. > - fix some comments in codes. > > --- > v2: > - Document all sysfs entries provided by driver. > - drop 'pcc_type' and 'intr_mode' in struct hccs_dev. > - using _CRS with PCC GAS to get channel ID instead of _DSD. > - replace readw_relaxed_poll_timeout with readw_poll_timeout. > - use sysfs_emit() instead of sprintf(). > - drop ACPI_PTR in hccs_driver. > - drop useless log during the probe phase. > > Huisong Li (2): > soc: hisilicon: Support HCCS driver on Kunpeng SoC > doc: soc: hisilicon: Add Kunpeng HCCS driver documentation > > .../sysfs-devices-platform-kunpeng_hccs | 76 + > MAINTAINERS | 7 + > drivers/soc/Kconfig | 1 + > drivers/soc/Makefile | 1 + > drivers/soc/hisilicon/Kconfig | 19 + > drivers/soc/hisilicon/Makefile | 2 + > drivers/soc/hisilicon/kunpeng_hccs.c | 1288 +++++++++++++++++ > drivers/soc/hisilicon/kunpeng_hccs.h | 196 +++ > 8 files changed, 1590 insertions(+) > create mode 100644 Documentation/ABI/testing/sysfs-devices-platform-kunpeng_hccs > create mode 100644 drivers/soc/hisilicon/Kconfig > create mode 100644 drivers/soc/hisilicon/Makefile > create mode 100644 drivers/soc/hisilicon/kunpeng_hccs.c > create mode 100644 drivers/soc/hisilicon/kunpeng_hccs.h >