From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751330AbdK0G17 (ORCPT ); Mon, 27 Nov 2017 01:27:59 -0500 Received: from ale.deltatee.com ([207.54.116.67]:53714 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751096AbdK0G16 (ORCPT ); Mon, 27 Nov 2017 01:27:58 -0500 To: Julia Lawall Cc: Joe Perches , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Andy Whitcroft References: <20171126054037.9743-1-logang@deltatee.com> <1511676085.20482.18.camel@perches.com> <5c0a2778-8e8f-9fbb-b13f-1d880acb949b@deltatee.com> <1511735382.20482.27.camel@perches.com> <355029d1-48f5-095e-0d99-bb726d2d56e5@deltatee.com> From: Logan Gunthorpe Message-ID: Date: Sun, 26 Nov 2017 23:27:54 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-CA Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 68.147.191.165 X-SA-Exim-Rcpt-To: apw@canonical.com, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, joe@perches.com, julia.lawall@lip6.fr X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/11/17 11:11 PM, Julia Lawall wrote: > I don't have a different warning if the string ends in a space. I have a > different warning when one possible control-flow path is fine and another > control-flow path is not. The space thing relates to guessing whether > some other printing API function needs a newline or not. Understood. For checkpatch, there only is warnings (of various types) and I was referring to the guessing you mentioned. So if we see that a call has no new line and the following one isn't a KERN_CONT, then based on whether there's a space or not we potentially could have one of two warnings: WARNING: Log messages should end in a new line (\n) or WARNING: Given that your log message ends in a space and not a new line, did you maybe mean to put a KERN_CONT or pr_cont somewhere in there?? By the way, though, KERN_CONT use is discouraged and will create its own warning when you fix it. Logan