From: Alistair <alistair@alistair23.me>
To: "Axel Lin" <axel.lin@ingics.com>, "Mark Brown" <broonie@kernel.org>
Cc: "Lars Ivar Miljeteig" <lars.ivar.miljeteig@remarkable.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] regulator: sy7636a: Use rdev_get_drvdata at proper place
Date: Wed, 16 Jun 2021 18:33:39 +1000 [thread overview]
Message-ID: <ec3af3d1-204b-4dbb-8c36-a33764c798e8@www.fastmail.com> (raw)
In-Reply-To: <20210616034458.3499522-3-axel.lin@ingics.com>
On Wed, Jun 16, 2021, at 1:44 PM, Axel Lin wrote:
> At the context with *rdev, use rdev_get_drvdata() is more intuitive.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Reviewed-by: Alistair Francis <alistair@alistair23.me>
> ---
> drivers/regulator/sy7636a-regulator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/sy7636a-regulator.c b/drivers/regulator/sy7636a-regulator.c
> index c71c0a007d95..e021ae08cbaa 100644
> --- a/drivers/regulator/sy7636a-regulator.c
> +++ b/drivers/regulator/sy7636a-regulator.c
> @@ -35,7 +35,7 @@ static int sy7636a_get_vcom_voltage_op(struct regulator_dev *rdev)
>
> static int sy7636a_get_status(struct regulator_dev *rdev)
> {
> - struct sy7636a *sy7636a = dev_get_drvdata(rdev->dev.parent);
> + struct sy7636a *sy7636a = rdev_get_drvdata(rdev);
> int ret = 0;
>
> ret = gpiod_get_value_cansleep(sy7636a->pgood_gpio);
> --
> 2.25.1
>
>
next prev parent reply other threads:[~2021-06-16 8:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 3:44 [PATCH 1/3] regulator: sy7636a: Add terminating entry for platform_device_id table Axel Lin
2021-06-16 3:44 ` [PATCH 2/3] regulator: sy7636a: Make regulator_desc static const Axel Lin
2021-06-16 8:21 ` Alistair
2021-06-16 3:44 ` [PATCH 3/3] regulator: sy7636a: Use rdev_get_drvdata at proper place Axel Lin
2021-06-16 8:33 ` Alistair [this message]
2021-06-16 8:21 ` [PATCH 1/3] regulator: sy7636a: Add terminating entry for platform_device_id table Alistair
2021-06-16 16:41 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec3af3d1-204b-4dbb-8c36-a33764c798e8@www.fastmail.com \
--to=alistair@alistair23.me \
--cc=axel.lin@ingics.com \
--cc=broonie@kernel.org \
--cc=lars.ivar.miljeteig@remarkable.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®