From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx01.omp.ru (mx01.omp.ru [90.154.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6CF720F1; Tue, 23 Jan 2024 20:43:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.154.21.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706042596; cv=none; b=bJiU7xcisTw90cGDq8Ai2A8+BSE9dKplaX3JOBLpj9++L/PRTaY9+vTjmhkNNRp0yVzJsrLnpJwNKfYy0STSy/JXxu0fhRAhqWkQQtoFRYHqmhbjNTRAjMIc6u5aoS8Pc1n3qRk42KqYb/ZAeAa94f+Lq/jKyNlmhCr2CLUQwE0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706042596; c=relaxed/simple; bh=EEncKghprTOWMaCnJRfayS7I/j2ad9+aypBZ5XxEPbQ=; h=Subject:To:CC:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=JJeLRpdFHEtMBFrBK7UsxXPpv5gvo25gzz2R4bx6B6Zn/8Nd+l7CrYy4x5R4grAumW6xpHAt+R2NiobihRsdQMOhmFXIkmv0wFl5u87BLWTf+XjNrwjTqfD3kJEmrMSzPyLP/JPKtZOmpnVXJZo27EqBudIta88mrDhWA2RgL/g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru; spf=pass smtp.mailfrom=omp.ru; arc=none smtp.client-ip=90.154.21.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=omp.ru Received: from [192.168.1.105] (31.173.84.3) by msexch01.omp.ru (10.188.4.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.1258.12; Tue, 23 Jan 2024 23:43:03 +0300 Subject: Re: [PATCH net-next v4 07/15] net: ravb: Move reference clock enable/disable on runtime PM APIs To: Claudiu , , , , , , , CC: , , , Claudiu Beznea References: <20240123125829.3970325-1-claudiu.beznea.uj@bp.renesas.com> <20240123125829.3970325-8-claudiu.beznea.uj@bp.renesas.com> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: Date: Tue, 23 Jan 2024 23:43:02 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20240123125829.3970325-8-claudiu.beznea.uj@bp.renesas.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: msexch01.omp.ru (10.188.4.12) To msexch01.omp.ru (10.188.4.12) X-KSE-ServerInfo: msexch01.omp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 6.1.0, Database issued on: 01/23/2024 20:31:10 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 59 X-KSE-AntiSpam-Info: Lua profiles 182874 [Jan 23 2024] X-KSE-AntiSpam-Info: Version: 6.1.0.3 X-KSE-AntiSpam-Info: Envelope from: s.shtylyov@omp.ru X-KSE-AntiSpam-Info: LuaCore: 7 0.3.7 6d6bf5bd8eea7373134f756a2fd73e9456bb7d1a X-KSE-AntiSpam-Info: {rep_avail} X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: {relay has no DNS name} X-KSE-AntiSpam-Info: {SMTP from is not routable} X-KSE-AntiSpam-Info: {Found in DNSBL: 31.173.84.3 in (user) dbl.spamhaus.org} X-KSE-AntiSpam-Info: omp.ru:7.1.1;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;127.0.0.199:7.1.2 X-KSE-AntiSpam-Info: ApMailHostAddress: 31.173.84.3 X-KSE-AntiSpam-Info: {DNS response errors} X-KSE-AntiSpam-Info: Rate: 59 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dmarc=temperror header.from=omp.ru;spf=temperror smtp.mailfrom=omp.ru;dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 01/23/2024 20:34:00 X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 1/23/2024 5:23:00 PM X-KSE-Attachment-Filter-Triggered-Rules: Clean X-KSE-Attachment-Filter-Triggered-Filters: Clean X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit On 1/23/24 3:58 PM, Claudiu wrote: > From: Claudiu Beznea > > Reference clock could be or not part of the power domain. If it is part of Could be or not be, perhaps? > the power domain, the power domain takes care of propertly setting it. In Properly. :-) > case it is not part of the power domain and full runtime PM support is > available in driver the clock will not be propertly disabled/enabled at > runtime. For this, keep the prepare/unprepare operations in the driver's > probe()/remove() functions and move the enable/disable in runtime PM > functions. > > Along with it, the other clock request operations were moved close to > reference clock request and prepare to have all the clock requests > specific code grouped together. > > Signed-off-by: Claudiu Beznea [...] > diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c > index 9fc0e39e33c2..4673cc2faec0 100644 > --- a/drivers/net/ethernet/renesas/ravb_main.c > +++ b/drivers/net/ethernet/renesas/ravb_main.c [...] > @@ -3060,21 +3058,27 @@ static int ravb_resume(struct device *dev) > return ret; > } > > -static int ravb_runtime_nop(struct device *dev) > +static int ravb_runtime_suspend(struct device *dev) > { > - /* Runtime PM callback shared between ->runtime_suspend() > - * and ->runtime_resume(). Simply returns success. > - * > - * This driver re-initializes all registers after > - * pm_runtime_get_sync() anyway so there is no need > - * to save and restore registers here. > - */ I want to pull out the dummy {ravb|sh_eth}_runtime_nop() funcs -- they don't seem to be necessary... Then we can implement your clock dance with freshly added ravb_runtime_{suspend|resume}()... [...] MBR, Sergey