From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A703E3A16AA for ; Tue, 14 Jul 2026 15:34:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784043266; cv=none; b=ZZSSGXUMPlDvReBrRz7nsfsMl7SHcAqKdsedQ7++RYPmv47FhOb3EaKS715dpirDY5LpRKvYauupzGVAaLMoiGlXSLrIa0QFefNymgeDQoANGWI6HF0dCvESKlXin/R7OVA8H6FFREb0KJeP1dYbjnlgY095Hn3IXjJH393af4E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784043266; c=relaxed/simple; bh=0r0JNOoHNbWlCuhfm9OucnKnlLuGPVOqCDsXMshhENo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IEGbC1FtEenJBnG6gl52r016svDgC5RR51JpqwBkelgNoDOjJYbbsRyRQShG28GXXh1AjttZRVvMs62CnPrJ6JFiLyBryUL67b56Cgo7DjLl/W5OmSLy4DEvo9fgwCkfOQOph2/ZpsFjEHscF1t0DE2eu3lR5MRx0M4w6ojex24= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SSF8tryj; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WJBI5x/t; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SSF8tryj"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WJBI5x/t" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66EEcNV5938579 for ; Tue, 14 Jul 2026 15:34:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= zGpsLT9I5vT3mdvWKpIvDp+nCgXQYoSoxh3a19izebI=; b=SSF8tryjkwNsNHT9 AvLvTW/kq2G9Nogm8hgny+FvxnXjygS8UdCUzfwVlVWV3gu2cGzV/pC/r+m8wJGR mtjs9qPoVpuWymGecs6xTTznOqaVUvr/cy5eSW3YOiyBlgccqnvHfk/wTDL8qhps C1oc/dIHdWOmZ2AOwZy1PBXUsIe1Ab6hFryzwkqJdZaRY1sZCmoop+lifHlXGyxn LqYhrm9a6aLTlaikQaohYeyQqxZqLyVf1y7o58A8eCg4Hlys9YYyb4zrtsagkDN7 f3Isz3StRIg8bd3sGZMrlMvjTytMvs5LiTM5MRVMKGucesQMZd25Nd/bE5j9wPpj BOULKA== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fdnnurmx9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 14 Jul 2026 15:34:24 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-cb11535e6a1so1052397a12.0 for ; Tue, 14 Jul 2026 08:34:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784043264; x=1784648064; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=zGpsLT9I5vT3mdvWKpIvDp+nCgXQYoSoxh3a19izebI=; b=WJBI5x/tAQ6XOaJncBQnDzLikSi/BQ8BVG1BnwCB+yY11v1rBccAPlHcucwVL8m2VS sAfbEtM5R0+XizcI6p7V2hyOOXvurje4ffesH9+R0Vtbql1YRyBlaPkZ2VocAA1vhZmU 7ENWQUIuSQCAWyb+oXExXVeeHL3nbzSH5SOe9ozgS6XZwJoiOd4M78j49gRDyn96+HWT 2HLgVra+DEth8kye2vOUrXMwTSzsOIwshGN1uA8m4w07J0WzQ7X4aDZPe7Mz5K0Amizq UvAprJjXobOzzaWTVwOHK+CFNs7zrDl+75vcm+/3TZvyYu/qyp9pT7XYul3L/eT5r8SA qqQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784043264; x=1784648064; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=zGpsLT9I5vT3mdvWKpIvDp+nCgXQYoSoxh3a19izebI=; b=T3lBHVLc54KJUxgYsCJ3b9Rx3nq8r4p2NLLbsAzbLH04Kfkfnf82+9IbIEYnBPSweJ 05KmpG8F2Jtw3YcJKbjLgBJ6dio+r3nw0pDJcIf+amDQwQuV2QjJvGGbfzIaiOD2z+dd ssLOwvm2rIrQrZ4aNP29x9tRrHtsKTjC13BBNR/FFHUohrV+bQv2EIale4n7/uNYE5sN FVKHXOSbmR5IPql6ckJP+KNFL5tgWe3pC+CYWXdu42skWAWStgoQPjTImStaE669vcPP S3O/rS76P3EeEd9Xv4/M3mSx18faPwOZXK/14/w653KCPTm3EFzDWWDVTWhjipsIg3c+ b68A== X-Forwarded-Encrypted: i=1; AHgh+RpzU8/BXzV0+sPVrPqLQDjgUGqerybilL9SIt+NbW1DOdvMjyILlivObRPuU+YhQcBYSMR5sHARlQNBuAI=@vger.kernel.org X-Gm-Message-State: AOJu0YyyAVn7hKIal4JUXxWc/IbnxxMXHXevu85z6obDQhrisgSJlxdr YlY0MsZFQ0fm0i+LgzoapsrUBQPC+KmG0qblFz6/Vvw5Tqztdi7M4uX83gtzTICz/fUgYcIAoQ0 eqcuYAjJuwVyVStY6ErQNTSCOxi4aPLXMt/p7AiXpoczYg2oX4WmWikAC+JVPnlfL65E= X-Gm-Gg: AfdE7ckZIX91ZAEpXJUeB/7SgiVB+FvHKNjnT9PtYa0z6yJffCrZHMPaio8r+DSe+UV TAuaAeNcijqtq/RFpnd2uoyEvAvTzkoqmOiS7I4R3KXmcy3mOhtRzwJ/bWibXTb5vzOljbi2dTi O7cs22NzptvOEYYN1ft6wKJuiAxmn/9vrm3Qsb2bYHgWaBNo1j5i3VHXlkZ3gaOSEITrxNS6Ly7 VWqhNyCBdw9QMq1LDUSterenKf+l1M6Vnt2+l0yOtKPLPirzKV7hhVsLg49wrrvAJWR0us9VZZv CQQ4H32yRYv3B+iu+JV4XbKfhQkILYUJ2M06ZL86FVjYcxX4JqFHU9Irq6GiXHIOkBTcI7Fc/Jc EoyGZZMNCqLFbPUgJYTCwfiQvzNNVAc+/Tp06XYwRIA== X-Received: by 2002:a05:6a21:b8d:b0:3c0:9c19:659a with SMTP id adf61e73a8af0-3c110b7b9f2mr15857532637.66.1784043264027; Tue, 14 Jul 2026 08:34:24 -0700 (PDT) X-Received: by 2002:a05:6a21:b8d:b0:3c0:9c19:659a with SMTP id adf61e73a8af0-3c110b7b9f2mr15857483637.66.1784043263511; Tue, 14 Jul 2026 08:34:23 -0700 (PDT) Received: from [192.168.0.5] ([49.204.105.43]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3118ee6091dsm98267315eec.14.2026.07.14.08.34.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jul 2026 08:34:22 -0700 (PDT) Message-ID: Date: Tue, 14 Jul 2026 21:04:17 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] spi: qcom-geni: add GENI SE registers trace event on error paths To: Mark Brown Cc: Bjorn Andersson , Konrad Dybcio , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Mukesh Kumar Savaliya , Konrad Dybcio References: <20260711-add-tracepoints-for-se-reg-dump-v2-0-ca1e9ba62359@oss.qualcomm.com> <20260711-add-tracepoints-for-se-reg-dump-v2-2-ca1e9ba62359@oss.qualcomm.com> Content-Language: en-US From: Praveen Talari In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: swU8Lvw3LYpdjHRsPAie8z9pUaAED_DK X-Authority-Analysis: v=2.4 cv=E+v9Y6dl c=1 sm=1 tr=0 ts=6a565700 cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=Ua2K4HyBCek8nw/sr3ra2Q==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=o-iBtrM1MSidxli5CHcA:9 a=QEXdDO2ut3YA:10 a=O8hF6Hzn-FEA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE0MDE2MiBTYWx0ZWRfX7MbECgqSSCE9 2PCF7HGXqtZPbNrkGubuxJEl+HmxTOMt7+6YoYsaBQG3g9buhpXgi/GVDYRhIak3MKEEqoHayby rvv1jM3m9EDaQk/B7aYELYsAR5zIPNbR8YD66xg9rKvFZLOCjW78wr9LTscJARYk838jLqdVViu IqoWfZ+jgVo1z4llerVjcGi5FrN+DmheDkLFsYHebpKjJ19OUsDnfLVZBSWak5Fc2/v6RSAGU7g e1YkwHJ763wWudBHwy7yHq52Eg/b5+f3H0jjq7CBtfHKVkJEELJOLM5sMjzWE/kMeRnFJGYCONi SUM5KUtOl4A8Xkxu5x/clBOEGkD5Bv9vrCuYFt5lV/po1asLEAWhsaecZ2s+QgwV9eUeJmdXGce zItmfJ0GnEbpLzPTZq6e8+zWNZDV80AdhsbMXzvfK4I71F6+pkx9ZSUTORchRqkCYI9n7yPIQbw IJ3KVyOkQg1J/aQLAIw== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE0MDE2MiBTYWx0ZWRfXzCZE0Q1JJ/PM CvRNyOm9St28gO7OogD0VPFx0biq67m1bNQyIVt7EqXZkYP1q2JSQFoKS+uNTbe5w3kxgDjBsAo N0qwj2ZWJ/OnNbzsnRaXTFRGZY6RvQ0= X-Proofpoint-GUID: swU8Lvw3LYpdjHRsPAie8z9pUaAED_DK X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-14_03,2026-07-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 spamscore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 clxscore=1015 bulkscore=0 phishscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607140162 Hi Mark, On 11-07-2026 02:56, Mark Brown wrote: > On Sat, Jul 11, 2026 at 12:18:42AM +0530, Praveen Talari wrote: > >> The GENI SPI driver reports various transfer failures such as command >> timeouts, DMA reset timeouts, DMA transaction errors, and unexpected >> interrupt conditions. However, diagnosing the root cause of these >> failures is difficult as the hardware state is not captured when the >> error occurs. >> +#include > Should this be in rivers/soc/qcom/qcom-geni-se.c (and the first patch?) > - that way if another driver starts using them we won't multiply define > the tracepoints. > >> @@ -986,10 +997,13 @@ static irqreturn_t geni_spi_isr(int irq, void *data) >> writel(0, se->base + SE_GENI_TX_WATERMARK_REG); >> dev_err(mas->dev, "Premature done. tx_rem = %d bpw%d\n", >> mas->tx_rem_bytes, mas->cur_bits_per_word); >> + trace_geni_se_regs(se); > SE_GENI_TX_WATERMARK_REG is one of the registers in the tracepoint, > perhaps trace before we write to clear it? I got you now. Yes you are correct, its better trace before clearing it. Will update in next patch. Thanks, Praveen Talari