From: Guenter Roeck <linux@roeck-us.net>
To: Conor Dooley <conor@kernel.org>, carl.lee@amd.com
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Charles Hsu <ythsu0511@gmail.com>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, peter.shen@amd.com,
colin.huang2@amd.com
Subject: Re: [PATCH] dt-bindings: hwmon: pmbus: mpq8785: add MPQ8786 support
Date: Wed, 4 Feb 2026 10:12:07 -0800 [thread overview]
Message-ID: <ec538467-9068-4ad5-b788-e60f593253be@roeck-us.net> (raw)
In-Reply-To: <20260204-sanction-lunacy-903e96c447e4@spud>
On 2/4/26 09:52, Conor Dooley wrote:
> On Tue, Feb 03, 2026 at 04:15:18PM +0800, Carl Lee via B4 Relay wrote:
>> From: Carl Lee <carl.lee@amd.com>
>>
>> Add device type support for MPQ8786
>
> This doesn't seem very helpful on it's own, where's the corresponding
> driver change?
>
For whatever reason not sent as series.
https://patchwork.kernel.org/project/linux-hwmon/patch/20260203-hwmon-pmbus-mpq8785-add-support-for-mpq8786-v1-1-9ff8c7c50242@amd.com/
Guenter
>>
>> Signed-off-by: Carl Lee <carl.lee@amd.com>
>> ---
>> Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
>> index 90970a0433e9..aec7397a29f9 100644
>> --- a/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
>> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
>> @@ -19,6 +19,7 @@ properties:
>> - mps,mpm3695-25
>> - mps,mpm82504
>> - mps,mpq8785
>> + - mps,mpq8786
>>
>> reg:
>> maxItems: 1
>> @@ -52,7 +53,9 @@ allOf:
>> - if:
>> properties:
>> compatible:
>> - const: mps,mpq8785
>> + enum:
>> + - mps,mpq8785
>> + - mps,mpq8786
>> then:
>> properties:
>> mps,vout-fb-divider-ratio-permille:
>>
>> ---
>> base-commit: 4c87cdd0328495759f6e9f9f4e1e53ef8032a76f
>> change-id: 20260203-dt-bindings-hwmon-pmbus-mpq8785-add-mpq8786-support-f48049e8411e
>>
>> Best regards,
>> --
>> Carl Lee <carl.lee@amd.com>
>>
>>
next prev parent reply other threads:[~2026-02-04 19:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-03 8:15 Carl Lee via B4 Relay
2026-02-04 17:52 ` Conor Dooley
2026-02-04 18:12 ` Guenter Roeck [this message]
2026-02-05 3:32 ` Lee, Carl
2026-02-05 5:30 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec538467-9068-4ad5-b788-e60f593253be@roeck-us.net \
--to=linux@roeck-us.net \
--cc=carl.lee@amd.com \
--cc=colin.huang2@amd.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.shen@amd.com \
--cc=robh@kernel.org \
--cc=ythsu0511@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®