From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EFA71A3179 for ; Tue, 18 Nov 2025 04:48:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763441335; cv=none; b=uE/bMbGchArs32+/kLhB32/rMzaGBJeHgzZt7RdV6u1vLw/YLNRw2V9ie/gL7muXzwhLpwmobcoA0+V5RtmTtdYyfjnwWeL/QgNn3NyIpyhVGrNomq+e4l4h/ln7exp1SwnevenOoZbmQXgwNOM7OXHWGl41oN0fh/T3uN0ipIk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763441335; c=relaxed/simple; bh=iIFQHjofGlzBMdAV/7VJaucvzmg9LLWDEE3IRoLoW2k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=H3aihjbLtTJY2PqpEZ+XaxD14ksZX5n8/Jt+Bsp7bxBC2/EbWPWNwT875D6Dn2mMBBX1h0HGV0UaIJJPofmXHIp+3lBfKWLj+TqYLQHBxLddRsKhlTPyGn1CbK/z4A8m58UXP4cWlQvNkt/nJHjaqZRz6qAU6vmacAppocZpiXg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OfFQJBsx; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GN9xW2eb; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OfFQJBsx"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GN9xW2eb" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AI318vE375643 for ; Tue, 18 Nov 2025 04:48:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6EWfBA1U81NlKI70VVXPQFaenMKF6YCLlfEM2N9rP5c=; b=OfFQJBsxtXWvNmGr bYHHE9YmuzTjkQY0CIR25Q/Zy2aJ0qt33pJ3wAlmInz49rKGqzi2uEsU2ctAEgmq E1VCOyy4RXKHiOjdqFOfD5XNA45zSpk0+V5HOOZ/JCgVci6bHdhn92nPL8uhymrx xS86LYLy6HYyZ5hsj/JqVv9GB2KBSQpEUXEKrAxRsqA+eGTVLU3nGMoBdRD5+m5q 6PPsDI9W3eUqbGssB++7sjEKrXJMwwZjNR1h0FgOdWPZSF9saoUZWWwXPzTe+1AY vrRyR/sxTXh/4ScRVPSbHLDE97gKvbLuYU1m9HVxLXHQgoTpkzmSDaiZtNxNtaAO SqcInA== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ag76nhtcq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 18 Nov 2025 04:48:53 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-340bb1bf12aso12640095a91.1 for ; Mon, 17 Nov 2025 20:48:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763441332; x=1764046132; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6EWfBA1U81NlKI70VVXPQFaenMKF6YCLlfEM2N9rP5c=; b=GN9xW2ebfYI3fohtCLDFnDeed9jcf3A5K8UkeSIeCjyk2Eby1TRU4pjm0C/woID5m1 /px0GAfLrUQ+jOs9Xd3wfJK6ZG7IybzkQiM72znhdoENtyGdhRM0TmC9XpaKuSDPznPN aQSGCIwBgrIf9GZWGZpocPNmJD16A+/U5YIwFOgot2n7cT8poUsu26cj2NMZikBk2krP /f5iAHloXmao0Awix7lN9pKoP0NT47XP6VzLmHuYm9AUA4h6a/IDoVOQADAJ6rHH82LE CVZ1P7Pto1Pdu9HYFv1IPrzZXdzSROyDkNuD87hrEcdB8I0K3HQstub+t7PCymLwqOfj JYUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763441332; x=1764046132; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6EWfBA1U81NlKI70VVXPQFaenMKF6YCLlfEM2N9rP5c=; b=mqieWltxylBXfM/Ri9sYbpAmOuYOzJMEHILQXuvoFSscySNXEfXfF9kn6H+HcovC0C VqYnr65Gs/04Si/gm3MMaejCaohyIH3AczVskyYnPUmragpwR46+5SlLjPeZK7co8cwO V6VR2JjIe5hCApN94M6FsK9KHmCIStXLVGrQJMjFn7cYtFJnjk1LjcQZuAa+tOhcrVxZ FhjUW1Wx6KwLUhEioTpfde1d39GavfcVhLrBazItHu5eHhaGWhON63EfmHORbj4ywtfz b+ibP9AJvxqC/m7Yb0GWTBQWpzNLEnx9cBJ4YL9dwejJHZvjIJ/wSHKPUO7rR19Cc4Fp rxHQ== X-Forwarded-Encrypted: i=1; AJvYcCXoRbaB+g6Tknt1ywYGydJo6GmIpkfXirBldojHHqxWW2d1pi7zBlgMIcYJozqfa3FulXBKcytFghW3m5s=@vger.kernel.org X-Gm-Message-State: AOJu0YxB8QWwxKrNQ9M1oMMR5YuqoMgpIPrCyYtwPBd+/CFJqyIgoti4 fqYArZlquANsy8kNvjQ4bSnW65DksADxF4ocMzpnlrsCvhTc32PibrmPP/sL++O7UiMun8yd2dr bLDEgK776r0tOU66FqVMluuym7/68HfflDrZB3EVLiUoq3ChjtXHqkPGpMGuODai9TWM= X-Gm-Gg: ASbGncvC9Fj+iCj5SnhVF26jwR/JjRTfkWxmB12lwfP9dnFpGguKxdJSTaZd3OAsNkY JXRuCqaX0BX9Vom9NFE82v5Yz3UNyHS54RjOLqYYNiEBtdPsYQNxKLxmKq2qRykZHgdDFQQiwnK pwZWqH8+DMGXQir7AO+bbQT3oVnvT6wvV83S4eHv9PynVYyet4w4IY3b8kMqTpKQ6P9sn1RzR9M IRzi6CJsheA1si9uMky6rKzIub1A3TkKG6MjW6fCMZ1Menkd0kE3uxE9AXe02uPSG4gB8WguO8G oAn/Y8k2RfaR03Rw/95tBxtFd2V3ARuXOT8QnHiBr1Y4EXVXQepCI13wU4ECzy4jyqr9t49RnAj njcLA+jqmII52JXPupW42r64CKsPdRfgw+K1ctg== X-Received: by 2002:a17:90b:2ccc:b0:340:ba29:d3b6 with SMTP id 98e67ed59e1d1-343f9e92724mr16204365a91.6.1763441331914; Mon, 17 Nov 2025 20:48:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IGx0fVzlAnUq4dpOWrVnMfPjWnKeWw+SIEXnH5mFBLo1+TOoZKSzxI6/PYJd2KildgZH1jJZA== X-Received: by 2002:a17:90b:2ccc:b0:340:ba29:d3b6 with SMTP id 98e67ed59e1d1-343f9e92724mr16204340a91.6.1763441331437; Mon, 17 Nov 2025 20:48:51 -0800 (PST) Received: from [10.217.217.147] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-343e0794e56sm20397887a91.10.2025.11.17.20.48.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Nov 2025 20:48:50 -0800 (PST) Message-ID: Date: Tue, 18 Nov 2025 10:18:44 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/6] clk: qcom: rpmh: Add support for Kaanapali rpmh clocks To: Dmitry Baryshkov Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , jingyi.wang@oss.qualcomm.com, aiqun.yu@oss.qualcomm.com, Ajit Pandey , Imran Shaik , Jagadeesh Kona , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251030-gcc_kaanapali-v2-v2-0-a774a587af6f@oss.qualcomm.com> <20251030-gcc_kaanapali-v2-v2-4-a774a587af6f@oss.qualcomm.com> <380aa79f-f334-44db-9527-85247f9735af@oss.qualcomm.com> <2jfvrt4r7ddagh2ztbad7qnjpcvulcrtr3ekul6i26qg6zcd44@dxfhl3265okx> Content-Language: en-US From: Taniya Das In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTE4MDAzNSBTYWx0ZWRfX+pwcUvtzFPyA 0GfmwMD1tuGer3UpVyAni0Yxn3MauUwaLCwtcItATJZgMBAN9MM2jrSIaLWyX1WmtYyifu/aHko WZK8HeZUD+yuYk0okaRh4XWONqLcBzwdFMEy9N0bdaXxQHrvP4hIk18zvJn/8zWC1G7lrfogf60 E7swR7t8FwfTozxzHy93EjR6XksPIAE+UHwL6AP81BVBTe/tgwER8imb1lU/rH8FNwN2lbpPvDh UUD4KRxpsGy2FlKgupdrue7MnG3fyc8iUjxiqFuJFhuNgCACJqrHwZHbB+Dy6TM2k629mFrKdZB Qfluj47z2DWfii72uw4e/DwzhiZWhamjtEhXmf0sfzGg4stY+ZLyP1MR5d3sQzRb/dsCmi80k87 fPHVG48c4yhq82Nj27rCsOy8g9piIA== X-Proofpoint-GUID: 9JVHyiZ2nmp8qoR5qConM-z1K9w-miMo X-Proofpoint-ORIG-GUID: 9JVHyiZ2nmp8qoR5qConM-z1K9w-miMo X-Authority-Analysis: v=2.4 cv=a4I9NESF c=1 sm=1 tr=0 ts=691bfab5 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=A39G7UXKOQFEQjqAOJYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-17_04,2025-11-13_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 suspectscore=0 spamscore=0 clxscore=1015 bulkscore=0 adultscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511180035 On 11/18/2025 10:04 AM, Dmitry Baryshkov wrote: > On Mon, Nov 17, 2025 at 01:28:46PM +0530, Taniya Das wrote: >> >> >> On 11/14/2025 4:38 PM, Dmitry Baryshkov wrote: >>> On Fri, Nov 14, 2025 at 02:13:49PM +0530, Taniya Das wrote: >>>> >>>> >>>> On 11/11/2025 4:16 PM, Dmitry Baryshkov wrote: >>>>> On Thu, Oct 30, 2025 at 04:39:07PM +0530, Taniya Das wrote: >>>>>> Add the RPMH clocks present in Kaanapali SoC. >>>>>> >>>>>> Signed-off-by: Jingyi Wang >>>>>> Signed-off-by: Taniya Das >>>>>> --- >>>>>> drivers/clk/qcom/clk-rpmh.c | 42 ++++++++++++++++++++++++++++++++++++++++++ >>>>>> 1 file changed, 42 insertions(+) >>>>>> >>>>>> diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c >>>>>> index 1a98b3a0c528c24b600326e6b951b2edb6dcadd7..fd0fe312a7f2830a27e6effc0c0bd905d9d5ebed 100644 >>>>>> --- a/drivers/clk/qcom/clk-rpmh.c >>>>>> +++ b/drivers/clk/qcom/clk-rpmh.c >>>>>> @@ -395,6 +395,19 @@ DEFINE_CLK_RPMH_VRM(clk4, _a, "C4A_E0", 1); >>>>>> DEFINE_CLK_RPMH_VRM(clk5, _a, "C5A_E0", 1); >>>>>> DEFINE_CLK_RPMH_VRM(clk8, _a, "C8A_E0", 1); >>>>>> >>>>>> +DEFINE_CLK_RPMH_VRM(ln_bb_clk1, _a2_e0, "C6A_E0", 2); >>>>>> +DEFINE_CLK_RPMH_VRM(ln_bb_clk2, _a2_e0, "C7A_E0", 2); >>>>>> +DEFINE_CLK_RPMH_VRM(ln_bb_clk3, _a2_e0, "C8A_E0", 2); >>>>>> + >>>>>> +DEFINE_CLK_RPMH_VRM(rf_clk1, _a_e0, "C1A_E0", 1); >>>>>> +DEFINE_CLK_RPMH_VRM(rf_clk2, _a_e0, "C2A_E0", 1); >>>>> >>>>> What is the difference between these clocks and clk[3458] defined few >>>>> lines above? Why are they named differently? If the other name is >>>>> incorrect, please fix it. >>>>> >>>> >>>> Dmitry, my intention was to make a clear distinction between the ‘rf’ >>>> clocks and the ‘ln’ clocks. Since there could be overlap in the >>>> numbering, I added prefixes for clarity. I should have applied the same >>>> approach to clk[3458] as well. I will add the fix-up for the same. >>> >>> Why do we need to distinguish between them here? The resources in CMD-DB >>> don't have such a difference. You'll select whether the clock is RF or >>> LN when describing the platform data. >>> >> >> It is more for readibility and maintain a direct mapping with the PMIC >> clock grid. This way we can immediately identify the clock type without >> cross-referencing desc as the clock mapping here would indicate the type >> of clock. Yes, the CMD-DB name does not reflect anything with the names >> here. Please do let me know your suggestion. > > I'd prefer if variables reflect CMD-DB resource names rather than the > actual clock usage. In the end, platform data does exactly that - it > maps usage to CMD-DB resources. > Actually the grid does not reflect the cmd-db resource name at all, so I do not think that is the right approach. Let me move to completely remove the 'ln' and 'rf' references and refer them to 'clkN'. > Also, if we follow your proposal, we will end up with ln_bb_clk and > rf_clk referencing exactly the same resource, causing possible > confusion. > Sure, Dmitry, I will move to use clkN and remove the suffixes. -- Thanks, Taniya Das