From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D5DB1C84B8 for ; Tue, 2 Dec 2025 14:18:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764685133; cv=none; b=lXK0ZJotWbhPtOK3Q4jINLnlEWOFiab292IdVdu+IYXiv1VcwN/XsP38lkUMkmfTKn/MMDWBHr5uy4q9Kl+0dNISObcGh7Os1e3jTDFirUKoy9vZ42PDUadUpAov7gV/2WOuIVXPeBuTj15UQDCNADR5DKRnLZlEgso2TRG94qw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764685133; c=relaxed/simple; bh=oZkdykvJtHXWigOXU8GpVM5RcFKAy2Fn60LRXWVBZDw=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=Cy5GJBXSDcxf2N2MfkqZgWu/e97TabEvqc7KanJANzTkwl+UTv9u7Xxx+Wim9KAwxYElh4MoUffc0Ey1j7I1zkCvQVJeO9OHSpvA902qvbkNJv/CJZNaLj0L0p7PPS3xW7q7iRgqyFnZw9fZLuYpfNePTVxKt/HYdO5f5olWooo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VnwioI+m; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VnwioI+m" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-298039e00c2so77875595ad.3 for ; Tue, 02 Dec 2025 06:18:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764685132; x=1765289932; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=oZkdykvJtHXWigOXU8GpVM5RcFKAy2Fn60LRXWVBZDw=; b=VnwioI+m3KpJIRXOhyeu8kHtXQ8DCRfaSMIcy/AJc1QSS5kwYhxKLuxwNtEKIAU7DZ l0ybGHFmE857N5gU8iOaGIFnSC0NB9syOBwO24e5Anyc9WuJoGSj8NJA3riWtEqQRm4C J0ACOdgzc0jnWc5iIkhYiDqj0cDogAYafaGCxXjlT+hB1eIq4KKOMcr5SXddUurOwqbT zpF1T+QCNB0e61lrmyk8qFOLG+a82XBjLOC+2Dbmz8JKB7eTs+VkX/tdZKvZVuS5uPAm 7CYVWDbuERPwSzzFRlVNfosaycQHJZc1kmvQFJ/teO4I+nJkoSmIRQR5So8aTrmfS+kv iHIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764685132; x=1765289932; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oZkdykvJtHXWigOXU8GpVM5RcFKAy2Fn60LRXWVBZDw=; b=kOQHSUK55MzjC/j25VkNGsH6WIkdmY71phOkixDTrisXgjj3LMhZz9hBwhioww0kxo FyJ/0FSG5crNU8P+qzj22t2EThH0h3X7nscbnAzWGAcsOy/cOq/hUiBL4qm5RY8ZIfa9 a7VbWN2kjZSMfLz2HUgozCIqpDmsLalb2k5GQvuJ2wDuf8aX/WhNj74clcaCLt5ewGX6 WG+KupHXscH04+bVMkdYy+49atwO2T2paD41WpwvpK+SwEOugyJp9E7bh24Y9mOs0+KA me4D5zEgRSBf3LmZqPiAqzIGb5+0+81qjDf6CimB7f+23UuobX6uAaXdpmddvHGQ7FWd fntQ== X-Forwarded-Encrypted: i=1; AJvYcCVSuHEicCv1H2mVfh6sL7Dff9f3ZrrAXeaLNTjkqtV5FJjpn9XCoAwgbrfYOyG8ezvxGv0U5LJa3EfRzUY=@vger.kernel.org X-Gm-Message-State: AOJu0YyUGL2xYbD7icRPNJ5U4Ptdk21051srIq/sTpwGInyL69Xh3TtC /h3WBiyNQ8LGOCv9LhzrUCAwiulStFRBQrEoixBmXHTNYFDxdOWBIDKd X-Gm-Gg: ASbGncvHzv3WWWHv6v8C7b85/5KEdk2JzRke9FmIpbImTl7hT5ZEHmn3P16rZt7Dyop 2in3d//v51V0viLR29iCPT7fJKnYrRg6iLOHZe/W+HOIW9uMLdaCEbesmxohLLqBt8u4InOtfzS 59r7GzD+RFNEwt26pySXzP04gtpysFMZtI0/L738xfZvRAJSl0RT2NUt6DNYs11PiPLhJI/mR34 eL/kUoWMvM+FL8hLeIXl4R8yu0hG3YPJ8Jj4Nr06sj31R8EETGOBc+FPRoN3/lzXkSoYPKg1jCC R2b5QNQrNUjUuYwwkjXgNKAVt6haX9ngfzEBrEgLBMteCnN8jC4bIQnhGBBr45f+hPlyGwk6YnN kyn3CEdH0ZaaRxY1E2hpX0M16K+tiz4XHGcycwuRNLK2MszgOGdu3pIUHVIRWHb9R/li4EIXc6Q Dn+aL5G/8zHqJT X-Google-Smtp-Source: AGHT+IEXVjMF/gLtu0SpMkt//7+TIhu+AKR4+RCT2p7BygOrI2of0LrhuPfsmy4VQRAuo+vTWYeMvg== X-Received: by 2002:a17:902:f60f:b0:295:5864:8009 with SMTP id d9443c01a7336-29b6bf5c885mr447803385ad.44.1764685131733; Tue, 02 Dec 2025 06:18:51 -0800 (PST) Received: from [192.168.1.4] ([106.215.171.188]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-be4fbde2350sm15354312a12.9.2025.12.02.06.18.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Dec 2025 06:18:51 -0800 (PST) Message-ID: Subject: Re: [RFT net-next PATCH RESEND 0/2] ethernet: intel: fix freeing uninitialized pointers with __free From: ally heev To: Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexander Lobakin Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Simon Horman , Dan Carpenter Date: Wed, 03 Dec 2025 01:17:13 +0530 In-Reply-To: <81053279-f2da-420c-b7a1-9a81615cd7ca@intel.com> References: <20251124-aheev-fix-free-uninitialized-ptrs-ethernet-intel-v1-0-a03fcd1937c0@gmail.com> <81053279-f2da-420c-b7a1-9a81615cd7ca@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-0+deb13u1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2025-12-01 at 13:40 -0800, Tony Nguyen wrote: >=20 > On 11/23/2025 11:40 PM, Ally Heev wrote: > > Uninitialized pointers with `__free` attribute can cause undefined > > behavior as the memory assigned randomly to the pointer is freed > > automatically when the pointer goes out of scope. > >=20 > > We could just fix it by initializing the pointer to NULL, but, as usage= of > > cleanup attributes is discouraged in net [1], trying to achieve cleanup > > using goto >=20 > These two drivers already have multiple other usages of this. All the=20 > other instances initialize to NULL; I'd prefer to see this do the same= =20 > over changing this single instance. >=20 Other usages are slightly complicated to be refactored and might need good testing. Do you want me to do it in a different series? Regards, Ally