From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E098C04AB9 for ; Wed, 22 Aug 2018 16:08:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D38622147A for ; Wed, 22 Aug 2018 16:08:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D38622147A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727055AbeHVTeG (ORCPT ); Wed, 22 Aug 2018 15:34:06 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:56294 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726581AbeHVTeG (ORCPT ); Wed, 22 Aug 2018 15:34:06 -0400 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 7195968B9F11E; Thu, 23 Aug 2018 00:08:32 +0800 (CST) Received: from [127.0.0.1] (10.202.226.41) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.399.0; Thu, 23 Aug 2018 00:08:10 +0800 Subject: Re: [PATCH 0/4] numa, iommu/smmu: IOMMU/SMMU driver optimization for NUMA systems To: Robin Murphy , Ganapatrao Kulkarni References: <20170921085922.11659-1-ganapatrao.kulkarni@cavium.com> <452f1665-eb3a-5e8c-f671-099ef4a15d84@huawei.com> CC: "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "iommu@lists.linux-foundation.org" , "linux-mm@kvack.org" , "Will.Deacon@arm.com" , "gklkml16@gmail.com" , "Tomasz.Nowicki@cavium.com" , "Robert.Richter@cavium.com" , "mhocko@suse.com" , "akpm@linux-foundation.org" , "vbabka@suse.cz" , "jnair@caviumnetworks.com" , Marek Szyprowski , "thunder.leizhen@huawei.com" , Linuxarm , "Christoph Hellwig" From: John Garry Message-ID: Date: Wed, 22 Aug 2018 17:07:55 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.226.41] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/08/2018 15:56, Robin Murphy wrote: > Hi John, > > On 22/08/18 14:44, John Garry wrote: >> On 21/09/2017 09:59, Ganapatrao Kulkarni wrote: >>> Adding numa aware memory allocations used for iommu dma allocation and >>> memory allocated for SMMU stream tables, page walk tables and command >>> queues. >>> >>> With this patch, iperf testing on ThunderX2, with 40G NIC card on >>> NODE 1 PCI shown same performance(around 30% improvement) as NODE 0. >>> >>> Ganapatrao Kulkarni (4): >>> mm: move function alloc_pages_exact_nid out of __meminit >>> numa, iommu/io-pgtable-arm: Use NUMA aware memory allocation for smmu >>> translation tables >>> iommu/arm-smmu-v3: Use NUMA memory allocations for stream tables and >>> comamnd queues >>> iommu/dma, numa: Use NUMA aware memory allocations in >>> __iommu_dma_alloc_pages >>> >>> drivers/iommu/arm-smmu-v3.c | 57 >>> +++++++++++++++++++++++++++++++++++++----- >>> drivers/iommu/dma-iommu.c | 17 +++++++------ >>> drivers/iommu/io-pgtable-arm.c | 4 ++- >>> include/linux/gfp.h | 2 +- >>> mm/page_alloc.c | 3 ++- >>> 5 files changed, 67 insertions(+), 16 deletions(-) >>> >> >> Hi Ganapatrao, >> >> Have you any plans for further work on this patchset? I have not seen >> anything since this v1 was posted+discussed. > Hi Robin, Thanks for the info. I thought I remembered 4b12 but couldn't put my finger on it. > Looks like I ended up doing the version of the io-pgtable change that I > suggested here, which was merged recently (4b123757eeaa). Patch #3 > should also be effectively obsolete now since the SWIOTLB/dma-direct > rework (21f237e4d085). Apparently I also started reworking patch #4 in > my tree at some point but sidelined it - I think that was at least > partly due to another thread[1] which made it seem less clear-cut > whether this is always the right thing to do. Right, so #4 seems less straightforward and not directly related to IOMMU driver anyway. Cheers, John > > Robin. > > [1] > https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1693026.html > > . >