From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EEFE1E4BE for ; Sat, 16 May 2026 19:51:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778961072; cv=none; b=nxyoXjt1h1kXTYugYFcEya3PL6T5l5Xj4R+jrMt3qZpyoJ+nlh8ibeM0C2TEAh4BjxLkwnvlGrxndVhaJtkFxo4BH44UooJ6YgOlPIZe3p2fqJickRtxe8olbG061y6Z9O2SJLFtTXjZaIATvywYSz6+jP4VvhGi3LKIOI8kw9k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778961072; c=relaxed/simple; bh=43rTd5Ene4yn+JpV190cGLWCjk9OHFEhtRmY94yzDUQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kmj+zmfwyyxzqAa6DYYIwiiGReJ5rIzWDq0yRyTK+w5FAH7U1+NElkaJjxJkxjX0vvvmCeCnirVxgddo8GuhQLFBy9yL7nATwihDCBsVpWchiNei9qWiqUZVfIJVWK1aQY75+GkHUjwL5TM5xESS/ovDkrQZMpn70kmCg5wgNCk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=JoudwtUS; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=PpAexbo0; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JoudwtUS"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="PpAexbo0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778961069; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+go7CdOEQbP9DvPRJDpPQ1a5N5jS5xDIf88wkMzAO4E=; b=JoudwtUSAjnDZbdQzWn9gm4qX9yHpmZ3TLORkof0RX3jme5SVaarXkz7U/ZiEnIRxVW82H TclF0lchY6xTAmPlHyQMC6D/2BjGzWW6OhRblb52icqn0ckGgSGuXmobDxZFXaoO6nbcp3 1PnggOw6vyq6qFfFZvFubV0BP4RUhHw= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-676-AIQFUlgRNj-zkNtJAnyhug-1; Sat, 16 May 2026 15:51:07 -0400 X-MC-Unique: AIQFUlgRNj-zkNtJAnyhug-1 X-Mimecast-MFC-AGG-ID: AIQFUlgRNj-zkNtJAnyhug_1778961066 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-48fd3449e6dso5873675e9.3 for ; Sat, 16 May 2026 12:51:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1778961066; x=1779565866; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+go7CdOEQbP9DvPRJDpPQ1a5N5jS5xDIf88wkMzAO4E=; b=PpAexbo0X/cp7ZLFo1K51itibwLrADqhktl1msWvHVNiY4/BT3vvcex6hG+Bzc4Ifo oOAnjSorcQfOsgj5BS6L0u7F3Saz7KqKEE1Y2idKjaQsYivg/wUNnklOZsDKjgBTnLj2 fF8lLbp9v1XoHGcUuAh84UfUyaPXF/R9wB3y3a97e4oQgJysRZOigMP/8f7Us6kB8g5z kx1RXem3Mvd4Hlr7NOBmiSjCEz3YFRWeYy7JS+rsjFAJlvL85Yz5STT+B4RI+xUq1Kyu LVJ8K4QH1qXAp48vWRkg+4tfCOUJSA2Dp4kCmdUFG0PlAfYGH9Xd/DEDSb21aAG80i/x X6YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778961066; x=1779565866; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+go7CdOEQbP9DvPRJDpPQ1a5N5jS5xDIf88wkMzAO4E=; b=ogZAtEIaHVtCNtr90bG3i6tdh3PTWhlshJLJpjwC+YWRyRJlbKSi1eA3roDGU5PqOF ytGG/q4PxuPPnqahjUi17cpeqXeGZWUw/SQEnIK8ROt1Sviyy1OoVDMYwrp9Gso+V5hl H0ENN1yMLMdWZv+f8CQ26z0zGyqqQwHZGsVkFMePbUe041kXoUCpiPAq8Q5WDJZSsxRH pCri7gpJLDzooiqzqAuURLkLd9+EovTeM7GbTybZpthLNqN2fPGfJilnp2xeMTvJw33u 2xg88Vkf2MGYcsQylsdcwUxnW/khVTosiLWXoPq+Cb2vPAZQalyfQjaA4AfhX+pnwq/+ Ejgw== X-Forwarded-Encrypted: i=1; AFNElJ8rOxhwEEr0vQb4NRf5tiqnFZdHjlUtVMtoHM10HTXokHHgVIlYznVaz7uwuDjLSYCKvEzLe5tQZap/GwY=@vger.kernel.org X-Gm-Message-State: AOJu0YzuBcmokEKl4GqotXqi2bRof0EpAaYmSHHocsucVbrk61pFULN+ HzCDOnBeY0voVIpnZFQeudya4s+Asrcsw76lxEiFLK1wjDsfTddxVPN1PyJdKgIhRztY4mq3IHU 4f8EIAWz1r9dNtBf40soO/oPRoQ79DJ0X057IKbtic6WvU/QdjvnDtgOwWjEiZjmCCw== X-Gm-Gg: Acq92OF7REU6oxZVdLLxuWQvMp/Y1VwL2SE/Rd/9cTnbadFDCIzikwWyczKteeLb/Pa eX3Tzj8xdLh9CcSMEU6xm1RaiWKSLeYZyTuaoxbOjvErl12gkJbWQvDSTmZ9DwlR0NYeK+lngcE gF/Oo9kYKAK6vmbdv870CDl0JiHf0BjFL0EVyL3bywAV1XChNZNxd0ydfPZjQgC+HC3iqNmXG3T W2ypaPHE+ps/VzaLp/8Jlh7ZjZFhkfxYd1KkL6gP/2dSn9DUmb+p4zEN64ZKSY/9qrZpvGEfAK4 i6PvKLBEOZw4lg79yAsmT4POU6Fo2kPr+BJtUFwMbeDrasi021IBe/JRinQ3wGau3mRhrFwpJAO AnZHu1809qB946FbKj8B9 X-Received: by 2002:a05:600c:6383:b0:488:c014:34da with SMTP id 5b1f17b1804b1-48fe651690fmr132556925e9.26.1778961066455; Sat, 16 May 2026 12:51:06 -0700 (PDT) X-Received: by 2002:a05:600c:6383:b0:488:c014:34da with SMTP id 5b1f17b1804b1-48fe651690fmr132556695e9.26.1778961066062; Sat, 16 May 2026 12:51:06 -0700 (PDT) Received: from [192.168.2.83] ([46.175.183.46]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48febe74a53sm44211185e9.27.2026.05.16.12.51.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 16 May 2026 12:51:04 -0700 (PDT) Message-ID: Date: Sat, 16 May 2026 21:51:00 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net] dpll: zl3073x: fix memory leak on pin registration failure To: Ivan Vecera , netdev@vger.kernel.org Cc: Prathosh Satish , Vadim Fedorenko , Arkadiusz Kubalewski , Jiri Pirko , Jakub Kicinski , open list References: <20260515193956.351092-1-ivecera@redhat.com> Content-Language: en-US From: Petr Oros In-Reply-To: <20260515193956.351092-1-ivecera@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/15/26 21:39, Ivan Vecera wrote: > If zl3073x_dpll_pin_register() fails, the allocated pin is not yet > added to zldpll->pins list. The error path calls > zl3073x_dpll_pins_unregister() which only iterates pins on the list, > so the current pin is leaked. Free the pin before jumping to the error > label. > > Fixes: 75a71ecc2412 ("dpll: zl3073x: Register DPLL devices and pins") > Signed-off-by: Ivan Vecera > --- > drivers/dpll/zl3073x/dpll.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/dpll/zl3073x/dpll.c b/drivers/dpll/zl3073x/dpll.c > index c95e93ef3ab0..d6232aa371be 100644 > --- a/drivers/dpll/zl3073x/dpll.c > +++ b/drivers/dpll/zl3073x/dpll.c > @@ -1563,8 +1563,10 @@ zl3073x_dpll_pins_register(struct zl3073x_dpll *zldpll) > } > > rc = zl3073x_dpll_pin_register(pin, index); > - if (rc) > + if (rc) { > + zl3073x_dpll_pin_free(pin); > goto error; > + } > > list_add(&pin->list, &zldpll->pins); > } Reviewed-by: Petr Oros