From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA308C00A89 for ; Mon, 2 Nov 2020 08:18:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 74DC8206B7 for ; Mon, 2 Nov 2020 08:18:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="aBk9tP4x" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728189AbgKBISg (ORCPT ); Mon, 2 Nov 2020 03:18:36 -0500 Received: from fllv0015.ext.ti.com ([198.47.19.141]:39810 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727802AbgKBISg (ORCPT ); Mon, 2 Nov 2020 03:18:36 -0500 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 0A28HkjG095958; Mon, 2 Nov 2020 02:17:46 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1604305066; bh=PKURKhrStf5hrU/3/FF8PfX58ZYAVeadBgvFHZofdUQ=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=aBk9tP4xdkqFm+ZsJtTWJASXy4g8DHzi/WCcG1PXOBg5cUc9e3Be39Cgu6md+6JbB H+acGNAdSqAMWLIvF5U3xqVqPO5z2Va273STE7hdctiLgeWib5IiY8tECBeHTeWLHk +V1nv47qCi57ZIlKmf+2BRKCwy10JTZEGpDjVXKY= Received: from DLEE103.ent.ti.com (dlee103.ent.ti.com [157.170.170.33]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 0A28Hkj4016878 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 2 Nov 2020 02:17:46 -0600 Received: from DLEE101.ent.ti.com (157.170.170.31) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Mon, 2 Nov 2020 02:17:45 -0600 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE101.ent.ti.com (157.170.170.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Mon, 2 Nov 2020 02:17:46 -0600 Received: from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 0A28HiDm044386; Mon, 2 Nov 2020 02:17:44 -0600 Subject: Re: [PATCH] ASoC: ti: davinci-evm: Remove redundant null check before clk_disable_unprepare To: Xu Wang , , , , , CC: References: <20201029082513.28233-1-vulab@iscas.ac.cn> From: Peter Ujfalusi Message-ID: Date: Mon, 2 Nov 2020 10:18:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201029082513.28233-1-vulab@iscas.ac.cn> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/10/2020 10.25, Xu Wang wrote: > Because clk_disable_unprepare() already checked NULL clock parameter, > so the additional check is unnecessary, just remove it. Acked-by: Peter Ujfalusi > Signed-off-by: Xu Wang > --- > sound/soc/ti/davinci-evm.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/sound/soc/ti/davinci-evm.c b/sound/soc/ti/davinci-evm.c > index 105e56ab9cdc..b043a0070d20 100644 > --- a/sound/soc/ti/davinci-evm.c > +++ b/sound/soc/ti/davinci-evm.c > @@ -46,8 +46,7 @@ static void evm_shutdown(struct snd_pcm_substream *substream) > struct snd_soc_card_drvdata_davinci *drvdata = > snd_soc_card_get_drvdata(soc_card); > > - if (drvdata->mclk) > - clk_disable_unprepare(drvdata->mclk); > + clk_disable_unprepare(drvdata->mclk); > } > > static int evm_hw_params(struct snd_pcm_substream *substream, > - Péter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki