From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F61BEB64D8 for ; Thu, 22 Jun 2023 18:50:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231361AbjFVSux (ORCPT ); Thu, 22 Jun 2023 14:50:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230071AbjFVSuv (ORCPT ); Thu, 22 Jun 2023 14:50:51 -0400 Received: from smtpcmd02101.aruba.it (smtpcmd02101.aruba.it [62.149.158.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16EFAA2 for ; Thu, 22 Jun 2023 11:50:49 -0700 (PDT) Received: from [192.168.50.162] ([146.241.96.150]) by Aruba Outgoing Smtp with ESMTPSA id CPOJqUQ4W7skLCPOJqI8Pq; Thu, 22 Jun 2023 20:50:48 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aruba.it; s=a1; t=1687459848; bh=NiL5KJY63hJ4jA23FuSWyQhcwnYWpVK+f6seEcG9u6o=; h=Date:MIME-Version:Subject:To:From:Content-Type; b=AAOPqMmunz1BKpXzVO0l7wO8cXRPc4XnCeUZqacKrZZIoRiBFLuqU5ji7G++xkuXL ezJQPQVZu5hi2LpJ2ZH/K+dydL8bMSD+JQQeD4fFu/LiKrUOjY+LA5iXKtGD3JMjvs EGCcVeXa981EtexBs8U7eHKdMJXWLAY7SewP2CA22Ttkocsd8lsFlqhGOEV3reApvC 2GC3dbsiIX5E0g3mU0wWQT/smXyR7AsRiB/W/rTkibYjd5hpFaE9TcD+Awv5ScAnBW ZfCkJXLde7CDXyw30vYbV6qJh+UqQsN2IzvECIBfnrpBy+xxnxRt6Gl6axgyd/OJbW VaptUwg3BQAuw== Message-ID: Date: Thu, 22 Jun 2023 20:50:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] net: phy: broadcom: drop brcm_phy_setbits() and use phy_set_bits() instead Content-Language: en-US To: Simon Horman Cc: Florian Fainelli , Broadcom internal kernel review list , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230622123737.8649-1-giulio.benetti@benettiengineering.com> <12d3d3e7-da90-cc73-57e6-1aa7859dce90@benettiengineering.com> From: Giulio Benetti In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4xfPgOOi/LCA4VeUvKOAH9MIyz0KRj9UZKaH5rDQXASx+NILAQrSp/XoIyKQzSdzqn2+3Rfmn3+rJPP5nCDVJv5sR/ye1UVAW0WkX4OIKcBbFaLmRUV9w8 m4z+JLokFSIvd4o9oVhp9oNdYS3bmIxdMH6nlw0DvpAInymiHku8ALzCKFsvdXKLYXDG82JTtGglwXwenaF4dXOZgWSVLyio95ddILby+xV194rTyserouU7 P828/F0nS141CL1eCVJTI5HKYMSCr/wIQiHI/JSJg8eV7r1CIYa3Wqqys66BeQe8Zq+FRqm23v5mEMP3UnQ19eB2WLzcJwu0Ohoc772CmTjEGTUsNhXX/N38 0fxNGPtU09RY7kU3ntgPCYfqV9Z/vt+oJHrlDma4ackjGPt54pvC6G7rfUV6v0TgNDX2Y6kge4HJydiAAgIugdqlh2CxiMnE9y7d3lEahndrJwvC2Ri7UDEQ YMbnMpUbYrJ1tBn/7W/AmdoChAaVN4kz53WiQP22rg2zqC2RKLNIyN+DQym23OSuWUQtutLa6bFTv9o0VwOtFBP32bIUzrRL4L+ojV1X4+rY0qBCdITrdpbB TLU= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Simon, On 22/06/23 17:35, Simon Horman wrote: > On Thu, Jun 22, 2023 at 02:48:46PM +0200, Giulio Benetti wrote: >> Pardon, >> >> On 22/06/23 14:37, Giulio Benetti wrote: >>> Linux provides phy_set_bits() helper so let's drop brcm_phy_setbits() and >>> use phy_set_bits() in its place. >>> >>> Signed-off-by: Giulio Benetti >>> --- >>> drivers/net/phy/broadcom.c | 15 ++------------- >>> 1 file changed, 2 insertions(+), 13 deletions(-) >>> >>> diff --git a/drivers/net/phy/broadcom.c b/drivers/net/phy/broadcom.c >>> index ad71c88c87e7..d684c5be529a 100644 >>> --- a/drivers/net/phy/broadcom.c >>> +++ b/drivers/net/phy/broadcom.c >>> @@ -608,17 +608,6 @@ static int bcm54616s_read_status(struct phy_device *phydev) >>> return err; >>> } >>> -static int brcm_phy_setbits(struct phy_device *phydev, int reg, int set) >>> -{ >>> - int val; >>> - >>> - val = phy_read(phydev, reg); >>> - if (val < 0) >>> - return val; >>> - >>> - return phy_write(phydev, reg, val | set); >>> -} >>> - >>> static int brcm_fet_config_init(struct phy_device *phydev) >>> { >>> int reg, err, err2, brcmtest; >>> @@ -689,14 +678,14 @@ static int brcm_fet_config_init(struct phy_device *phydev) >>> goto done; >>> /* Enable auto MDIX */ >>> - err = brcm_phy_setbits(phydev, MII_BRCM_FET_SHDW_MISCCTRL, >>> + err = phy_set_bits(phydev, MII_BRCM_FET_SHDW_MISCCTRL, >>> MII_BRCM_FET_SHDW_MC_FAME); >> >> I've missed to checkpatch.pl and there is a style error ^^^ >> >>> if (err < 0) >>> goto done; >>> if (phydev->dev_flags & PHY_BRCM_AUTO_PWRDWN_ENABLE) { >>> /* Enable auto power down */ >>> - err = brcm_phy_setbits(phydev, MII_BRCM_FET_SHDW_AUXSTAT2, >>> + err = phy_set_bits(phydev, MII_BRCM_FET_SHDW_AUXSTAT2, >>> MII_BRCM_FET_SHDW_AS2_APDE); >> >> and here ^^^ >> >> I wait some time for any feedback and then I send a V2. > > Hi Giulio, > > Please include the target tree, net-next, when you send v2: > > Subject: [PATCH net-next v2] ... Thank you, I've just sent the v2 in reply to this. Best regards -- Giulio Benetti CEO&CTO@Benetti Engineering sas