From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750858AbcI1GjL (ORCPT ); Wed, 28 Sep 2016 02:39:11 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:33216 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750714AbcI1GjC (ORCPT ); Wed, 28 Sep 2016 02:39:02 -0400 Subject: Re: [PATCH] virtio/s390: add missing \n to end of dev_err message To: Colin King , Cornelia Huck , Martin Schwidefsky , Heiko Carstens , linux-s390@vger.kernel.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org References: <20160927200844.16008-1-colin.king@canonical.com> Cc: linux-kernel@vger.kernel.org From: Christian Borntraeger Date: Wed, 28 Sep 2016 08:38:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20160927200844.16008-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16092806-0036-0000-0000-00000238D44A X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16092806-0037-0000-0000-000012A93B78 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-09-28_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609020000 definitions=main-1609280117 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/27/2016 10:08 PM, Colin King wrote: > From: Colin Ian King > > Trival fix, dev_err message is missing a \n, so add it. > > Signed-off-by: Colin Ian King > --- > drivers/s390/virtio/virtio_ccw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/s390/virtio/virtio_ccw.c b/drivers/s390/virtio/virtio_ccw.c > index 8688ad4..9d36dc4 100644 > --- a/drivers/s390/virtio/virtio_ccw.c > +++ b/drivers/s390/virtio/virtio_ccw.c > @@ -462,7 +462,7 @@ static void virtio_ccw_del_vq(struct virtqueue *vq, struct ccw1 *ccw) > * This may happen on device detach. > */ > if (ret && (ret != -ENODEV)) > - dev_warn(&vq->vdev->dev, "Error %d while deleting queue %d", > + dev_warn(&vq->vdev->dev, "Error %d while deleting queue %d\n", > ret, index); > > vring_del_virtqueue(vq); > Thanks, applied.