mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mieczyslaw Nalewaj <namiltd@yahoo.com>
To: netdev-bot+sashiko@kernel.org
Cc: linusw@kernel.org, andrew@lunn.ch, olteanv@gmail.com,
	kuba@kernel.org, davem@davemloft.net, edumazet@google.com,
	pabeni@redhat.com, linux@armlinux.org.uk, luizluca@gmail.com,
	maxime.chevallier@bootlin.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, alvin.sipraga@analog.com,
	gusfmora@gmail.com, kuncy7@gmail.com, fabianotassotti@gmail.com,
	gabonpivovich@gmail.com, contact@c127.dev
Subject: Re: [PATCH net-next v10 11/12] net: dsa: realtek: rtl8365mb: make L2/LUT access work on family D
Date: Thu, 19 Nov 2026 07:21:18 +0100	[thread overview]
Message-ID: <ec7722a0-d308-4903-860b-974beb8fb623@yahoo.com> (raw)
In-Reply-To: <8aa852f3-86b4-49c9-95a0-e8c51ef0d521@yahoo.com>

Hi,

A follow-up to my reply about point 1 (a private FID for the offloaded
bridge). I could not confirm it from the vendor API and said it needed
hardware experiments. Gustavo Foletto Mora has now measured it on an
RTL8367S-VB (EX511) with a development version that wrote FID 1 into the
VLAN 4K entries of the bridge and used it in the FDB/MDB keys.

What the measurement showed:

 - The chip learns with the FID of the 4K entry the frame is classified
   into (IVL_EN=0), and static entries written with that FID replace the
   learned ones.
 - Standalone ports (PVID 0) do not land in that FID, so for a bridge
   whose ports have a PVID the collision is gone.

Why I still won’t do this in the next series:

 - The FID comes only from a VLAN 4K entry. The default OpenWrt br-lan has
   no VLAN: its ports keep PVID 0, the driver writes no 4K entry for
   VID 0, and the bridge is looked up in FID 0, while the entries are
   written with FID 1. The keys then never match: a static entry no longer
   steers or drops (104 frames out of the uplink for 100 sent, 7 with the
   shared FID 0).
 - With fdb_isolation, DSA installs the standalone ports' addresses as host
   entries in FID 0, which the plain bridge also looks up. Its frames to
   them go to the CPU with offload_fwd_mark set and are not forwarded by
   the software bridge: 0/50 on h1 -> h2, versus 50/50 with the shared FID.

So a private FID fixes the case with a PVID and breaks the more common
one, which is worse than the documented limitation. The next revision
will keep the shared FID 0 and the limitation as described in the commit
message.

A complete solution would give the ports of a VLAN-unaware bridge a
private PVID whose 4K entry carries the bridge FID, as mv88e6xxx does
(MV88E6XXX_VID_BRIDGED / MV88E6XXX_FID_BRIDGED). That needs the PVID to
follow vlan_filtering changes, and the handling of tagged frames with a
VID that has no 4K entry is still unknown, so I would like to do it as a
separate follow-up with testing on hardware.

Best regards,
Mieczyslaw Nalewaj

  reply	other threads:[~2026-11-19  6:21 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <d9da17af-f49e-4878-a8dd-59a8919e6930.ref@yahoo.com>
2026-11-12 17:31 ` [PATCH net-next v10 00/12] net: dsa: realtek: rtl8365mb: add support for RTL8367S-VB Mieczyslaw Nalewaj
2026-11-12 17:32   ` [PATCH net-next v10 01/12] dt-bindings: net: dsa: realtek: add RTL8367S-VB Mieczyslaw Nalewaj
2026-11-12 17:33   ` [PATCH net-next v10 02/12] net: dsa: realtek: rtl8365mb: add chip family infrastructure Mieczyslaw Nalewaj
2026-11-12 17:33   ` [PATCH net-next v10 03/12] net: dsa: realtek: rtl8365mb: refactor forcemode handling Mieczyslaw Nalewaj
2026-11-12 20:23     ` Linus Walleij
2026-11-12 17:34   ` [PATCH net-next v10 04/12] net: dsa: realtek: rtl8365mb: set speed for family D Mieczyslaw Nalewaj
2026-11-12 17:35   ` [PATCH net-next v10 05/12] net: dsa: realtek: rtl8365mb: set RGMII mode " Mieczyslaw Nalewaj
2026-11-12 17:36   ` [PATCH net-next v10 06/12] net: dsa: realtek: rtl8365mb: refactor VLAN 4k handling Mieczyslaw Nalewaj
2026-11-12 20:24     ` Linus Walleij
2026-11-12 17:37   ` [PATCH net-next v10 07/12] net: dsa: realtek: rtl8365mb: set and get vlan 4k for family D Mieczyslaw Nalewaj
2026-11-12 20:25     ` Linus Walleij
2026-11-16 18:55     ` netdev-bot+sashiko
2026-11-12 17:38   ` [PATCH net-next v10 08/12] net: dsa: realtek: rtl8365mb: use raw VID for PVID on " Mieczyslaw Nalewaj
2026-11-16 18:55     ` netdev-bot+sashiko
2026-11-17  6:28       ` Mieczyslaw Nalewaj
2026-11-12 17:39   ` [PATCH net-next v10 09/12] net: dsa: realtek: rtl8365mb: add family D SDS13 PCS support Mieczyslaw Nalewaj
2026-11-16 18:55     ` netdev-bot+sashiko
2026-11-12 17:40   ` [PATCH net-next v10 10/12] net: dsa: realtek: rtl8365mb: refactor L2 MAC handling Mieczyslaw Nalewaj
2026-11-12 20:26     ` Linus Walleij
2026-11-12 17:41   ` [PATCH net-next v10 11/12] net: dsa: realtek: rtl8365mb: make L2/LUT access work on family D Mieczyslaw Nalewaj
2026-11-16 18:55     ` netdev-bot+sashiko
2026-11-17  6:33       ` Mieczyslaw Nalewaj
2026-11-19  6:21         ` Mieczyslaw Nalewaj [this message]
2026-11-12 17:42   ` [PATCH net-next v10 12/12] net: dsa: realtek: rtl8365mb: add support for RTL8367S-VB Mieczyslaw Nalewaj
2026-11-16 18:56     ` netdev-bot+sashiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ec7722a0-d308-4903-860b-974beb8fb623@yahoo.com \
    --to=namiltd@yahoo.com \
    --cc=alvin.sipraga@analog.com \
    --cc=andrew@lunn.ch \
    --cc=contact@c127.dev \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=fabianotassotti@gmail.com \
    --cc=gabonpivovich@gmail.com \
    --cc=gusfmora@gmail.com \
    --cc=kuba@kernel.org \
    --cc=kuncy7@gmail.com \
    --cc=linusw@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=luizluca@gmail.com \
    --cc=maxime.chevallier@bootlin.com \
    --cc=netdev-bot+sashiko@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®