From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EDA4C433F5 for ; Mon, 21 Mar 2022 11:02:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346614AbiCULD5 (ORCPT ); Mon, 21 Mar 2022 07:03:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346620AbiCULDR (ORCPT ); Mon, 21 Mar 2022 07:03:17 -0400 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BE3A14B84C for ; Mon, 21 Mar 2022 04:01:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1647860511; x=1679396511; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=STU6cY35f0Ar5xQ71SnPMC7cF7hVD3maLrZFmxx4A+8=; b=jrnOz7aHPQ2ZslXg1e4FeCNXO7vfvyIjzEILP5BJLqak4EN/gyVeLdVD PuzkRiW1l8KFlA8gkaJ50grYnC7AfPRmkOlHwqQNZmcJ61NmmDCuHmZQo uxWLncD4oQeOn2eKTu8a0tF5KEnj9swWjz4BIRn4UreaIyyJsrxOBmaSg nqbbjF2vQbSX9BtU+pXeqmae2hDt/XdFU9XsyQ2SWT6PfEAmG2m169x1n 6ixKZf7xtaqBWET14A61V/PosEfFXqD6u+NRUkM7AqkriBd2ItmnH0SWo sGuHJZpUoUpvN2wv8Nxnr6Akr9dzTbw4qRiwW98ocemMJO5rlyJwDucA5 g==; X-IronPort-AV: E=McAfee;i="6200,9189,10292"; a="239681187" X-IronPort-AV: E=Sophos;i="5.90,198,1643702400"; d="scan'208";a="239681187" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Mar 2022 04:01:50 -0700 X-IronPort-AV: E=Sophos;i="5.90,198,1643702400"; d="scan'208";a="559819619" Received: from blu2-mobl3.ccr.corp.intel.com (HELO [10.254.213.169]) ([10.254.213.169]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Mar 2022 04:01:47 -0700 Message-ID: Date: Mon, 21 Mar 2022 19:01:45 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Cc: baolu.lu@linux.intel.com, Eric Auger , "Liu, Yi L" , "Pan, Jacob jun" , "iommu@lists.linux-foundation.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH RFC 06/11] iommu/sva: Use attach/detach_pasid_dev in SVA interfaces Content-Language: en-US To: "Tian, Kevin" , Joerg Roedel , Jason Gunthorpe , Christoph Hellwig , "Raj, Ashok" , Will Deacon , Robin Murphy , Jean-Philippe Brucker References: <20220320064030.2936936-1-baolu.lu@linux.intel.com> <20220320064030.2936936-7-baolu.lu@linux.intel.com> From: Lu Baolu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/3/21 16:04, Tian, Kevin wrote: >> From: Lu Baolu >> Sent: Sunday, March 20, 2022 2:40 PM >> +struct iommu_sva * >> +iommu_sva_bind_device(struct device *dev, struct mm_struct *mm, void >> *drvdata) >> +{ >> + int ret = -EINVAL; >> + struct iommu_sva *handle; >> + struct iommu_domain *domain; >> + >> + handle = kzalloc(sizeof(*handle), GFP_KERNEL); >> + if (!handle) >> + return ERR_PTR(-ENOMEM); >> + >> + ret = iommu_sva_alloc_pasid(mm, 1, (1U << dev->iommu->pasid_bits) >> - 1); >> + if (ret) >> + goto out; >> + >> + domain = iommu_sva_domain_alloc(dev); >> + if (!domain) { >> + ret = -ENOMEM; >> + goto out; >> + } >> + domain->sva_cookie = mm; > > one domain can be attached by multiple devices, so this should not be > a blind alloc. Indeed. Perhaps we could associate the SVA domain with the mm->pasid and add a user counter inside the domain. Best regards, baolu