mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>,
	linux-ide@vger.kernel.org, kernel-janitors@vger.kernel.org,
	git@amd.com, Damien Le Moal <dlemoal@kernel.org>,
	Niklas Cassel <cassel@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Jens Axboe <axboe@kernel.dk>,
	Michal Simek <michal.simek@amd.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Philipp Zabel <p.zabel@pengutronix.de>
Subject: Re: [PATCH] ata: ahci_ceva: return of_property_read_u8_array() error code
Date: Thu, 21 Mar 2024 10:22:00 +0100	[thread overview]
Message-ID: <ec90ffc0-fb26-462a-b470-4368c2f7dc68@web.de> (raw)
In-Reply-To: <1710960665-1391654-1-git-send-email-radhey.shyam.pandey@amd.com>

> In the ahci_ceva_probe() error path instead of returning -EINVAL for all
> of_property_read_u8_array() failure types return the actual error code.
> It removes the redundant -EINVAL assignment at multiple places and
> improves the error handling path.

A) Would a change description be more desirable with a corresponding imperative wording?

   See also:
   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.8#n94


B) Can it be helpful to specify the hint “in ceva_ahci_probe()” at the end
   of the patch subject?


C) How do you think about to extend the application of scope-based resource management here?

   See also:
   Article by Jonathan Corbet
   2023-06-15
   https://lwn.net/Articles/934679/


Regards,
Markus

  reply	other threads:[~2024-03-21  9:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-20 18:51 Radhey Shyam Pandey
2024-03-21  9:22 ` Markus Elfring [this message]
2024-03-21 23:58 ` Damien Le Moal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ec90ffc0-fb26-462a-b470-4368c2f7dc68@web.de \
    --to=markus.elfring@web.de \
    --cc=axboe@kernel.dk \
    --cc=cassel@kernel.org \
    --cc=dlemoal@kernel.org \
    --cc=git@amd.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@amd.com \
    --cc=p.zabel@pengutronix.de \
    --cc=peterz@infradead.org \
    --cc=radhey.shyam.pandey@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®