From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out30-100.freemail.mail.aliyun.com (out30-100.freemail.mail.aliyun.com [115.124.30.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6281B24E4A8 for ; Tue, 24 Feb 2026 05:50:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.100 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771912203; cv=none; b=Fx1ejwZzTPTYIMbFKYJo13eLqsjfoyO5y+TrqiXcaZYq/0xZM/z8TVLViZ3IUWTO8YhJO0zKeB7NBjwTaf+U2SMrZC7CMiKgUqGCrySNz3di2C34YOSxSN25k+VDM0eWotkJ/hbUWeIWaQWfDlNHkDJ/KvF9thj0lr57fVPbnNA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771912203; c=relaxed/simple; bh=rlzRzq8weWAfs3r9DuulIxVbepmf9SpeXMOGtyauuV8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Kaw6OVIbt99bOp+IG1eZAKWm2knZjvmQM+0hiPbED6dx2vqXHwAPx7FXk3XdYbGBHoo6pvGhCEs5tkw3X/bHZIuA3VjvFjd1pbeAT8MDHWIv2x3seectDt1gX6oYm3gTVExM//utmVZuGKZGnm0dXESTt1Y1aRCJFWpW/6+stiU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=mJ63lv8j; arc=none smtp.client-ip=115.124.30.100 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="mJ63lv8j" DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1771912196; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=/C/RjEuENHKQ8NVKZ+XHFLTLUPqm8179r+FfKGRQPEI=; b=mJ63lv8j9uuGIyPuyHTIwBJ1yKXvQOVZA9A935RQFQeGJIiOuIE0cYXINL9DyAqHLifVwOAIAxJWAokWYEVRJ7kQHpiLKoB5QvDvM4ulF8BbXLWF/Coae9r2nYyFst/qUG/izonMPPTsthzc48up98RlzdnlT9E39s4R0V8VYYY= Received: from 30.74.144.111(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0WziN4bE_1771912193 cluster:ay36) by smtp.aliyun-inc.com; Tue, 24 Feb 2026 13:49:54 +0800 Message-ID: Date: Tue, 24 Feb 2026 13:49:53 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/5] mm: rmap: add a ZONE_DEVICE folio warning in folio_referenced() To: Rik van Riel , akpm@linux-foundation.org, david@kernel.org Cc: catalin.marinas@arm.com, will@kernel.org, lorenzo.stoakes@oracle.com, ryan.roberts@arm.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, harry.yoo@oracle.com, jannh@google.com, willy@infradead.org, baohua@kernel.org, dev.jain@arm.com, axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com, hannes@cmpxchg.org, zhengqi.arch@bytedance.com, shakeel.butt@linux.dev, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: From: Baolin Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2/24/26 10:38 AM, Rik van Riel wrote: > On Tue, 2026-02-24 at 09:56 +0800, Baolin Wang wrote: >> >> diff --git a/mm/rmap.c b/mm/rmap.c >> index bff8f222004e..be785dfc9336 100644 >> --- a/mm/rmap.c >> +++ b/mm/rmap.c >> @@ -1065,6 +1065,7 @@ int folio_referenced(struct folio *folio, int >> is_locked, >>   .invalid_vma = invalid_folio_referenced_vma, >>   }; >> >> + VM_WARN_ON_FOLIO(folio_is_zone_device(folio), folio); >>   *vm_flags = 0; >>   if (!pra.mapcount) >>   return 0; > > Should be a VM_WARN_ON_ONCE_FOLIO so we do not cause > a softlockup if we try to print information about a > million ZONE_DEVICE pages? Yes, sounds reasonable. Will do in next version. Thanks for reviewing.