From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56F881A9B48 for ; Wed, 8 Jan 2025 07:25:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736321106; cv=none; b=TY69rVGe0gb7unyCV27DsniZMMVgyXFdbed/nTwpyvexlhaU6HsqCwc5V8+O57DTsCs2KeyUmC1J7FqhDh+QAuk9xnydlQY9HiH3Ikbi6gbiBpl1H9wqlYMnltgBdkupyWxlBhYfqJcVI96NUPJ0+JYK/pMybd/6QbFQzboWw4w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736321106; c=relaxed/simple; bh=+/c1/0hClzEfwcjrtZ8lxMXoYwF9sxDDQ7/YR3s9pZ0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SBBE5xEuU68pptvIoyEHXMfJzIHvd3Un2qBiRXXvJXR+sUb/AdNP//IViwTiNWox0VCIokL6Y+GpLVVdjkTWabKOwJ/ghhKNeX57yG1croEWg7qzDU5ahNaI7/4GKeguGrd0W3V+Jz3pn41yIUE7sUDJ+nGewlauDeBrDBi/mug= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=eM3nvhui; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="eM3nvhui" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4361815b96cso109318235e9.1 for ; Tue, 07 Jan 2025 23:25:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1736321102; x=1736925902; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=e6c9Re305ngnHuLR+MfR+VGkPfepefdC520IxoryX0w=; b=eM3nvhuiuVvFIlxeVtZxBzZAp9ehVOsHB4RSSRJ2ohc/nZhIHRbT7hdW78h8KrKp5F fGzrP9bbpEmW0vA6A3H8MYBtCZwVtoOvZ1AIGdqtliIeKKytpqrPJy3k/lGmZ5YmkCxX QYwREAa2SIMmgVGtaWHBXDAwrDoIHKtj0d0TyZv8cZQAZ6y2IdP8f0p1NRGf3m8nT5oM 6jOsEKHayvnXJ/DJcDkEX8Nem87u98rvNI7V28GJ0vrS+dc/C3iuLsvI8XlCWmA6EIGf t5xWik4x4yxvDHCsnkQr5vT273kEyU5a6G1zpTyWQpkMFuCm7EbP6IumaVMPamsET+Y0 ABaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736321102; x=1736925902; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=e6c9Re305ngnHuLR+MfR+VGkPfepefdC520IxoryX0w=; b=dAIY/DGC5jQPtPLcpZ+8336l/BmZMf60/EgHmYUHI6fo11dXg0HYx1U2Pa/Cgy72tW c7qEb4SpJ8C30El/deNbzy28gGTJUWA0kri5mCYKMT0uta1J8ReiehHzN9hPX/cykVzT NWuVzIODuia3SGSmqEFsH62s3fHfazdMCRMze6iVSBLOkXs+m35WyQLovOmc2eZDmmh4 cCnnsahNp5ZVx637Ub2PpakJv4GJb7O1WwymhJKdgE63FFplYsJ+7cqU6NpoEtxcgk0U HGgfgESBMOYrLWo7QHVojrAggeyLxOt5QEm1O9PnxKbtUDUvw2aebjawcG7z/3JZFMox WLrA== X-Forwarded-Encrypted: i=1; AJvYcCUY1dJ0lPFiwVqyynafG1s3doXo0VuYO8B/bNNr24vkNPkGac88gma2sdPBkzZ50G0ynn9w6CKuI1iGDwk=@vger.kernel.org X-Gm-Message-State: AOJu0YwKTDDYDCdgixxfw7Sh6kSoTbIbwKgArdTp7EVjaOSFr166mjwS ok7Gp+/xavTI/2FAPZhgsPHeEjO4t49gn5AXcxb768ncgYP1nB/owsmt2MxZdg== X-Gm-Gg: ASbGnct76qyF5Uomgj27PT4bUGgDl3Ml/dLQZSsl30YVcr/J5oBGYHHjt3OiPEVQzD7 NNSq20t3K+Ezj7BFRJuvBEl0wkh2quqDj4Mz/5s1NoMwwAxHJYfRJI09UBzFFtWlh1dnoYXuxUk qglzzL2QRG7A1ySkZftdlZUTUIBGucVMsoWh6zeAZEi8+R6U/RmOda4AHVBpoER4B+Sz6ndtz2j hXdyB/0vzKzynOb+sUTiUGrYimHqTjDBQEUesituRSX/10ZrQzxC0jlwgtQCVD7Y6y60PIjmQmM HVW4COoqaaxy0y/iwu7NQiSYChVFvpJbTlk3mXB5Jg== X-Google-Smtp-Source: AGHT+IHI+zJaSYnUtnx3ffXj628DiGINoSX38eIgjlxJ1xAZap+LyjkhOZOyUcgglPp5R2J5fAYQsw== X-Received: by 2002:a05:6000:1883:b0:385:e5d6:130c with SMTP id ffacd0b85a97d-38a87315989mr1143501f8f.51.1736321102519; Tue, 07 Jan 2025 23:25:02 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c8474b6sm52246534f8f.51.2025.01.07.23.25.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jan 2025 23:25:02 -0800 (PST) Message-ID: Date: Wed, 8 Jan 2025 08:25:00 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] xen: update pvcalls_front_accept prototype To: Stefano Stabellini Cc: jgross@suse.com, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org References: <0f8fc348-14f5-40ac-912a-1785caedb675@suse.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 08.01.2025 00:30, Stefano Stabellini wrote: > On Tue, 7 Jan 2025, Jan Beulich wrote: >> On 06.01.2025 22:36, Stefano Stabellini wrote: >>> xen: update pvcalls_front_accept prototype >>> >>> Signed-off-by: Stefano Stabellini >>> --- >>> >>> Changes in v2: >>> - also update pvcalls-front.c >> >> The patch still gives the impression of being incomplete: There's no >> caller of the function that you update. However, there's no such caller >> in the first place. Why don't you just delete the function then? > > It is meant to be called from an out-of-tree module, which has not been > upstreamed yet And which then would require an EXPORT_SYMBOL() anyway. In Xen, as you're well aware, such unreachable code would actually constitute a Misra violation. Without any in-tree caller, imo the change needs a non-empty description, clarifying why the adjustment is wanted / needed. Jan