From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DEEDC67790 for ; Fri, 27 Jul 2018 14:03:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 11CAD2064D for ; Fri, 27 Jul 2018 14:03:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 11CAD2064D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388785AbeG0PZw (ORCPT ); Fri, 27 Jul 2018 11:25:52 -0400 Received: from mail.bootlin.com ([62.4.15.54]:38629 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730737AbeG0PZv (ORCPT ); Fri, 27 Jul 2018 11:25:51 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 7AC8320798; Fri, 27 Jul 2018 16:03:44 +0200 (CEST) Received: from aptenodytes (AAubervilliers-681-1-89-120.w90-88.abo.wanadoo.fr [90.88.30.120]) by mail.bootlin.com (Postfix) with ESMTPSA id 1F06B20717; Fri, 27 Jul 2018 16:03:44 +0200 (CEST) Message-ID: Subject: Re: [PATCH 9/9] media: cedrus: Add H264 decoding support From: Paul Kocialkowski To: Chen-Yu Tsai Cc: Maxime Ripard , Hans Verkuil , Alexandre Courbot , Sakari Ailus , Laurent Pinchart , Tomasz Figa , Pawel Osciak , linux-kernel , linux-arm-kernel , Linux Media Mailing List , nicolas.dufresne@collabora.com, Jens Kuske , linux-sunxi , Thomas Petazzoni Date: Fri, 27 Jul 2018 16:03:44 +0200 In-Reply-To: References: <20180613140714.1686-1-maxime.ripard@bootlin.com> <20180613140714.1686-10-maxime.ripard@bootlin.com> <8c0b2fbec0302a15292d3629570ab1268fd306b8.camel@bootlin.com> Organization: Bootlin Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-TetegmsUWJBkTobuJJEE" X-Mailer: Evolution 3.28.4 Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-TetegmsUWJBkTobuJJEE Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Chen-Yu, On Fri, 2018-07-27 at 22:01 +0800, Chen-Yu Tsai wrote: > On Fri, Jul 27, 2018 at 9:56 PM, Paul Kocialkowski > wrote: > > Hi, > >=20 > > On Wed, 2018-06-13 at 16:07 +0200, Maxime Ripard wrote: > > > Introduce some basic H264 decoding support in cedrus. So far, only th= e > > > baseline profile videos have been tested, and some more advanced feat= ures > > > used in higher profiles are not even implemented. > >=20 > > Here are two specific comments about things I noticed when going throug= h > > the h264 code. > >=20 > > [...] > >=20 > > > @@ -88,12 +101,37 @@ struct sunxi_cedrus_ctx { > > > struct work_struct run_work; > > > struct list_head src_list; > > > struct list_head dst_list; > > > + > > > + union { > > > + struct { > > > + void *mv_col_buf; > > > + dma_addr_t mv_col_buf_dma; > > > + ssize_t mv_col_buf_size; > > > + void *neighbor_info_buf; > > > + dma_addr_t neighbor_info_buf_dma; > >=20 > > Should be "neighbour" instead of "neighbor" and the same applies to mos= t > > variables related to this, as well as the register description. >=20 > This just means you've been hanging out with people who use American > English. :) Oh wow, I honestly thought this was a typo. My mistake then! Thanks for the heads-up! Cheers, Paul --=20 Paul Kocialkowski, Bootlin (formerly Free Electrons) Embedded Linux and kernel engineering https://bootlin.com --=-TetegmsUWJBkTobuJJEE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEJZpWjZeIetVBefti3cLmz3+fv9EFAltbJkAACgkQ3cLmz3+f v9EWnwgAnt3yCgJkaA7JpP0nO0SFQDU7bzp6ZNBgG3eFwTAater8XW3PEQze6EH5 MnXBgOn6+Rld4kMmmrqFUwuUgj6c3ay3+8WWMol57dU/hgrsRfIFUbUMf/50jJi6 90inWBqxDMY9uTjy4pJmaaL4CXRwZQYG7IJcp0OB0SxY6lUXBpwyfuGvi6Q3uxGk tCZFqgXLuW2gEcaEUmci+mkYv6qnF0d6ewHe2wjh8WxcC/+O8128om3aMtYuHHpT gbnwzfDlacDFBb77paObOmtD6vTHeQ1UaZAsTPZgEKtKx8T811Gkmfy41FbknQo3 0FNd3ifcbHp3ctEc/2SFgOso9myUcg== =MbB7 -----END PGP SIGNATURE----- --=-TetegmsUWJBkTobuJJEE--